Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix yml test {p0=indices.delete_index_template/10_basic} is flaky #15171

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 4fe0358 from #15162.

…5162)

* Fix yml test {p0=indices.delete_index_template/10_basic} is flaky

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Fix warning message

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
(cherry picked from commit 4fe0358)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Aug 8, 2024

❌ Gradle check result for 18ad48a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented Aug 8, 2024

❌ Gradle check result for 18ad48a: FAILURE

@gaobinlong seems like another one? or unrelated?

java.lang.AssertionError: Failure at [ingest/70_bulk:181]: got unexpected warning header [
	299 OpenSearch-2.17.0-SNAPSHOT-18ad48a9e48c29ae4db4a7973394b7a6f7957e98 "index template [test_for_bulk_upsert_index_template] has index patterns [test_bulk_upsert_*] matching patterns from existing older templates [global] with patterns (global => [*]); this template [test_for_bulk_upsert_index_template] will take precedence during new index creation"
]

[1] https://build.ci.opensearch.org/job/gradle-check/44229/testReport/junit/org.opensearch.ingest.common/IngestCommonClientYamlTestSuiteIT/test__yaml_ingest_70_bulk_Test_bulk_upsert_honors_default_pipeline_and_final_pipeline_when_the_auto_created_index_matches_with_the_index_template_/

@gaobinlong
Copy link
Collaborator

❌ Gradle check result for 18ad48a: FAILURE

@gaobinlong seems like another one? or unrelated?

java.lang.AssertionError: Failure at [ingest/70_bulk:181]: got unexpected warning header [
	299 OpenSearch-2.17.0-SNAPSHOT-18ad48a9e48c29ae4db4a7973394b7a6f7957e98 "index template [test_for_bulk_upsert_index_template] has index patterns [test_bulk_upsert_*] matching patterns from existing older templates [global] with patterns (global => [*]); this template [test_for_bulk_upsert_index_template] will take precedence during new index creation"
]

[1] https://build.ci.opensearch.org/job/gradle-check/44229/testReport/junit/org.opensearch.ingest.common/IngestCommonClientYamlTestSuiteIT/test__yaml_ingest_70_bulk_Test_bulk_upsert_honors_default_pipeline_and_final_pipeline_when_the_auto_created_index_matches_with_the_index_template_/

This failure relates to another PR which added the test case, I've opened a new PR to fix it.

Copy link
Contributor

github-actions bot commented Aug 8, 2024

✅ Gradle check result for 18ad48a: SUCCESS

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.56%. Comparing base (e5e1bad) to head (18ad48a).
Report is 34 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15171      +/-   ##
============================================
+ Coverage     71.48%   71.56%   +0.07%     
- Complexity    62677    62784     +107     
============================================
  Files          5123     5129       +6     
  Lines        294480   294688     +208     
  Branches      42912    42941      +29     
============================================
+ Hits         210518   210883     +365     
+ Misses        66286    66133     -153     
+ Partials      17676    17672       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit 410cd3c into 2.x Aug 8, 2024
57 of 58 checks passed
@andrross andrross deleted the backport/backport-15162-to-2.x branch October 17, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants