Fix yml test {p0=indices.delete_index_template/10_basic} is flaky #15162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
gaobinlong
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
github-actions
bot
added
bug
gaobinlong
added
backport 2.x
github-actions
bot
added
bug
1 task
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15162 +/- ##
=========================================
Coverage 71.74% 71.75%
+ Complexity 62904 62848 -56
=========================================
Files 5178 5178
Lines 295167 295167
Branches 42679 42679
=========================================
+ Hits 211774 211796 +22
+ Misses 66011 65947 -64
- Partials 17382 17424 +42 ☔ View full report in Codecov by Sentry. |
|
❌ Gradle check result for 7c1efb1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
reta
approved these changes
Aug 8, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
…5162) * Fix yml test {p0=indices.delete_index_template/10_basic} is flaky Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Fix warning message Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com> (cherry picked from commit 4fe0358) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
that referenced
this pull request
Aug 8, 2024
…5162) (#15171) * Fix yml test {p0=indices.delete_index_template/10_basic} is flaky * Fix warning message --------- (cherry picked from commit 4fe0358) Signed-off-by: Gao Binlong <gbinlong@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi
pushed a commit
to harshavamsi/OpenSearch
that referenced
this pull request
Aug 20, 2024
…ensearch-project#15162) * Fix yml test {p0=indices.delete_index_template/10_basic} is flaky Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Fix warning message Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
…ensearch-project#15162) * Fix yml test {p0=indices.delete_index_template/10_basic} is flaky Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Fix warning message Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com>
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Sep 10, 2024
…ensearch-project#15162) * Fix yml test {p0=indices.delete_index_template/10_basic} is flaky Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Fix warning message Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=indices.delete_index_template/10_basic/Delete index template which is not used by data stream but index pattern matches}is flaky, the reason is that the mixed version cluster has a template with index patterns*, so when creating a new index template, the API returns a warning headerindex template [test_template_1] has index patterns [test-*]....Related Issues
Resolves #15161
Check List
- [ ] Functionality includes testing.
- [ ] API changes companion pull request created, if applicable.
- [ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.