-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace and block usages of org.apache.logging.log4j.util.Strings #15238
Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
❌ Gradle check result for cba60b2: TIMEOUT Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15238 +/- ##
=========================================
Coverage 71.89% 71.89%
- Complexity 63043 63071 +28
=========================================
Files 5197 5197
Lines 295311 295311
Branches 42676 42677 +1
=========================================
+ Hits 212314 212316 +2
- Misses 65552 65598 +46
+ Partials 17445 17397 -48 ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15238-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d74e276af68edbc5caf382fd2e61f11b9935c221
# Push it to GitHub
git push --set-upstream origin backport/backport-15238-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
@cwperks backport manually please? |
…ensearch-project#15238) * Replace and block usages of org.apache.logging.log4j.util.Strings Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add to CHANGELOG Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit d74e276)
…rch Core Signed-off-by: Varun Jain <varunudr@amazon.com>
* Upgrade BWC version and fix neural search build (#868) Signed-off-by: Varun Jain <varunudr@amazon.com> * Incrementing opensearch version to 2.17.0-SNAPSHOT Signed-off-by: Varun Jain <varunudr@amazon.com> * Incorporate fix from opensearch-project/OpenSearch#15238 from OpenSearch Core Signed-off-by: Varun Jain <varunudr@amazon.com> * Address Naveen's comment Signed-off-by: Varun Jain <varunudr@amazon.com> --------- Signed-off-by: Varun Jain <varunudr@amazon.com>
…ensearch-project#15238) * Replace and block usages of org.apache.logging.log4j.util.Strings Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add to CHANGELOG Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>
…ensearch-project#15238) * Replace and block usages of org.apache.logging.log4j.util.Strings Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add to CHANGELOG Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>
Description
Replaces usages of
org.apache.logging.log4j.util.Strings
andjoptsimple.internal.Strings
withorg.opensearch.core.common.Strings
. This PR also makes the classes forbidden to prevent the precommit check from passing if there are any usages oforg.apache.logging.log4j.util.Strings
orjoptsimple.internal.Strings
.Related Issues
Resolves #15211
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.