Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Replace and block usages of org.apache.logging.log4j.util.Strings (#15238) #15246

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Aug 14, 2024

Manual backport of #15238 to 2.x. There was a conflict in RestClientBuilderTestCase with the import of Header from Apache HttpClient v4 on 2.x vs Apache HttpClient v5 on main.

…ensearch-project#15238)

* Replace and block usages of org.apache.logging.log4j.util.Strings

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit d74e276)
Copy link
Contributor

❌ Gradle check result for 1af0a13: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 1af0a13: SUCCESS

@reta reta merged commit 7552bb8 into opensearch-project:2.x Aug 14, 2024
55 checks passed
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.47%. Comparing base (e66bcdf) to head (1af0a13).
Report is 2 commits behind head on 2.x.

Files Patch % Lines
...teway/remote/RemoteClusterStateCleanupManager.java 0.00% 0 Missing and 2 partials ⚠️
.../main/java/org/opensearch/env/NodeEnvironment.java 0.00% 0 Missing and 1 partial ⚠️
...ain/java/org/opensearch/index/shard/ShardPath.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15246      +/-   ##
============================================
- Coverage     71.56%   71.47%   -0.09%     
+ Complexity    62859    62806      -53     
============================================
  Files          5138     5138              
  Lines        295074   295074              
  Branches      42978    42979       +1     
============================================
- Hits         211168   210914     -254     
- Misses        66226    66509     +283     
+ Partials      17680    17651      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants