-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Remote Publication a static setting #15478
Make Remote Publication a static setting #15478
Conversation
❌ Gradle check result for d05aff2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
2922ebf
to
49ae83f
Compare
❌ Gradle check result for 2922ebf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
49ae83f
to
97f1680
Compare
❌ Gradle check result for 887e470: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 97f1680: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
97f1680
to
21a20f4
Compare
❌ Gradle check result for c2b1e3f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for c2b1e3f: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15478 +/- ##
============================================
- Coverage 71.95% 71.83% -0.13%
+ Complexity 64196 64132 -64
============================================
Files 5271 5271
Lines 300171 300171
Branches 43380 43380
============================================
- Hits 215990 215624 -366
- Misses 66476 66856 +380
+ Partials 17705 17691 -14 ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15478-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3fdbd8b7308149d5432f8d04b8040e15a934c906
# Push it to GitHub
git push --set-upstream origin backport/backport-15478-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.17
# Create a new branch
git switch --create backport/backport-15478-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3fdbd8b7308149d5432f8d04b8040e15a934c906
# Push it to GitHub
git push --set-upstream origin backport/backport-15478-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.17 Then, create a pull request where the |
* Make Remote Publication a static setting Signed-off-by: Shivansh Arora <hishiv@amazon.com> (cherry picked from commit 3fdbd8b)
* Make Remote Publication a static setting Signed-off-by: Shivansh Arora <hishiv@amazon.com> (cherry picked from commit 3fdbd8b)
* Make Remote Publication a static setting Signed-off-by: Shivansh Arora <hishiv@amazon.com>
* Make Remote Publication a static setting Signed-off-by: Shivansh Arora <hishiv@amazon.com>
* Make Remote Publication a static setting Signed-off-by: Shivansh Arora <hishiv@amazon.com>
* Make Remote Publication a static setting Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
Made the Remote publication setting a dynamic setting instead of a feature flag. Also, whenever the setting is toggled, we send the full state to all the nodes/remote store.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.