Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Remote Publication a static setting #15478

Merged

Conversation

shiv0408
Copy link
Member

@shiv0408 shiv0408 commented Aug 28, 2024

Description

Made the Remote publication setting a dynamic setting instead of a feature flag. Also, whenever the setting is toggled, we send the full state to all the nodes/remote store.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for d05aff2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@mgodwan mgodwan mentioned this pull request Aug 29, 2024
3 tasks
@shiv0408 shiv0408 force-pushed the publication-setting-change branch 3 times, most recently from 2922ebf to 49ae83f Compare September 3, 2024 11:37
Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Gradle check result for 2922ebf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shiv0408 shiv0408 force-pushed the publication-setting-change branch from 49ae83f to 97f1680 Compare September 3, 2024 11:44
@shiv0408 shiv0408 changed the title Make remote publication a dynamic setting Make Remote Publication a static setting Sep 3, 2024
Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Gradle check result for 887e470: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Gradle check result for 97f1680: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for c2b1e3f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shiv0408
Copy link
Member Author

shiv0408 commented Sep 5, 2024

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❕ Gradle check result for c2b1e3f: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.83%. Comparing base (6f2ea39) to head (c2b1e3f).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...search/cluster/coordination/CoordinationState.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15478      +/-   ##
============================================
- Coverage     71.95%   71.83%   -0.13%     
+ Complexity    64196    64132      -64     
============================================
  Files          5271     5271              
  Lines        300171   300171              
  Branches      43380    43380              
============================================
- Hits         215990   215624     -366     
- Misses        66476    66856     +380     
+ Partials      17705    17691      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shwetathareja shwetathareja merged commit 3fdbd8b into opensearch-project:main Sep 6, 2024
34 of 35 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15478-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3fdbd8b7308149d5432f8d04b8040e15a934c906
# Push it to GitHub
git push --set-upstream origin backport/backport-15478-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15478-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.17
# Create a new branch
git switch --create backport/backport-15478-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3fdbd8b7308149d5432f8d04b8040e15a934c906
# Push it to GitHub
git push --set-upstream origin backport/backport-15478-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-15478-to-2.17.

shiv0408 added a commit to shiv0408/OpenSearch that referenced this pull request Sep 6, 2024
* Make Remote Publication a static setting

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
(cherry picked from commit 3fdbd8b)
shiv0408 added a commit to shiv0408/OpenSearch that referenced this pull request Sep 6, 2024
* Make Remote Publication a static setting

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
(cherry picked from commit 3fdbd8b)
shwetathareja pushed a commit that referenced this pull request Sep 6, 2024
…5784)

* Make Remote Publication a static setting (#15478)

* Make Remote Publication a static setting

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
(cherry picked from commit 3fdbd8b)
shwetathareja pushed a commit that referenced this pull request Sep 9, 2024
)

* Make Remote Publication a static setting (#15478)

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
(cherry picked from commit 3fdbd8b)
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
* Make Remote Publication a static setting

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
* Make Remote Publication a static setting

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
* Make Remote Publication a static setting

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
* Make Remote Publication a static setting

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants