Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.17] Make Remote Publication a static setting (#15478) #15784

Conversation

shiv0408
Copy link
Member

@shiv0408 shiv0408 commented Sep 6, 2024

cherry-pick 3fdbd8b from #15478

* Make Remote Publication a static setting

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
(cherry picked from commit 3fdbd8b)
Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Gradle check result for e2ef6bd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Gradle check result for 7e0dbd5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shiv0408 shiv0408 closed this Sep 6, 2024
@shiv0408 shiv0408 reopened this Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

❕ Gradle check result for 7e0dbd5: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.67%. Comparing base (9f95932) to head (7e0dbd5).
Report is 8 commits behind head on 2.17.

Files with missing lines Patch % Lines
...search/cluster/coordination/CoordinationState.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               2.17   #15784      +/-   ##
============================================
- Coverage     71.68%   71.67%   -0.01%     
+ Complexity    64484    64478       -6     
============================================
  Files          5263     5263              
  Lines        301615   301621       +6     
  Branches      43913    43914       +1     
============================================
- Hits         216199   216190       -9     
- Misses        67356    67386      +30     
+ Partials      18060    18045      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shwetathareja shwetathareja merged commit 6a9cf90 into opensearch-project:2.17 Sep 6, 2024
63 of 67 checks passed
@shiv0408 shiv0408 deleted the backport/backport-15478-to-2.17 branch September 6, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants