Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Star tree][Bug] Fix for derived metrics #15640

Merged
merged 5 commits into from
Sep 4, 2024

Conversation

bharath-techie
Copy link
Contributor

@bharath-techie bharath-techie commented Sep 4, 2024

Description

We need to exclude derived metrics throughout the star tree build and file formats, which we were not doing properly.

To fix this introducing a new method getBaseMetrics() itself so that we don't miss in any case. All src code only use getBaseMetrics() now.

Related Issues

Resolves #15641

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❕ Gradle check result for 3ec11d3: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.84%. Comparing base (e087272) to head (15b2e4d).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...be/startree/fileformats/meta/StarTreeMetadata.java 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15640      +/-   ##
============================================
- Coverage     72.00%   71.84%   -0.16%     
+ Complexity    64149    64064      -85     
============================================
  Files          5269     5269              
  Lines        299834   299880      +46     
  Branches      43330    43343      +13     
============================================
- Hits         215895   215463     -432     
- Misses        66217    66649     +432     
- Partials      17722    17768      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 1207ded: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 87abc91: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 1207ded: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

2 similar comments
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 1207ded: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 1207ded: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 4, 2024

✅ Gradle check result for 15b2e4d: SUCCESS

@sachinpkale sachinpkale merged commit 71a771e into opensearch-project:main Sep 4, 2024
34 checks passed
@bharath-techie bharath-techie added the backport 2.x Backport to 2.x branch label Sep 4, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 4, 2024
* Fix for derived metrics

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>

* fixes for byte

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>

---------

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
(cherry picked from commit 71a771e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale pushed a commit that referenced this pull request Sep 5, 2024
---------


(cherry picked from commit 71a771e)

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 5, 2024
---------

(cherry picked from commit 71a771e)

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 52ffa16)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
bharath-techie pushed a commit to bharath-techie/OpenSearch that referenced this pull request Sep 5, 2024
…pensearch-project#15686)

---------


(cherry picked from commit 71a771e)

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
bharath-techie pushed a commit to bharath-techie/OpenSearch that referenced this pull request Sep 5, 2024
…pensearch-project#15686)

---------

(cherry picked from commit 71a771e)

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale pushed a commit that referenced this pull request Sep 5, 2024
---------

(cherry picked from commit 71a771e)

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
* Fix for derived metrics

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>

* fixes for byte

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>

---------

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working Indexing:Performance skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Star tree derived metrics is not handled properly
4 participants