[Star tree][Bug] Fix for derived metrics #15640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
bharath-techie
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
...c/main/java/org/opensearch/index/codec/composite/composite99/Composite99DocValuesReader.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/compositeindex/datacube/Metric.java
Show resolved
Hide resolved
...org/opensearch/index/compositeindex/datacube/startree/fileformats/meta/StarTreeMetadata.java
Show resolved
Hide resolved
|
❕ Gradle check result for 3ec11d3: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15640 +/- ##
============================================
- Coverage 72.00% 71.84% -0.16%
+ Complexity 64149 64064 -85
============================================
Files 5269 5269
Lines 299834 299880 +46
Branches 43330 43343 +13
============================================
- Hits 215895 215463 -432
- Misses 66217 66649 +432
- Partials 17722 17768 +46 ☔ View full report in Codecov by Sentry. |
mgodwan
approved these changes
Sep 4, 2024
|
❌ Gradle check result for 1207ded: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 87abc91: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 1207ded: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
2 similar comments
|
❌ Gradle check result for 1207ded: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 1207ded: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
sachinpkale
approved these changes
Sep 4, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
* Fix for derived metrics Signed-off-by: Bharathwaj G <bharath78910@gmail.com> * fixes for byte Signed-off-by: Bharathwaj G <bharath78910@gmail.com> --------- Signed-off-by: Bharathwaj G <bharath78910@gmail.com> (cherry picked from commit 71a771e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale
pushed a commit
that referenced
this pull request
Sep 5, 2024
--------- (cherry picked from commit 71a771e) Signed-off-by: Bharathwaj G <bharath78910@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
--------- (cherry picked from commit 71a771e) Signed-off-by: Bharathwaj G <bharath78910@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 52ffa16) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
bharath-techie
pushed a commit
to bharath-techie/OpenSearch
that referenced
this pull request
Sep 5, 2024
…pensearch-project#15686) --------- (cherry picked from commit 71a771e) Signed-off-by: Bharathwaj G <bharath78910@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
3 tasks
bharath-techie
pushed a commit
to bharath-techie/OpenSearch
that referenced
this pull request
Sep 5, 2024
…pensearch-project#15686) --------- (cherry picked from commit 71a771e) Signed-off-by: Bharathwaj G <bharath78910@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale
pushed a commit
that referenced
this pull request
Sep 5, 2024
--------- (cherry picked from commit 71a771e) Signed-off-by: Bharathwaj G <bharath78910@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Sep 6, 2024
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Sep 10, 2024
* Fix for derived metrics Signed-off-by: Bharathwaj G <bharath78910@gmail.com> * fixes for byte Signed-off-by: Bharathwaj G <bharath78910@gmail.com> --------- Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
* Fix for derived metrics Signed-off-by: Bharathwaj G <bharath78910@gmail.com> * fixes for byte Signed-off-by: Bharathwaj G <bharath78910@gmail.com> --------- Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
* Fix for derived metrics Signed-off-by: Bharathwaj G <bharath78910@gmail.com> * fixes for byte Signed-off-by: Bharathwaj G <bharath78910@gmail.com> --------- Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
* Fix for derived metrics Signed-off-by: Bharathwaj G <bharath78910@gmail.com> * fixes for byte Signed-off-by: Bharathwaj G <bharath78910@gmail.com> --------- Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to exclude derived metrics throughout the star tree build and file formats, which we were not doing properly.
To fix this introducing a new method getBaseMetrics() itself so that we don't miss in any case. All src code only use getBaseMetrics() now.
Related Issues
Resolves #15641
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.