Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Star tree][Bug] Fix for derived metrics #15686

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 71a771e from #15640.

* Fix for derived metrics

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>

* fixes for byte

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>

---------

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
(cherry picked from commit 71a771e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 17961f6: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 4, 2024

✅ Gradle check result for 17961f6: SUCCESS

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.76%. Comparing base (5875393) to head (17961f6).
Report is 25 commits behind head on 2.x.

Files with missing lines Patch % Lines
...be/startree/fileformats/meta/StarTreeMetadata.java 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15686      +/-   ##
============================================
+ Coverage     71.70%   71.76%   +0.06%     
- Complexity    64104    64235     +131     
============================================
  Files          5249     5251       +2     
  Lines        299681   300431     +750     
  Branches      43643    43725      +82     
============================================
+ Hits         214876   215615     +739     
+ Misses        66848    66749      -99     
- Partials      17957    18067     +110     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sachinpkale sachinpkale merged commit 52ffa16 into 2.x Sep 5, 2024
87 of 91 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 5, 2024
---------

(cherry picked from commit 71a771e)

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 52ffa16)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor Author

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/backport-2.17
# Create a new branch
git switch --create backport/backport-15686-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 52ffa161278c45f4ffffd3b4908a2d2a141f37f3
# Push it to GitHub
git push --set-upstream origin backport/backport-15686-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-15686-to-2.17.

bharath-techie pushed a commit to bharath-techie/OpenSearch that referenced this pull request Sep 5, 2024
…pensearch-project#15686)

---------


(cherry picked from commit 71a771e)

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
bharath-techie pushed a commit to bharath-techie/OpenSearch that referenced this pull request Sep 5, 2024
…pensearch-project#15686)

---------

(cherry picked from commit 71a771e)

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale pushed a commit that referenced this pull request Sep 5, 2024
---------

(cherry picked from commit 71a771e)

Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@andrross andrross deleted the backport/backport-15640-to-2.x branch October 17, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants