-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] [Star Tree] Scaled Float Support #15660
Conversation
--------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit 23f5c2f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
❌ Gradle check result for e359c49: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for e359c49: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #15660 +/- ##
============================================
- Coverage 71.74% 71.52% -0.22%
+ Complexity 64157 64030 -127
============================================
Files 5250 5250
Lines 299925 299917 -8
Branches 43672 43678 +6
============================================
- Hits 215176 214523 -653
- Misses 66742 67393 +651
+ Partials 18007 18001 -6 ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/backport-2.17
# Create a new branch
git switch --create backport/backport-15660-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c801270b150083c0f15f8c1f70e3c6d8f731cac0
# Push it to GitHub
git push --set-upstream origin backport/backport-15660-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.17 Then, create a pull request where the |
--------- (cherry picked from commit 23f5c2f) Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit c801270) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/backport-2.17
# Create a new branch
git switch --create backport/backport-15660-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c801270b150083c0f15f8c1f70e3c6d8f731cac0
# Push it to GitHub
git push --set-upstream origin backport/backport-15660-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.17 Then, create a pull request where the |
…ch-project#15660) --------- (cherry picked from commit 23f5c2f) Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit c801270) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
--------- (cherry picked from commit 23f5c2f) (cherry picked from commit c801270) Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Backport 23f5c2f from #15442.