Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Star Tree] Scaled Float Support #15660

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 23f5c2f from #15442.

---------

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
(cherry picked from commit 23f5c2f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for e359c49: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 4, 2024

❕ Gradle check result for e359c49: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.action.admin.indices.create.CreateIndexIT.testCreateAndDeleteIndexConcurrently
      1 org.opensearch.action.admin.indices.create.CreateIndexIT.classMethod

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 20 lines in your changes missing coverage. Please review.

Project coverage is 71.52%. Comparing base (d368e3b) to head (e359c49).
Report is 3 commits behind head on 2.x.

Files with missing lines Patch % Lines
...startree/builder/AbstractDocumentsFileManager.java 79.16% 2 Missing and 3 partials ⚠️
...datacube/startree/builder/BaseStarTreeBuilder.java 50.00% 1 Missing and 4 partials ⚠️
...ndex/compositeindex/datacube/DimensionFactory.java 20.00% 0 Missing and 4 partials ⚠️
...pensearch/index/mapper/ScaledFloatFieldMapper.java 60.00% 2 Missing ⚠️
...org/opensearch/index/mapper/NumberFieldMapper.java 87.50% 1 Missing and 1 partial ⚠️
...ube/startree/aggregators/MetricAggregatorInfo.java 75.00% 1 Missing ⚠️
...g/opensearch/index/mapper/DocCountFieldMapper.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15660      +/-   ##
============================================
- Coverage     71.74%   71.52%   -0.22%     
+ Complexity    64157    64030     -127     
============================================
  Files          5250     5250              
  Lines        299925   299917       -8     
  Branches      43672    43678       +6     
============================================
- Hits         215176   214523     -653     
- Misses        66742    67393     +651     
+ Partials      18007    18001       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashking94 ashking94 merged commit c801270 into 2.x Sep 4, 2024
60 of 61 checks passed
@opensearch-trigger-bot
Copy link
Contributor Author

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/backport-2.17
# Create a new branch
git switch --create backport/backport-15660-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c801270b150083c0f15f8c1f70e3c6d8f731cac0
# Push it to GitHub
git push --set-upstream origin backport/backport-15660-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-15660-to-2.17.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 4, 2024
---------

(cherry picked from commit 23f5c2f)

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit c801270)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor Author

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/backport-2.17
# Create a new branch
git switch --create backport/backport-15660-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c801270b150083c0f15f8c1f70e3c6d8f731cac0
# Push it to GitHub
git push --set-upstream origin backport/backport-15660-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-15660-to-2.17.

sarthakaggarwal97 pushed a commit to sarthakaggarwal97/OpenSearch that referenced this pull request Sep 5, 2024
…ch-project#15660)

---------

(cherry picked from commit 23f5c2f)

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit c801270)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna pushed a commit that referenced this pull request Sep 5, 2024
---------

(cherry picked from commit 23f5c2f)




(cherry picked from commit c801270)

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@andrross andrross deleted the backport/backport-15442-to-2.x branch October 17, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants