Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.17] [Backport 2.x] [Star Tree] Scaled Float Support #15716

Merged
merged 1 commit into from
Sep 5, 2024
Merged

[Backport 2.17] [Backport 2.x] [Star Tree] Scaled Float Support #15716

merged 1 commit into from
Sep 5, 2024

Conversation

sarthakaggarwal97
Copy link
Contributor

@sarthakaggarwal97 sarthakaggarwal97 commented Sep 5, 2024 •
edited by gbbafna
Loading

Description

Backport c801270 from #15660.

Related Issues

Resolves [Backport 2.x] [Star tree] Star tree index validations (#15533) (#15610)

@github-actions @sarthakaggarwal97
[Star Tree] Scaled Float Support (opensearch-project#15442) (opensear…
047a9f1 
…ch-project#15660)

---------

(cherry picked from commit 23f5c2f)

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit c801270)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ Gradle check result for 047a9f1: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Sep 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.77778% with 20 lines in your changes missing coverage. Please review.

Project coverage is 71.65%. Comparing base (cea8eea) to head (047a9f1).
Report is 3 commits behind head on 2.17.

Files with missing lines Patch % Lines
...startree/builder/AbstractDocumentsFileManager.java 79.16% 2 Missing and 3 partials ⚠️
...datacube/startree/builder/BaseStarTreeBuilder.java 50.00% 1 Missing and 4 partials ⚠️
...ndex/compositeindex/datacube/DimensionFactory.java 20.00% 0 Missing and 4 partials ⚠️
...pensearch/index/mapper/ScaledFloatFieldMapper.java 60.00% 2 Missing ⚠️
...org/opensearch/index/mapper/NumberFieldMapper.java 87.50% 1 Missing and 1 partial ⚠️
...ube/startree/aggregators/MetricAggregatorInfo.java 75.00% 1 Missing ⚠️
...g/opensearch/index/mapper/DocCountFieldMapper.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               2.17   #15716      +/-   ##
============================================
- Coverage     71.68%   71.65%   -0.03%     
+ Complexity    64322    64315       -7     
============================================
  Files          5262     5262              
  Lines        300929   300921       -8     
  Branches      43803    43809       +6     
============================================
- Hits         215709   215636      -73     
- Misses        67105    67200      +95     
+ Partials      18115    18085      -30

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbbafna gbbafna merged commit e76dcf9 into opensearch-project:2.17 Sep 5, 2024
59 of 61 checks passed
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 6, 2024
Open
@sarthakaggarwal97 sarthakaggarwal97 mentioned this pull request Sep 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbbafna gbbafna gbbafna approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarthakaggarwal97 @gbbafna