Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset discovery nodes in most transport node actions request. (#15131) #15674

Merged

Conversation

SwethaGuptha
Copy link
Contributor

Description

Backport #15131 to 2.17

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for f884471: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@SwethaGuptha SwethaGuptha force-pushed the backport-15131-to-2.17 branch from f884471 to 2a947c6 Compare September 4, 2024 11:55
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 2a947c6: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 1f8a48d: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@SwethaGuptha SwethaGuptha force-pushed the backport-15131-to-2.17 branch from 1f8a48d to 6d59900 Compare September 4, 2024 12:29
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 6d59900: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for f559e19: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…arch-project#15131)

Signed-off-by: Swetha Guptha <gupthasg@amazon.com>
Co-authored-by: Swetha Guptha <gupthasg@amazon.com>
@SwethaGuptha SwethaGuptha force-pushed the backport-15131-to-2.17 branch from 6d3bc1c to c555392 Compare September 5, 2024 04:15
Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 6d3bc1c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 6d3bc1c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❕ Gradle check result for c555392: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 64.28571% with 10 lines in your changes missing coverage. Please review.

Project coverage is 71.69%. Comparing base (ed66587) to head (c555392).
Report is 7 commits behind head on 2.17.

Files with missing lines Patch % Lines
...ices/dangling/list/ListDanglingIndicesRequest.java 0.00% 2 Missing ⚠️
...luster/node/hotthreads/NodesHotThreadsRequest.java 0.00% 1 Missing ⚠️
...on/admin/cluster/node/usage/NodesUsageRequest.java 0.00% 1 Missing ⚠️
...napshots/status/TransportNodesSnapshotsStatus.java 0.00% 1 Missing ⚠️
...ndices/dangling/find/FindDanglingIndexRequest.java 0.00% 1 Missing ⚠️
...ch/gateway/TransportNodesListGatewayMetaState.java 0.00% 1 Missing ⚠️
...y/TransportNodesListGatewayStartedShardsBatch.java 0.00% 1 Missing ⚠️
...es/store/TransportNodesListShardStoreMetadata.java 0.00% 1 Missing ⚠️
...ore/TransportNodesListShardStoreMetadataBatch.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               2.17   #15674      +/-   ##
============================================
+ Coverage     71.57%   71.69%   +0.11%     
- Complexity    64246    64404     +158     
============================================
  Files          5261     5262       +1     
  Lines        300903   301005     +102     
  Branches      43799    43822      +23     
============================================
+ Hits         215376   215794     +418     
+ Misses        67507    67189     -318     
- Partials      18020    18022       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shwetathareja shwetathareja merged commit 4589765 into opensearch-project:2.17 Sep 5, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants