Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add new cluster setting for keyword indexordocvalues query (#15637) #15703

Merged

Conversation

harshavamsi
Copy link
Contributor

  • Add new cluster setting for keyword indexordocvalues query

Signed-off-by: Harsha Vamsi Kalluri harshavamsi096@gmail.com

  • Fix tests

Signed-off-by: Harsha Vamsi Kalluri harshavamsi096@gmail.com


Signed-off-by: Harsha Vamsi Kalluri harshavamsi096@gmail.com
(cherry picked from commit d64baa6)

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for 55deb24: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❕ Gradle check result for 55deb24: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.61%. Comparing base (dcdc4d2) to head (07eedb0).
Report is 3 commits behind head on 2.x.

Files with missing lines Patch % Lines
...rg/opensearch/index/mapper/KeywordFieldMapper.java 70.00% 1 Missing and 2 partials ⚠️
.../org/opensearch/search/internal/SearchContext.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15703      +/-   ##
============================================
+ Coverage     71.55%   71.61%   +0.05%     
- Complexity    64312    64363      +51     
============================================
  Files          5262     5262              
  Lines        301279   301310      +31     
  Branches      43861    43866       +5     
============================================
+ Hits         215574   215774     +200     
+ Misses        67703    67526     -177     
- Partials      18002    18010       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ Gradle check result for 4faae6e: SUCCESS

…h-project#15637)

* Add new cluster setting for keyword indexordocvalues query

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Fix tests

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

---------

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
(cherry picked from commit d64baa6)
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
@harshavamsi harshavamsi force-pushed the backport/backport-15637-to-2.x branch from 4faae6e to 42b44ec Compare September 5, 2024 17:13
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ Gradle check result for 42b44ec: SUCCESS

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❕ Gradle check result for 07eedb0: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@msfroh msfroh merged commit bb0a497 into opensearch-project:2.x Sep 5, 2024
35 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/backport-2.17
# Create a new branch
git switch --create backport/backport-15703-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bb0a49758df8380eab748aefeafb5a69ae5cf59f
# Push it to GitHub
git push --set-upstream origin backport/backport-15703-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-15703-to-2.17.

@msfroh
Copy link
Collaborator

msfroh commented Sep 5, 2024

Removing the backport 2.17 label, since it was backported manually in #15751

andrross added a commit to andrross/OpenSearch that referenced this pull request Oct 28, 2024
This was backported in opensearch-project#15703 so it should no longer be listed in the
changelog.

Signed-off-by: Andrew Ross <andrross@amazon.com>
dbwiddis pushed a commit that referenced this pull request Oct 29, 2024
This was backported in #15703 so it should no longer be listed in the
changelog.

Signed-off-by: Andrew Ross <andrross@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants