Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide factory for pluggable deciders #15713

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

Gankris96
Copy link
Contributor

Description

Follow up of #15363
Modify the way plugins can provide deciders.
Provide a factory that plugins can implement to create decider objects.

Related Issues

Resolves #15259

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for b58f018: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 0093c65: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 154fb6f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 154fb6f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sohami
Copy link
Collaborator

sohami commented Sep 5, 2024

❌ Gradle check result for 154fb6f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Looks to be some issue on main. gradle check on other PRs are also failing with same error

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':distribution:bwc:minor:buildBwcLinuxTar'.
> Building 2.17.0 didn't generate expected file /var/jenkins/workspace/gradle-check/search/distribution/bwc/minor/build/bwc/checkout-2.x/distribution/archives/linux-tar/build/distributions/opensearch-min-2.17.0-SNAPSHOT-linux-x64.tar.gz

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 154fb6f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 154fb6f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 5057ab1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jed326 jed326 added the v2.17.0 label Sep 5, 2024
Signed-off-by: Ganesh Ramadurai <gramadur@icloud.com>
Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ Gradle check result for 5b2e58b: SUCCESS

@jed326 jed326 merged commit c505709 into opensearch-project:main Sep 5, 2024
33 checks passed
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.85%. Comparing base (729e40d) to head (5b2e58b).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...earch/deciders/ConcurrentSearchRequestDecider.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15713      +/-   ##
============================================
- Coverage     71.95%   71.85%   -0.11%     
+ Complexity    64192    64113      -79     
============================================
  Files          5270     5271       +1     
  Lines        300052   300169     +117     
  Branches      43368    43380      +12     
============================================
- Hits         215917   215685     -232     
- Misses        66442    66762     +320     
- Partials      17693    17722      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

neetikasinghal added a commit to neetikasinghal/OpenSearch that referenced this pull request Sep 5, 2024
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
Signed-off-by: Ganesh Ramadurai <gramadur@icloud.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
Signed-off-by: Ganesh Ramadurai <gramadur@icloud.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
Signed-off-by: Ganesh Ramadurai <gramadur@icloud.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
Signed-off-by: Ganesh Ramadurai <gramadur@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Roadmap:Cost/Performance/Scale Project-wide roadmap label Search:Performance skip-changelog v2.17.0
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[RFC] Provide pluggable deciders for concurrent search
3 participants