-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide factory for pluggable deciders #15713
Conversation
❌ Gradle check result for b58f018: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
b58f018
to
0093c65
Compare
❌ Gradle check result for 0093c65: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 154fb6f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 154fb6f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Looks to be some issue on main. gradle check on other PRs are also failing with same error
|
❌ Gradle check result for 154fb6f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
154fb6f
to
5057ab1
Compare
❌ Gradle check result for 154fb6f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 5057ab1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Ganesh Ramadurai <gramadur@icloud.com>
5057ab1
to
5b2e58b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15713 +/- ##
============================================
- Coverage 71.95% 71.85% -0.11%
+ Complexity 64192 64113 -79
============================================
Files 5270 5271 +1
Lines 300052 300169 +117
Branches 43368 43380 +12
============================================
- Hits 215917 215685 -232
- Misses 66442 66762 +320
- Partials 17693 17722 +29 ☔ View full report in Codecov by Sentry. |
)" This reverts commit c505709.
Signed-off-by: Ganesh Ramadurai <gramadur@icloud.com>
Signed-off-by: Ganesh Ramadurai <gramadur@icloud.com>
Signed-off-by: Ganesh Ramadurai <gramadur@icloud.com>
Signed-off-by: Ganesh Ramadurai <gramadur@icloud.com>
Description
Follow up of #15363
Modify the way plugins can provide deciders.
Provide a factory that plugins can implement to create decider objects.
Related Issues
Resolves #15259
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.