Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.17] Provide factory for pluggable deciders #15734

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

Gankris96
Copy link
Contributor

Description

Backport of #15713

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❕ Gradle check result for 6879c30: UNSTABLE

  • TEST FAILURES:
      2 org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=search.aggregation/360_date_histogram/Date histogram aggregation w/ shared field range test}
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testSnapshotWithStuckNode

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.70%. Comparing base (75fb5bc) to head (b318c6a).
Report is 5 commits behind head on 2.17.

Files with missing lines Patch % Lines
...earch/deciders/ConcurrentSearchRequestDecider.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               2.17   #15734      +/-   ##
============================================
+ Coverage     71.66%   71.70%   +0.03%     
- Complexity    64317    64431     +114     
============================================
  Files          5262     5263       +1     
  Lines        301148   301180      +32     
  Branches      43841    43846       +5     
============================================
+ Hits         215829   215960     +131     
+ Misses        67259    67144     -115     
- Partials      18060    18076      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gankris96 Gankris96 force-pushed the backport-2.17-15713-fix branch from 6879c30 to 2ec900a Compare September 5, 2024 09:03
Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ Gradle check result for 2ec900a: SUCCESS

Signed-off-by: Ganesh Ramadurai <gramadur@icloud.com>
@jed326 jed326 force-pushed the backport-2.17-15713-fix branch from 2ec900a to b318c6a Compare September 5, 2024 15:33
@jed326 jed326 added the v2.17.0 label Sep 5, 2024
Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for b318c6a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 5, 2024

✅ Gradle check result for b318c6a: SUCCESS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants