Add new parameters to snapshot restore to rename the restored aliases… #16292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mispencer
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
github-actions
bot
added
enhancement
|
❌ Gradle check result for 8e511d6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
mispencer
force-pushed
the
AliasRenameSnapshotRestore
branch
from
0868e91 to
019c62f
Compare
|
❌ Gradle check result for 019c62f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com>
Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com>
Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com>
Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com>
Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com>
Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com>
Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com>
…2.18 later once it is backported into that version. Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com>
Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com>
…t understand. Also some refactoring. Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com>
Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com>
mispencer
force-pushed
the
AliasRenameSnapshotRestore
branch
from
4c34e17 to
50e07d3
Compare
|
❌ Gradle check result for 50e07d3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This was referenced Oct 22, 2024
Signed-off-by: Daniel Widdis <widdis@gmail.com>
dbwiddis
approved these changes
Oct 23, 2024
dbwiddis
approved these changes
Oct 23, 2024
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16292-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9489a21a7466dbc6320b4b53c828ff3bfbce2b22
# Push it to GitHub
git push --set-upstream origin backport/backport-16292-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.xThen, create a pull request where the |
dbwiddis
added a commit
to dbwiddis/OpenSearch
that referenced
this pull request
Oct 23, 2024
opensearch-project#16292) * Add new parameters to snapshot restore to rename the restored aliases similar to the existing parameters to rename indexes Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com> * Fix comment. Update changelog. Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com> * New parameters needs to only used for new version Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com> * Add missing equals and hash implemenation for new parameters Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com> * Add some tests Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com> * Add some more tests Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com> * Use CountDownLatch Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com> * Add two more tests. Refactoring and cleanup. Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com> * Use CURRENT version to pass backward compatibility tests. Change to V2.18 later once it is backported into that version. Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com> * Refactoring Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com> * Overwriting aliases variable causes test failures for reasons I do not understand. Also some refactoring. Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com> * Convert to paramaterized tests Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com> --------- Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com> Signed-off-by: Daniel Widdis <widdis@gmail.com> Co-authored-by: Daniel Widdis <widdis@gmail.com>
saratvemulapalli
pushed a commit
that referenced
this pull request
Oct 23, 2024
#16292) (#16447) * Add new parameters to snapshot restore to rename the restored aliases similar to the existing parameters to rename indexes * Fix comment. Update changelog. * New parameters needs to only used for new version * Add missing equals and hash implemenation for new parameters * Add some tests * Add some more tests * Use CountDownLatch * Add two more tests. Refactoring and cleanup. * Use CURRENT version to pass backward compatibility tests. Change to V2.18 later once it is backported into that version. * Refactoring * Overwriting aliases variable causes test failures for reasons I do not understand. Also some refactoring. * Convert to paramaterized tests --------- Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com> Signed-off-by: Daniel Widdis <widdis@gmail.com> Co-authored-by: Spencer G. Jones <spencer.jones2@tylertech.com>
|
@dbwiddis - do you intend to make a PR to update the versions in the RestoreSnapshotRequest.java, or do you want me to do that? |
@mispencer Please track this and follow it through to completion. I (and most maintainers) are juggling multiple workstreams. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new parameters to snapshot restore to rename the restored aliases similar to how you can currently rename the restored indexes.
Related Issues
Resolves #15632
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.