Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new rename_alias parameters for restore-snapshot #8544

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Add new rename_alias parameters for restore-snapshot #8544

merged 5 commits into from
Oct 29, 2024

Conversation

mispencer
Copy link
Contributor

@mispencer mispencer commented Oct 16, 2024 •
edited
Loading

Description

Documents new parameters for restore-snapshot to be introduced in OpenSearch PR 16292.

Issues Resolved

No issue

Version

2.18

Frontend features

None

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@mispencer mispencer mentioned this pull request Oct 16, 2024
Merged
3 tasks
@mispencer
Copy link
Contributor Author

The implementing PR for this change is not yet merged.

@mispencer mispencer marked this pull request as draft October 16, 2024 16:40
@Naarcha-AWS
Copy link
Collaborator

@mispencer: Is this update going into 2.18?

@mispencer
Copy link
Contributor Author

That depends on the reviewers of the main OpenSearch project, but I assume this will be in the next minor release, yes.

@Naarcha-AWS Naarcha-AWS added v2.18.0 2 - In progress Issue/PR: The issue or PR is in progress. labels Oct 16, 2024
@mispencer mispencer marked this pull request as ready for review October 24, 2024 18:26
@mispencer
Copy link
Contributor Author

This feature has been merged.

@Naarcha-AWS Naarcha-AWS added 4 - Doc review PR: Doc review in progress release-notes PR: Include this PR in the automated release notes and removed 2 - In progress Issue/PR: The issue or PR is in progress. labels Oct 28, 2024
@mispencer
Copy link
Contributor Author

@Naarcha-AWS - I created the documentation of the new rename_alias_pattern and rename_alias_replacement parameters by copying and modifying the existing documentation of the rename_pattern and rename_replacement parameters. As such, many of your suggestions would also apply to that existing documentation. Do you want me to update the existing documentation with your suggestions as well?

@Naarcha-AWS
Copy link
Collaborator

@mispencer: That would be great!

@mispencer
Add new rename_alias parameters for restore-snapshot
0f09165 
Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com>
@mispencer
Updating per review
23ca7a6 
Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com>
@mispencer mispencer force-pushed the AliasRenameSnapshotRestore branch from d900e0c to 23ca7a6 Compare October 29, 2024 14:12
@Naarcha-AWS
Copy link
Collaborator

Thanks @mispencer!

@Naarcha-AWS Naarcha-AWS added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels Oct 29, 2024
@Naarcha-AWS
Copy link
Collaborator

@natebower: This is ready for your review.

@natebower
Copy link
Collaborator

@natebower: This is ready for your review.

@Naarcha-AWS Can you please resolve the Vale comments? Thanks!

@Naarcha-AWS
Apply suggestions from code review
3f6867c 
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
@Naarcha-AWS
Copy link
Collaborator

@natebower: Vale errors addressed.

natebower
natebower reviewed Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naarcha-AWS @mispencer Please see my comments and changes and let me know if you have any questions. Thanks!

_api-reference/snapshots/restore-snapshot.md Outdated Show resolved Hide resolved
_api-reference/snapshots/restore-snapshot.md Outdated Show resolved Hide resolved
_tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md Outdated Show resolved Hide resolved
_tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md Outdated Show resolved Hide resolved
_tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md Outdated Show resolved Hide resolved
_tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md Show resolved Hide resolved
_tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md Outdated Show resolved Hide resolved
_tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md Outdated Show resolved Hide resolved
_tuning-your-cluster/availability-and-recovery/snapshots/snapshot-restore.md Show resolved Hide resolved
Naarcha-AWS and others added 2 commits October 29, 2024 14:02
@Naarcha-AWS @natebower
Apply suggestions from code review
7ec3a47 
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
@Naarcha-AWS
Merge branch 'main' into AliasRenameSnapshotRestore
1992326
@Naarcha-AWS Naarcha-AWS merged commit 644ea06 into opensearch-project:main Oct 29, 2024
5 checks passed
@mispencer mispencer deleted the AliasRenameSnapshotRestore branch October 29, 2024 20:47
epugh pushed a commit to o19s/documentation-website that referenced this pull request Nov 23, 2024
@mispencer @Naarcha-AWS
@natebower @epugh
Add new rename_alias parameters for restore-snapshot (opensearch-proj…
d03c4bb 
…ect#8544)

* Add new rename_alias parameters for restore-snapshot

Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com>

* Updating per review

Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com>

* Apply suggestions from code review

Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>

---------

Signed-off-by: Spencer G. Jones <spencer.jones2@tylertech.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Eric Pugh <epugh@opensourceconnections.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebower natebower natebower left review comments

@Naarcha-AWS Naarcha-AWS Naarcha-AWS approved these changes

@kolchfa-aws kolchfa-aws Awaiting requested review from kolchfa-aws kolchfa-aws is a code owner

@vagimeli vagimeli Awaiting requested review from vagimeli

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@dlvenable dlvenable Awaiting requested review from dlvenable dlvenable is a code owner

@epugh epugh Awaiting requested review from epugh epugh is a code owner

Assignees

@Naarcha-AWS Naarcha-AWS

Labels
5 - Editorial review PR: Editorial review in progress release-notes PR: Include this PR in the automated release notes v2.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mispencer @Naarcha-AWS @natebower @kolchfa-aws