Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create publication repos during join task execution #16383

Merged
merged 3 commits into from
Oct 28, 2024
Merged

create publication repos during join task execution #16383

merged 3 commits into from
Oct 28, 2024

Conversation

rajiv-kv
Copy link
Contributor

@rajiv-kv rajiv-kv commented Oct 18, 2024 •
edited
Loading

Description

When a node with publication repositories are configured, cluster-manager updates the repositories metadata in cluster-state after validation.

Related Issues

Resolves #16363

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for f54d4f3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@rajiv-kv rajiv-kv force-pushed the create_publication_repo_join branch from f54d4f3 to 7a56884 Compare October 18, 2024 17:32
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 7a56884: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 18, 2024
Open
@rajiv-kv rajiv-kv force-pushed the create_publication_repo_join branch from 7a56884 to c23f86e Compare October 19, 2024 06:07
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for c23f86e: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Oct 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.99%. Comparing base (6f1b59e) to head (2396141).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...earch/node/remotestore/RemoteStoreNodeService.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #16383      +/-   ##
============================================
- Coverage     72.02%   71.99%   -0.04%     
- Complexity    65000    65026      +26     
============================================
  Files          5313     5313              
  Lines        303397   303413      +16     
  Branches      43902    43906       +4     
============================================
- Hits         218528   218439      -89     
- Misses        66982    67084     +102     
- Partials      17887    17890       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rajiv-kv rajiv-kv marked this pull request as ready for review October 19, 2024 10:03
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 4ac77b1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@rajiv-kv rajiv-kv force-pushed the create_publication_repo_join branch from 4ac77b1 to 0d05c92 Compare October 21, 2024 10:24
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 0d05c92: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 18, 2024
Open
@rajiv-kv rajiv-kv force-pushed the create_publication_repo_join branch 2 times, most recently from dee33e8 to 75032b7 Compare October 21, 2024 19:35
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 75032b7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Oct 22, 2024
Closed
Open
@rajiv-kv rajiv-kv force-pushed the create_publication_repo_join branch from 7f2e2ee to 158d68c Compare October 28, 2024 05:20
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 158d68c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

rajiv-kv and others added 3 commits October 28, 2024 15:45
@rajiv-kv
create publication repos during join task
e90da5f 
Signed-off-by: Rajiv Kumar Vaidyanathan <rajivkv@amazon.com>
@rajiv-kv
fix the existing repo lookup
1498d6d 
Signed-off-by: Rajiv Kumar Vaidyanathan <rajivkv@amazon.com>
@shwetathareja @rajiv-kv
Update JoinTaskExecutor.java, minor update
2396141 
Signed-off-by: shwetathareja <shwetathareja@live.com>
Signed-off-by: Rajiv Kumar Vaidyanathan <rajivkv@amazon.com>
@rajiv-kv rajiv-kv force-pushed the create_publication_repo_join branch from 158d68c to 2396141 Compare October 28, 2024 10:16
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 2396141: SUCCESS

@shwetathareja shwetathareja merged commit 72559bf into opensearch-project:main Oct 28, 2024
38 checks passed
@shwetathareja shwetathareja added the backport 2.x Backport to 2.x branch label Oct 28, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 28, 2024
@github-actions
create publication repos during join task execution (#16383)
3507dd6 
* create publication repos during join task

Signed-off-by: Rajiv Kumar Vaidyanathan <rajivkv@amazon.com>
(cherry picked from commit 72559bf)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 28, 2024
Open
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Nov 15, 2024
Open
rajiv-kv added a commit to rajiv-kv/OpenSearch that referenced this pull request Nov 29, 2024
@rajiv-kv
create publication repos during join task execution (opensearch-proje…
6cdf771 
…ct#16383)

* create publication repos during join task

Signed-off-by: Rajiv Kumar Vaidyanathan <rajivkv@amazon.com>
@rajiv-kv rajiv-kv mentioned this pull request Nov 29, 2024
Merged
3 tasks
rajiv-kv added a commit to rajiv-kv/OpenSearch that referenced this pull request Dec 2, 2024
@rajiv-kv
create publication repos during join task execution (opensearch-proje…
a3c6f00 
…ct#16383)

* create publication repos during join task

Signed-off-by: Rajiv Kumar Vaidyanathan <rajivkv@amazon.com>
shwetathareja pushed a commit that referenced this pull request Dec 3, 2024
@rajiv-kv
create publication repos during join task execution (#16383) (#16741)
19b2e9a 
Signed-off-by: Rajiv Kumar Vaidyanathan <rajivkv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soosinha soosinha soosinha approved these changes

@shwetathareja shwetathareja shwetathareja approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajiv-kv @shwetathareja @soosinha