Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] create publication repos during join task execution #16499

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 72559bf from #16383.

* create publication repos during join task

Signed-off-by: Rajiv Kumar Vaidyanathan <rajivkv@amazon.com>
(cherry picked from commit 72559bf)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Gradle check result for 3507dd6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 3507dd6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dbwiddis
Copy link
Member

dbwiddis commented Nov 1, 2024

> Task :server:compileTestJava
/Users/runner/work/OpenSearch/OpenSearch/server/src/test/java/org/opensearch/cluster/coordination/JoinTaskExecutorTests.java:1053: error: constructor JoinTaskExecutor in class JoinTaskExecutor cannot be applied to given types;

        final JoinTaskExecutor joinTaskExecutor = new JoinTaskExecutor(
                                                  ^
  required: Settings,AllocationService,Logger,RerouteService,TransportService,RemoteStoreNodeService
  found:    Settings,AllocationService,Logger,RerouteService,RemoteStoreNodeService
  reason: actual and formal argument lists differ in length
/Users/runner/work/OpenSearch/OpenSearch/server/src/test/java/org/opensearch/cluster/coordination/JoinTaskExecutorTests.java:1124: error: constructor JoinTaskExecutor in class JoinTaskExecutor cannot be applied to given types;
        final JoinTaskExecutor joinTaskExecutor = new JoinTaskExecutor(
                                                  ^
  required: Settings,AllocationService,Logger,RerouteService,TransportService,RemoteStoreNodeService
  found:    Settings,AllocationService,Logger,RerouteService,RemoteStoreNodeService
  reason: actual and formal argument lists differ in length
/Users/runner/work/OpenSearch/OpenSearch/server/src/test/java/org/opensearch/cluster/coordination/JoinTaskExecutorTests.java:1191: error: constructor JoinTaskExecutor in class JoinTaskExecutor cannot be applied to given types;
        final JoinTaskExecutor joinTaskExecutor = new JoinTaskExecutor(
                                                  ^
  required: Settings,AllocationService,Logger,RerouteService,TransportService,RemoteStoreNodeService
  found:    Settings,AllocationService,Logger,RerouteService,RemoteStoreNodeService
  reason: actual and formal argument lists differ in length

@dbwiddis
Copy link
Member

dbwiddis commented Nov 1, 2024

@rajiv-kv Looks like 2.x has an additional TransportService argument in the JoinTaskExecutor constructor. Can you please investigate what changes are needed to make the tests compile?

@rajiv-kv
Copy link
Contributor

rajiv-kv commented Nov 1, 2024

@rajiv-kv Looks like 2.x has an additional TransportService argument in the JoinTaskExecutor constructor. Can you please investigate what changes are needed to make the tests compile?

Ack. I was planning to raise a new PR for backport.

@sandeshkr419
Copy link
Contributor

@rajiv-kv Were you able to raise the manual backport? (Changes will be missed in 2.x otherwise)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants