Rare terms aggregation precomputation #18978
Conversation
Signed-off-by: Anthony Leong <aj.leong623@gmail.com>
ajleong623
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
|
❌ Gradle check result for 630da67: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anthony Leong <aj.leong623@gmail.com>
|
❌ Gradle check result for ab1e010: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anthony Leong <aj.leong623@gmail.com>
Signed-off-by: Anthony Leong <aj.leong623@gmail.com>
asimmahmood1
left a comment
asimmahmood1
left a comment
There was a problem hiding this comment.
LGTM.
Learned about bucketOrds.add(ord, bytes) logic as well (line 113).
Signed-off-by: Anthony Leong <aj.leong623@gmail.com>
Signed-off-by: Anthony Leong <aj.leong623@gmail.com>
|
❌ Gradle check result for 09140dc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
...src/main/java/org/opensearch/search/aggregations/bucket/terms/StringRareTermsAggregator.java
Show resolved
Hide resolved
...src/main/java/org/opensearch/search/aggregations/bucket/terms/StringRareTermsAggregator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Anthony Leong <aj.leong623@gmail.com>
…b.com/ajleong623/OpenSearch into aggregation-precomputation-rare-terms
Signed-off-by: Anthony Leong <aj.leong623@gmail.com>
|
❕ Gradle check result for 9705456: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
|
@msfroh I notice that you made a couple of suggestions and comments last week, and I think I was able to address them. Let me know your thoughts on how I addressed those comments. |
github-project-automation
bot
moved this from In-Review
to In Progress
in Performance Roadmap
Signed-off-by: Anthony Leong <aj.leong623@gmail.com>
github-project-automation
bot
moved this from In Progress
to Done
in Performance Roadmap
|
Happy to see this change going in 3.3 :D |
--------- Signed-off-by: Anthony Leong <aj.leong623@gmail.com>
--------- Signed-off-by: Anthony Leong <aj.leong623@gmail.com>
5 participants
Description
This is the pull request for using aggregation precomputation on rare terms. This is part of pull request #18927.
Related Issues
Resolves #13122 #10954
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.