Skip to content

Conversation

@lucy66hw
Copy link
Contributor

@lucy66hw lucy66hw commented Nov 4, 2025

Description

Implement GRPC FunctionScoreQuery

Related Issues

part of #19526

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

❌ Gradle check result for 815c3c2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@lucy66hw lucy66hw closed this Nov 5, 2025
@lucy66hw lucy66hw reopened this Nov 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

❌ Gradle check result for 815c3c2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

✅ Gradle check result for acc9dcd: SUCCESS

@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 85.97786% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.28%. Comparing base (332efe3) to head (f979552).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...tionscore/FunctionScoreQueryBuilderProtoUtils.java 84.94% 5 Missing and 9 partials ⚠️
...ry/functionscore/GaussDecayFunctionProtoUtils.java 83.72% 0 Missing and 7 partials ⚠️
...y/functionscore/LinearDecayFunctionProtoUtils.java 83.72% 0 Missing and 7 partials ⚠️
...uery/functionscore/ExpDecayFunctionProtoUtils.java 86.04% 0 Missing and 6 partials ⚠️
...ctionscore/FieldValueFactorFunctionProtoUtils.java 86.95% 2 Missing and 1 partial ⚠️
...y/functionscore/RandomScoreFunctionProtoUtils.java 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19888      +/-   ##
============================================
+ Coverage     73.21%   73.28%   +0.07%     
- Complexity    71416    71561     +145     
============================================
  Files          5779     5787       +8     
  Lines        326332   326603     +271     
  Branches      47227    47290      +63     
============================================
+ Hits         238918   239346     +428     
+ Misses        68189    68018     -171     
- Partials      19225    19239      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lucy66hw lucy66hw force-pushed the 0.23.0-functionscore branch from acc9dcd to 7356c1e Compare November 5, 2025 16:54
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

✅ Gradle check result for 7356c1e: SUCCESS

@lucy66hw lucy66hw marked this pull request as ready for review November 5, 2025 18:26
@lucy66hw lucy66hw requested a review from a team as a code owner November 5, 2025 18:26
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

✅ Gradle check result for ae1d6ba: SUCCESS

lucy66hw and others added 6 commits November 6, 2025 07:13
Signed-off-by: xil <fridalu66@gmail.com>
Signed-off-by: xil <fridalu66@gmail.com>
Signed-off-by: xil <fridalu66@gmail.com>
Signed-off-by: xil <xil@uber.com>
Signed-off-by: xil <xil@uber.com>
Signed-off-by: xil <fridalu66@gmail.com>
@lucy66hw lucy66hw force-pushed the 0.23.0-functionscore branch from ae1d6ba to 149ec4b Compare November 6, 2025 07:13
Signed-off-by: xil <fridalu66@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

❌ Gradle check result for 149ec4b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: xil <fridalu66@gmail.com>
Signed-off-by: xil <fridalu66@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

❌ Gradle check result for 7fc8f8d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@lucy66hw lucy66hw closed this Nov 6, 2025
@lucy66hw lucy66hw reopened this Nov 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

✅ Gradle check result for 7fc8f8d: SUCCESS

Signed-off-by: xil <fridalu66@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

✅ Gradle check result for f242543: SUCCESS

Signed-off-by: xil <fridalu66@gmail.com>
Signed-off-by: xil <fridalu66@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

❌ Gradle check result for 499060b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@lucy66hw lucy66hw closed this Nov 7, 2025
@lucy66hw lucy66hw reopened this Nov 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

✅ Gradle check result for 499060b: SUCCESS

Signed-off-by: Karen X <karenxyr@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

✅ Gradle check result for f979552: SUCCESS

@karenyrx karenyrx merged commit 921dc23 into opensearch-project:main Nov 7, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants