Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 3.0.0 #2556

Merged
merged 14 commits into from
Apr 4, 2022
Merged

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Mar 22, 2022

Bumps main version from 2.0.0 to 3.0.0 after cutting 2.x and 2.0 branches. Some termporary versioning scaffolding is needed for now. This will be cleaned up in a follow up PR.

@nknize nknize added non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues >upgrade Label used when upgrading library dependencies (e.g., Lucene) v3.0.0 Issues and PRs related to version 3.0.0 labels Mar 22, 2022
@nknize nknize requested a review from a team as a code owner March 22, 2022 05:34
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure a463956f1030e145d1f54bfd8dc0ec1964991878
Log 3657

Reports 3657

@nknize nknize marked this pull request as draft March 22, 2022 05:45
@nknize nknize added the WIP Work in progress label Mar 22, 2022
@nknize
Copy link
Collaborator Author

nknize commented Mar 22, 2022

Some cleanup is still needed in the version scaffolding

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 8dc0e66f0c0d10621d58378aef007ac8bd21d698
Log 3666

Reports 3666

@nknize
Copy link
Collaborator Author

nknize commented Mar 22, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 8dc0e66f0c0d10621d58378aef007ac8bd21d698
Log 3667

Reports 3667

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 6579c6567417067b844e3a9f364ef09738def61c
Log 3670

Reports 3670

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure f77e8eeb062fa4215079e648de596e2c100c5a2e
Log 3673

Reports 3673

@nknize nknize force-pushed the versionBump/3.0 branch 2 times, most recently from 4b7855c to 5b58575 Compare March 28, 2022 17:50
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 4b7855c96462bf5d764b0f34873d27c9a3180a01
Log 3809

Reports 3809

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 5b585755ca10027515fa2fe2c16d210167f2eb59
Log 3817

Reports 3817

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 333c12dabfc5498cf95bf4fa7eefa70bfc900dae
Log 3830

Reports 3830

@dblock
Copy link
Member

dblock commented Mar 29, 2022

We had some confusion on where 2.0 is coming from (it should be 2.x branch), let's get this one in?

@nknize nknize marked this pull request as ready for review March 31, 2022 21:13
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 55450ced2dc8897d177a4039e1a615bc21f38be3
Log 3988

Reports 3988

@tlfeng
Copy link
Collaborator

tlfeng commented Apr 1, 2022

In log 3988:

REPRODUCE WITH: ./gradlew ':distribution:tools:plugin-cli:test' --tests "org.opensearch.plugins.RemovePluginCommandTests.testRemoveOldVersion" -Dtests.seed=63141A04D4E4F2B3 -Dtests.security.manager=false -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=es-EC -Dtests.timezone=Pacific/Marquesas -Druntime.java=17

org.opensearch.plugins.RemovePluginCommandTests > testRemoveOldVersion FAILED
    java.lang.IllegalArgumentException: maxVersion [1.3.1] cannot be less than minVersion [2.0.0]
        at __randomizedtesting.SeedInfo.seed([63141A04D4E4F2B3:6868F792A67F961E]:0)
        at org.opensearch.test.VersionUtils.randomVersionBetween(VersionUtils.java:324)
        at org.opensearch.plugins.RemovePluginCommandTests.testRemoveOldVersion(RemovePluginCommandTests.java:173)
REPRODUCE WITH: ./gradlew ':test:framework:test' --tests "org.opensearch.test.rest.yaml.section.SkipSectionTests.testSkipMultiRange" -Dtests.seed=63141A04D4E4F2B3 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=lt -Dtests.timezone=America/Guyana -Druntime.java=17

org.opensearch.test.rest.yaml.section.SkipSectionTests > testSkipMultiRange FAILED
    java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([63141A04D4E4F2B3:79A142FD42A589AB]:0)
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at org.opensearch.test.rest.yaml.section.SkipSectionTests.testSkipMultiRange(SkipSectionTests.java:64)

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 87e3ad6ddcbb5cd57fbf35e4c9b8ce668aa04d57
Log 4009

Reports 4009

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 9cf03afab74bcf85fc0883325d19ab839d4c6722
Log 4014

Reports 4014

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure b234df5fc55203b816133e93447f1e8a4949e87d
Log 4015

Reports 4015

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure b234df5fc55203b816133e93447f1e8a4949e87d
Log 4019

Reports 4019

@tlfeng
Copy link
Collaborator

tlfeng commented Apr 1, 2022

In log 4019:

REPRODUCE WITH: ./gradlew ':server:test' --tests "org.opensearch.cluster.coordination.JoinTaskExecutorTests.testPreventJoinClusterWithUnsupportedNodeVersions" -Dtests.seed=E91B43DAF672B0E7 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=it-IT -Dtests.timezone=America/Barbados -Druntime.java=17

org.opensearch.cluster.coordination.JoinTaskExecutorTests > testPreventJoinClusterWithUnsupportedNodeVersions FAILED
    junit.framework.AssertionFailedError: Expected exception IllegalStateException but no exception was thrown
        at __randomizedtesting.SeedInfo.seed([E91B43DAF672B0E7:6A64E4A024B120AB]:0)
        at org.apache.lucene.tests.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2898)
        at org.apache.lucene.tests.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2884)
        at org.opensearch.cluster.coordination.JoinTaskExecutorTests.testPreventJoinClusterWithUnsupportedNodeVersions(JoinTaskExecutorTests.java:119)

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 96c69748fdd7cc5ae2c9cd75895d85f3068d8f4f
Log 4039

Reports 4039

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure bed8fe8887916edf9184fade3399180188b2beaf
Log 4094

Reports 4094

@nknize nknize force-pushed the versionBump/3.0 branch from bed8fe8 to 5f730ab Compare April 4, 2022 02:38
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 5f730ab5e97a7cfe7988977f5fc76170309e8c86
Log 4097

Reports 4097

@nknize
Copy link
Collaborator Author

nknize commented Apr 4, 2022

This is blocked until #2722 is merged and backported to 2.x and 2.0 branches.

See failure:

» WARN ][o.o.c.c.JoinHelper       ] [v2.1.0-0] last failed join attempt was 749ms ago, failed to join {v2.1.0-2}{tF0gn1KRTXiDyL3QaiZd3w}{3m_3VtzOTjung38rji5Hew}{127.0.0.1}{127.0.0.1:39911}{dimr}{testattr=test, shard_indexing_pressure_enabled=true} with JoinRequest{sourceNode={v2.1.0-0}{JOUu8X0cSU6fIIPyBpsSqA}{tERcNWxcQqeaPYPs2cpynQ}{127.0.0.1}{127.0.0.1:33229}{dimr}{upgraded=true, testattr=test, shard_indexing_pressure_enabled=true}, minimumTerm=6, optionalJoin=Optional.empty}
»  org.opensearch.transport.RemoteTransportException: [v2.1.0-2][127.0.0.1:39911][internal:cluster/coordination/join]
»  Caused by: org.opensearch.transport.ConnectTransportException: [v2.1.0-0][127.0.0.1:33229] general node connection failure
..
..
..
»  Caused by: java.lang.IllegalStateException: Received message from unsupported version: [3.0.0] minimal compatible version is: [7.10.0]

#2722 will stage 2.0+ clusters to only spoof major versions when running in mixed mode w/ legacy 7.x nodes.

nknize added 14 commits April 4, 2022 16:46
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize force-pushed the versionBump/3.0 branch from 5f730ab to 4f049d8 Compare April 4, 2022 22:03
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 4f049d8
Log 4157

Reports 4157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues >upgrade Label used when upgrading library dependencies (e.g., Lucene) v3.0.0 Issues and PRs related to version 3.0.0 WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants