[Version] Don't spoof major for 3.0+ clusters #2722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nknize
added
non-issue
|
❌ Gradle Check failure 4f0ec4e4a0f4d181fe9f2c629a5cfd17dda15c38 |
|
❌ Gradle Check failure d1b10ff4780c25df94cde9c1c58c7928dfe2135b |
|
Logic for supporting legacy versions remain; for now. Will remove in a follow up PR |
|
❌ Gradle Check failure 1ec64b7e14c88c6fb72e590fa50f2963352ab278 |
|
#1703 repeat... refiring |
|
start gradle check |
nknize
force-pushed
the
versionBump/prep3.0
branch
from
10e709b to
5e94cd4
Compare
|
✅ Gradle Check success 1ec64b7e14c88c6fb72e590fa50f2963352ab278 |
|
✅ Gradle Check success 10e709bd72101e95545227d7461dbd08a6fca50f |
|
✅ Gradle Check success 5e94cd4efdfb580943a1dba663cbe0b1e1a99f0a |
|
✅ Gradle Check success 2cbc329ba813e989a52b06589da3407b93bfbebe |
|
✅ Gradle Check success cbd6e0dde3c65313a60ad5523c2b43ee9928d36a |
nknize
changed the title
Merged
|
✅ Gradle Check success 06d9b4037b354a2f2068a93b46f9262d527f3d90 |
This adds initial testing to prep 3.0 for removal of legacy support Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
….x and 2.x Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
nknize
force-pushed
the
versionBump/prep3.0
branch
from
06d9b40 to
6e9bc40
Compare
mch2
approved these changes
Apr 4, 2022
| // all major versions from 3 onwards are compatible with last minor series of the previous major | ||
| // todo: remove 5 check when removing LegacyESVersionTests |
There was a problem hiding this comment.
should we cut an issue for this removal in 3.x?
nknize
added
backport 2.x
nknize
added a commit
that referenced
this pull request
Apr 4, 2022
Changes version comparison logic to only translate major version when comparing with legacy 7x versions. This is needed beginning in 2.0 so that when running 2.0+ versions in bwc mode for 3.0+ upgrades, node versions no longer have to translate major version or spoof to legacy versions. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> (cherry picked from commit 2d716ad)
nknize
added a commit
that referenced
this pull request
Apr 4, 2022
Changes version comparison logic to only translate major version when comparing with legacy 7x versions. This is needed beginning in 2.0 so that when running 2.0+ versions in bwc mode for 3.0+ upgrades, node versions no longer have to translate major version or spoof to legacy versions. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> (cherry picked from commit 2d716ad)
5 tasks
nknize
pushed a commit
that referenced
this pull request
Apr 4, 2022
Changes version comparison logic to only translate major version when comparing with legacy 7x versions. This is needed beginning in 2.0 so that when running 2.0+ versions in bwc mode for 3.0+ upgrades, node versions no longer have to translate major version or spoof to legacy versions. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> (cherry picked from commit 2d716ad)
nknize
pushed a commit
that referenced
this pull request
Apr 4, 2022
Changes version comparison logic to only translate major version when comparing with legacy 7x versions. This is needed beginning in 2.0 so that when running 2.0+ versions in bwc mode for 3.0+ upgrades, node versions no longer have to translate major version or spoof to legacy versions. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> (cherry picked from commit 2d716ad)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes version comparison logic to only translate major version when comparing with legacy 7x versions.
This is needed beginning in 2.0 so that when running 2.0+ versions in bwc mode for 3.0+ upgrades, node
versions no longer have to translate major version or spoof to legacy versions.