-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] core.common to new opensearch-common library #5976
Conversation
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
@nknize I am a bit lost now, I thought that #5902 concluded we don't want/need to have
Is the On a slightly different subject, it seems like the convention for other modules in OpenSearch is to use |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #5976 +/- ##
=========================================
Coverage 70.89% 70.90%
+ Complexity 58839 58816 -23
=========================================
Files 4775 4775
Lines 280993 280993
Branches 40590 40590
=========================================
+ Hits 199224 199230 +6
+ Misses 65436 65383 -53
- Partials 16333 16380 +47
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
buildSrc/src/main/java/org/opensearch/gradle/precommit/JarHellPrecommitPlugin.java
Show resolved
Hide resolved
/** | ||
* Java 9 Map | ||
* | ||
* todo: deprecate and remove w/ min jdk upgrade to 11? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we do that since 3.0.0 has JDK-11 baseline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I was planning it in a follow up PR.
Refactors all of o.opensearch.common classes in the core library to a new opensearch-commons library (inspired by apache commons). The intent is to refactor any o.opensearch.common.* classes in :server module to this new library. This will be done with care such that the dependencies are carefully managed to avoid any cyclic or unnecessarily complicated dependencies. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Gradle Check (Jenkins) Run Completed with:
|
* | ||
* todo: deprecate and remove w/ min jdk upgrade to 11? | ||
* | ||
* @opensearch.internal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nitpick, but I think this is a bit of an abuse of the @opensearch.internal
annotation. This was clearly meant to be a public utility just like anything else in the common namespace. It just has been superseded by an alternative, which is exactly what the java.lang.Deprecated
annotation is meant to convey.
Gradle Check (Jenkins) Run Completed with:
|
Refactors all of o.opensearch.common classes in the core library to a new opensearch-commons library (inspired by apache commons). The intent is to refactor any o.opensearch.common.* classes in :server module to this new library. This will be done with care such that the dependencies are carefully managed to avoid any cyclic or unnecessarily complicated dependencies. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> (cherry picked from commit c557f27) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Refactors all of o.opensearch.common classes in the core library to a new opensearch-commons library (inspired by apache commons). The intent is to refactor any o.opensearch.common.* classes in :server module to this new library. This will be done with care such that the dependencies are carefully managed to avoid any cyclic or unnecessarily complicated dependencies.
relates #5910