Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Refactor] core.common to new opensearch-common library #6111

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport c557f27 from #5976.

Refactors all of o.opensearch.common classes in the core library to a new
opensearch-commons library (inspired by apache commons). The intent is to
refactor any o.opensearch.common.* classes in :server module to this new
library. This will be done with care such that the dependencies are carefully
managed to avoid any cyclic or unnecessarily complicated dependencies.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
(cherry picked from commit c557f27)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@andrross
Copy link
Member

> Task :qa:evil-tests:compileTestJava
/var/jenkins/workspace/gradle-check/search/qa/evil-tests/src/test/java/org/opensearch/common/logging/EvilLoggerTests.java:301: error: cannot find symbol
        if (Constants.WINDOWS) {
            ^
  symbol:   variable Constants
  location: class EvilLoggerTests
/var/jenkins/workspace/gradle-check/search/qa/evil-tests/src/test/java/org/opensearch/common/logging/EvilLoggerTests.java:302: error: cannot find symbol
            assertThat(events.get(1), endsWith("no_node_name\\log4j2.properties"));
                                      ^
  symbol:   method endsWith(String)
  location: class EvilLoggerTests
/var/jenkins/workspace/gradle-check/search/qa/evil-tests/src/test/java/org/opensearch/common/logging/EvilLoggerTests.java:304: error: cannot find symbol
            assertThat(events.get(1), endsWith("no_node_name/log4j2.properties"));
                                      ^
  symbol:   method endsWith(String)
  location: class EvilLoggerTests

@andrross
Copy link
Member

I'm working on fixing the compiler errors

Signed-off-by: Andrew Ross <andrross@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@nknize nknize merged commit b2ddd9b into 2.x Jan 31, 2023
@github-actions github-actions bot deleted the backport/backport-5976-to-2.x branch January 31, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants