-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Version and LegacyESVersion from server module to core lib #7328
Conversation
Refactors the Version and LegacyESVersion classes from the server module to the core library. All gradle build scripts and dependencies are updated. This commit serves as a foundation for refactoring all OpenSearch base classes from the server module into appropriate libraries to decouple core search logic from the cluster model so it can be reused in serverless and cloud native environments. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #7328 +/- ##
============================================
- Coverage 70.71% 70.61% -0.10%
+ Complexity 59497 59421 -76
============================================
Files 4859 4859
Lines 285339 285340 +1
Branches 41133 41133
============================================
- Hits 201772 201489 -283
- Misses 66965 67242 +277
- Partials 16602 16609 +7
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7328-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 142ae4611042669c9511a81a014828ca22376afc
# Push it to GitHub
git push --set-upstream origin backport/backport-7328-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
I don't know, @nknize? |
@nknize This refactoring looks to have broken the check here https://github.com/opensearch-project/OpenSearch/blob/main/libs/core/src/main/java/org/opensearch/Build.java#L112-L149 as it's based on the code source location of the |
…search-{version}.jar`. Fixes breakage introduced in opensearch-project#7328, causing `GET /` to return "unknown" for build hash and date.
…search-{version}.jar`. Fixes breakage introduced in opensearch-project#7328, causing `GET /` to return "unknown" for build hash and date. Signed-off-by: Thomas Farr <tsfarr@amazon.com>
…search-{version}.jar`. Fixes breakage introduced in opensearch-project#7328, causing `GET /` to return "unknown" for build hash and date. Signed-off-by: Thomas Farr <tsfarr@amazon.com>
…search-{version}.jar`. Fixes breakage introduced in opensearch-project#7328, causing `GET /` to return "unknown" for build hash and date. Signed-off-by: Thomas Farr <tsfarr@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7328-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 142ae4611042669c9511a81a014828ca22376afc
# Push it to GitHub
git push --set-upstream origin backport/backport-7328-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
…opensearch-project#7328) Refactors the Version and LegacyESVersion classes from the server module to the core library. All gradle build scripts and dependencies are updated. This commit serves as a foundation for refactoring all OpenSearch base classes from the server module into appropriate libraries to decouple core search logic from the cluster model so it can be reused in serverless and cloud native environments. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
…opensearch-project#7328) Refactors the Version and LegacyESVersion classes from the server module to the core library. All gradle build scripts and dependencies are updated. This commit serves as a foundation for refactoring all OpenSearch base classes from the server module into appropriate libraries to decouple core search logic from the cluster model so it can be reused in serverless and cloud native environments. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
…#7328) (#8382) Refactors the Version and LegacyESVersion classes from the server module to the core library. All gradle build scripts and dependencies are updated. This commit serves as a foundation for refactoring all OpenSearch base classes from the server module into appropriate libraries to decouple core search logic from the cluster model so it can be reused in serverless and cloud native environments. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
…opensearch-project#7328) * [Refactor] Version and LegacyESVersion to core lib Refactors the Version and LegacyESVersion classes from the server module to the core library. All gradle build scripts and dependencies are updated. This commit serves as a foundation for refactoring all OpenSearch base classes from the server module into appropriate libraries to decouple core search logic from the cluster model so it can be reused in serverless and cloud native environments. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> * fix javadoc Signed-off-by: Nicholas Walter Knize <nknize@apache.org> --------- Signed-off-by: Nicholas Walter Knize <nknize@apache.org> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Refactors the
Version
andLegacyESVersion
classes from the server module to the core library. All gradle build scripts and dependencies are updated. This commit serves as a foundation for refactoring all OpenSearch base classes from the server module into appropriate libraries to decouple core search logic from the cluster model so it can be reused in serverless and cloud native environments.relates #5910