Updated Version.java path from server to libs in version.yml

[vibrantvarun]

Description

PR #7328 moved Version.java from :server to :libs:opensearch-core. This commit updates Version.java path in version.yml from server/src/main/java/org/opensearch/Version.java to libs/core/src/main/java/org/opensearch/Version.java

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[kotwanikunal]

@vibrantvarun Can you please describe what you are trying to achieve in the description section of the PR?

[prudhvigodithi]

Thanks @vibrantvarun I assume the sed logic still works with the file buildSrc/src/main/java/org/opensearch/gradle/Version.java.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      2 org.opensearch.search.suggest.CompletionSuggestSearchIT.testSkipDuplicates
      1 org.opensearch.index.IndexServiceTests.testAsyncTranslogTrimTaskOnClosedIndex
      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

• URL: https://build.ci.opensearch.org/job/gradle-check/20940/
• CommitID: 4a8ebc5
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.indices.replication.SegmentReplicationTargetServiceTests.testShardAlreadyReplicating
      1 org.opensearch.indices.replication.SegmentReplicationIT.testScrollCreatedOnReplica
      1 org.opensearch.indices.replication.SegmentReplicationIT.classMethod
      1 org.opensearch.index.ShardIndexingPressureIT.testShardIndexingPressureTrackingDuringBulkWrites

• URL: https://build.ci.opensearch.org/job/gradle-check/20944/
• CommitID: 02c0292
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[andrross]

Thanks @vibrantvarun I assume the sed logic still works with the file buildSrc/src/main/java/org/opensearch/gradle/Version.java.

@vibrantvarun Can you run the sed commands manually against the correct file and verify it still works? @kotwanikunal please chime in if there's a better way to test this.

[vibrantvarun]

@andrross sure, taking a look into it.

[owaiskazi19]

@vibrantvarun Can you please describe what you are trying to achieve in the description section of the PR?

Looks like these changes were missed here.

[kotwanikunal]

@vibrantvarun Can you please describe what you are trying to achieve in the description section of the PR?

Looks like these changes were missed here.

Thanks. I was looking for this context :)

[kotwanikunal]

Thanks @vibrantvarun I assume the sed logic still works with the file buildSrc/src/main/java/org/opensearch/gradle/Version.java.

@vibrantvarun Can you run the sed commands manually against the correct file and verify it still works? @kotwanikunal please chime in if there's a better way to test this.

That's the only way. @vibrantvarun You can test this by cloning OpenSearch and running this script from the root folder -
https://gist.github.com/kotwanikunal/91f33eeced50f6aa93701e91a2e93a6b

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.remotestore.RemoteStoreIT.testRemoteTranslogRestoreWithNoDataPostRefresh

• URL: https://build.ci.opensearch.org/job/gradle-check/20987/
• CommitID: 3ec99c7
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[vibrantvarun]

@kotwanikunal
The output of running above script on local

TAG=2.9.0
BASE=2.9
BASE_X=2.x
CURRENT_VERSION=2.9.0
CURRENT_VERSION_UNDERSCORE=V_2_9_0
NEXT_VERSION=2.9.1
NEXT_VERSION_UNDERSCORE=V_2_9_1
NEXT_VERSION_ID=2090199
Incrementing 2.9.0 to 2.9.1
version.sh: line 32: .ci/bwcVersions: No such file or directory
sed: 1: "buildSrc/version.proper ...": undefined label 'uildSrc/version.properties'
Adding V_2_9_1 after V_2_9_0

It works.

[kotwanikunal]

@kotwanikunal The output of running above script on local

TAG=2.9.0
BASE=2.9
BASE_X=2.x
CURRENT_VERSION=2.9.0
CURRENT_VERSION_UNDERSCORE=V_2_9_0
NEXT_VERSION=2.9.1
NEXT_VERSION_UNDERSCORE=V_2_9_1
NEXT_VERSION_ID=2090199
Incrementing 2.9.0 to 2.9.1
version.sh: line 32: .ci/bwcVersions: No such file or directory
sed: 1: "buildSrc/version.proper ...": undefined label 'uildSrc/version.properties'
Adding V_2_9_1 after V_2_9_0

It works.

I can see errors on the output. Did you test it against the OpenSearch repo cloned code base?

[vibrantvarun]

@kotwanikunal Okay I debugged the issue with the script. Actually in mac os the sed command looks like

sed -i -e "s/opensearch = $CURRENT_VERSION/opensearch = $NEXT_VERSION/g" buildSrc/version.properties

We have to add -e in the command

So after I added -e below is the output

TAG=2.9.0
BASE=2.9
BASE_X=2.x
CURRENT_VERSION=2.9.0
CURRENT_VERSION_UNDERSCORE=V_2_9_0
NEXT_VERSION=2.9.1
NEXT_VERSION_UNDERSCORE=V_2_9_1
NEXT_VERSION_ID=2090199
Incrementing 2.9.0 to 2.9.1
Adding V_2_9_1 after V_2_9_0

Thanks for pointing it out

[kotwanikunal]

@vibrantvarun Please resolve all conversations before we can merge this in.

[vibrantvarun]

@kotwanikunal resolved all conversations

[prudhvigodithi]

Hey @vibrantvarun this only runs when a new tag is cut which takes in the tag information https://github.com/opensearch-project/OpenSearch/blob/main/.github/workflows/version.yml#L24. So to re-produce one way is to delete and re-create tag which is no right thing to do now, please raise a manual PR for 2.9.1 similar to 2.8.1 and lets keep monitoring for the next patch version increment.
Thank you