-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Segment Replication] Add lucene codec tests #7903
Merged
dreamer-89
merged 4 commits into
opensearch-project:main
from
dreamer-89:codec-integ-test
Jun 7, 2023
Merged
[Segment Replication] Add lucene codec tests #7903
dreamer-89
merged 4 commits into
opensearch-project:main
from
dreamer-89:codec-integ-test
Jun 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamer-89
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
tlfeng,
VachaShah and
dbwiddis
as code owners
June 2, 2023 22:15
Gradle Check (Jenkins) Run Completed with:
|
The PR still blocked on usage of openStream() method call and fails due
Gradle failure
AlternativeI tried
|
This comment was marked as outdated.
This comment was marked as outdated.
Gradle Check (Jenkins) Run Completed with:
|
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #7903 +/- ##
============================================
+ Coverage 70.83% 70.84% +0.01%
+ Complexity 56340 56318 -22
============================================
Files 4701 4701
Lines 266595 266595
Branches 39101 39101
============================================
+ Hits 188834 188861 +27
+ Misses 61803 61710 -93
- Partials 15958 16024 +66 |
Poojita-Raj
suggested changes
Jun 6, 2023
...er/src/internalClusterTest/java/org/opensearch/indices/replication/SegmentReplicationIT.java
Outdated
Show resolved
Hide resolved
mch2
reviewed
Jun 6, 2023
...er/src/internalClusterTest/java/org/opensearch/indices/replication/SegmentReplicationIT.java
Outdated
Show resolved
Hide resolved
...er/src/internalClusterTest/java/org/opensearch/indices/replication/SegmentReplicationIT.java
Outdated
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Looks unrelated.
|
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Suraj Singh <surajrider@gmail.com>
dreamer-89
force-pushed
the
codec-integ-test
branch
from
June 7, 2023 19:08
f42e98f
to
6f33bd9
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
mch2
approved these changes
Jun 7, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 7, 2023
* Resolve forbidden APIs Signed-off-by: Suraj Singh <surajrider@gmail.com> * Address review comments Signed-off-by: Suraj Singh <surajrider@gmail.com> * Remove older lucene test Signed-off-by: Suraj Singh <surajrider@gmail.com> * Remove older lucene test Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com> (cherry picked from commit f25f61b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock
pushed a commit
that referenced
this pull request
Jun 7, 2023
* Resolve forbidden APIs * Address review comments * Remove older lucene test * Remove older lucene test --------- (cherry picked from commit f25f61b) Signed-off-by: Suraj Singh <surajrider@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock
pushed a commit
to dblock/OpenSearch
that referenced
this pull request
Jun 8, 2023
* Resolve forbidden APIs Signed-off-by: Suraj Singh <surajrider@gmail.com> * Address review comments Signed-off-by: Suraj Singh <surajrider@gmail.com> * Remove older lucene test Signed-off-by: Suraj Singh <surajrider@gmail.com> * Remove older lucene test Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com>
sandeshkr419
pushed a commit
to sandeshkr419/OpenSearch
that referenced
this pull request
Jun 8, 2023
* Resolve forbidden APIs Signed-off-by: Suraj Singh <surajrider@gmail.com> * Address review comments Signed-off-by: Suraj Singh <surajrider@gmail.com> * Remove older lucene test Signed-off-by: Suraj Singh <surajrider@gmail.com> * Remove older lucene test Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com>
6 tasks
gaiksaya
pushed a commit
to gaiksaya/OpenSearch
that referenced
this pull request
Jun 26, 2023
opensearch-project#7958) * Resolve forbidden APIs * Address review comments * Remove older lucene test * Remove older lucene test --------- (cherry picked from commit f25f61b) Signed-off-by: Suraj Singh <surajrider@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
* Resolve forbidden APIs Signed-off-by: Suraj Singh <surajrider@gmail.com> * Address review comments Signed-off-by: Suraj Singh <surajrider@gmail.com> * Remove older lucene test Signed-off-by: Suraj Singh <surajrider@gmail.com> * Remove older lucene test Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds integration tests for lucene codecs.
testWithOlderCodecs
. Validate that segment replication works with older lucene codecs. Verified with string matching checks, this test fails. Tested this on branch codec-string-matchtestWithDifferentCompressionModes
. Validates that segment replication works with different codec compression modes.Related Issues
Resolves #7781
#3881
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.