-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compression Levels Settings for zstd and zstd_no_dict #8312
Compression Levels Settings for zstd and zstd_no_dict #8312
Conversation
6bdf3f5
to
648200d
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
648200d
to
7a89c78
Compare
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8312 +/- ##
============================================
- Coverage 70.87% 70.86% -0.01%
- Complexity 56922 56946 +24
============================================
Files 4758 4758
Lines 269337 269225 -112
Branches 39409 39408 -1
============================================
- Hits 190886 190786 -100
+ Misses 62339 62326 -13
- Partials 16112 16113 +1
|
d76b56a
to
1f184b1
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
1f184b1
to
cc53b72
Compare
server/src/main/java/org/opensearch/index/codec/CodecService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/codec/customcodecs/Lucene95CustomCodec.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/opensearch/index/codec/CodecTests.java
Outdated
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
5a79539
to
fddebac
Compare
Gradle Check (Jenkins) Run Completed with:
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8312-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ca7045e8471c7394e502744703628c8d8adec445
# Push it to GitHub
git push --set-upstream origin backport/backport-8312-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
@sarthakaggarwal97 could you please make a manual backport to |
…ject#8312) * Enabling compression levels as index settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * addressing review comments Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * refactoring codec service Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * index settings assertion Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * default compression level change in the settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> --------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit ca7045e)
…ject#8312) * Enabling compression levels as index settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * addressing review comments Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * refactoring codec service Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * index settings assertion Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * default compression level change in the settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> --------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit ca7045e)
…ject#8312) * Enabling compression levels as index settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * addressing review comments Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * refactoring codec service Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * index settings assertion Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * default compression level change in the settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> --------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit ca7045e)
…nd ZSTD Codecs (#8558) * Compression Levels Settings for zstd and zstd_no_dict (#8312) * Enabling compression levels as index settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * addressing review comments Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * refactoring codec service Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * index settings assertion Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * default compression level change in the settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> --------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit ca7045e) * refactoring CodecService for 2.x Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> --------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
…ject#8312) * Enabling compression levels as index settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * addressing review comments Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * refactoring codec service Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * index settings assertion Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * default compression level change in the settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> --------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit ca7045e)
…ject#8312) * Enabling compression levels as index settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * addressing review comments Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * refactoring codec service Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * index settings assertion Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * default compression level change in the settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> --------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
…ject#8312) * Enabling compression levels as index settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * addressing review comments Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * refactoring codec service Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * index settings assertion Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * default compression level change in the settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> --------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
…ject#8312) * Enabling compression levels as index settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * addressing review comments Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * refactoring codec service Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * index settings assertion Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * default compression level change in the settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> --------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
…ject#8312) * Enabling compression levels as index settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * addressing review comments Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * refactoring codec service Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * index settings assertion Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * default compression level change in the settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> --------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
…ject#8312) * Enabling compression levels as index settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * addressing review comments Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * refactoring codec service Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * index settings assertion Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * default compression level change in the settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> --------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
…ject#8312) * Enabling compression levels as index settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * addressing review comments Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * refactoring codec service Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * index settings assertion Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * default compression level change in the settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> --------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
This PR enables the compression level settings for the
zstd
andzstd_no_dict
codecs. The prerequisite for this PR is #7908Related Issues
Resolves #7555
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.