Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] [2.x] Enabling Compression Level Index Settings for ZSTD and ZSTD Codecs #8558

Merged

Conversation

sarthakaggarwal97
Copy link
Contributor

@sarthakaggarwal97 sarthakaggarwal97 commented Jul 9, 2023

Description

Backport #8312

Related Issues

Resolves #7555

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sarthakaggarwal97 sarthakaggarwal97 force-pushed the backport/backport-8312-to-2.x branch from 0b15bf2 to 5559781 Compare July 9, 2023 09:00
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2023

Gradle Check (Jenkins) Run Completed with:

@sarthakaggarwal97 sarthakaggarwal97 force-pushed the backport/backport-8312-to-2.x branch from 5559781 to 2c8486f Compare July 9, 2023 09:13
@sarthakaggarwal97 sarthakaggarwal97 changed the title [Backport] Enabling Compression Level Index Settings for ZSTD and ZSTD Codecs [Backport] [2.x] Enabling Compression Level Index Settings for ZSTD and ZSTD Codecs Jul 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Merging #8558 (d829bda) into 2.x (aecf435) will increase coverage by 0.09%.
The diff coverage is 93.54%.

❗ Current head d829bda differs from pull request most recent head eb87477. Consider uploading reports for the commit eb87477 to get more accurate results

@@             Coverage Diff              @@
##                2.x    #8558      +/-   ##
============================================
+ Coverage     70.59%   70.68%   +0.09%     
- Complexity    57082    57105      +23     
============================================
  Files          4744     4744              
  Lines        270579   270606      +27     
  Branches      39939    39943       +4     
============================================
+ Hits         191003   191286     +283     
+ Misses        63139    62894     -245     
+ Partials      16437    16426      -11     
Impacted Files Coverage Δ
...pensearch/common/settings/IndexScopedSettings.java 100.00% <ø> (ø)
.../java/org/opensearch/index/codec/CodecService.java 95.65% <92.00%> (-4.35%) ⬇️
...customcodecs/Lucene95CustomStoredFieldsFormat.java 74.07% <100.00%> (+2.07%) ⬆️
...opensearch/index/codec/customcodecs/ZstdCodec.java 100.00% <100.00%> (ø)
...arch/index/codec/customcodecs/ZstdNoDictCodec.java 85.71% <100.00%> (-14.29%) ⬇️
...java/org/opensearch/index/engine/EngineConfig.java 98.51% <100.00%> (+0.01%) ⬆️
...in/java/org/opensearch/index/shard/IndexShard.java 69.53% <100.00%> (+0.54%) ⬆️

... and 495 files with indirect coverage changes

@sarthakaggarwal97 sarthakaggarwal97 force-pushed the backport/backport-8312-to-2.x branch from 2c8486f to 9cf569b Compare July 9, 2023 10:35
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testBasicTaskResourceTracking

@sarthakaggarwal97 sarthakaggarwal97 force-pushed the backport/backport-8312-to-2.x branch from 9cf569b to dbbc877 Compare July 9, 2023 12:00
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.ConcurrentSegmentSearchTimeoutIT.testSimpleTimeout

@sarthakaggarwal97 sarthakaggarwal97 force-pushed the backport/backport-8312-to-2.x branch from dbbc877 to 616419f Compare July 10, 2023 04:15
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@sarthakaggarwal97 sarthakaggarwal97 force-pushed the backport/backport-8312-to-2.x branch from 616419f to cf3e913 Compare July 10, 2023 07:20
…ject#8312)

* Enabling compression levels as index settings

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* addressing review comments

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* refactoring codec service

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* index settings assertion

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

* default compression level change in the settings

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>

---------

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
(cherry picked from commit ca7045e)
@sarthakaggarwal97 sarthakaggarwal97 force-pushed the backport/backport-8312-to-2.x branch from cf3e913 to d829bda Compare July 10, 2023 08:31
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testWriteBlobWithRetries
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDropPrimaryDuringReplication

@sarthakaggarwal97 sarthakaggarwal97 force-pushed the backport/backport-8312-to-2.x branch from d829bda to 6ff8abf Compare July 10, 2023 13:16
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@sarthakaggarwal97 sarthakaggarwal97 force-pushed the backport/backport-8312-to-2.x branch from 6ff8abf to eb87477 Compare July 10, 2023 13:38
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@sarthakaggarwal97 sarthakaggarwal97 force-pushed the backport/backport-8312-to-2.x branch from eb87477 to c573940 Compare July 10, 2023 13:57
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL: null
  • CommitID: c573940
    Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
    Is the failure a flaky test unrelated to your change?

@sarthakaggarwal97 sarthakaggarwal97 force-pushed the backport/backport-8312-to-2.x branch from c573940 to b7ae674 Compare July 10, 2023 14:00
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL: null
  • CommitID: b7ae674
    Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
    Is the failure a flaky test unrelated to your change?

Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
@sarthakaggarwal97 sarthakaggarwal97 force-pushed the backport/backport-8312-to-2.x branch from b7ae674 to 4bb4c09 Compare July 10, 2023 14:28
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.cluster.service.MasterServiceTests.classMethod
      1 org.opensearch.cluster.service.MasterServiceTests.testThrottlingForMultipleTaskTypes

@reta reta merged commit fc30d6c into opensearch-project:2.x Jul 10, 2023
@reta
Copy link
Collaborator

reta commented Jul 10, 2023

There are flaky tests out of this pull request: #8593, @sarthakaggarwal97 please take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants