Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flakyness in RemoteStoreRefreshListenerIT #8547

Merged
merged 2 commits into from
Jul 9, 2023

Conversation

ashking94
Copy link
Member

@ashking94 ashking94 commented Jul 8, 2023

Description

Fix flakyness in RemoteStoreRefreshListernerIT -> testRemoteRefreshRetryOnFailure

Related Issues

Resolves #7703

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ashish Singh <ssashish@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testPitCreatedOnReplica
      1 org.opensearch.index.IndexServiceTests.testAsyncTranslogTrimTaskOnClosedIndex

@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Merging #8547 (75d5987) into main (3928ddc) will increase coverage by 0.13%.
The diff coverage is 25.00%.

@@             Coverage Diff              @@
##               main    #8547      +/-   ##
============================================
+ Coverage     70.81%   70.95%   +0.13%     
- Complexity    56894    56986      +92     
============================================
  Files          4758     4758              
  Lines        269359   269359              
  Branches      39409    39410       +1     
============================================
+ Hits         190740   191114     +374     
+ Misses        62545    62107     -438     
- Partials      16074    16138      +64     
Impacted Files Coverage Δ
...nsearch/gradle/testclusters/OpenSearchCluster.java 0.00% <0.00%> (ø)
...opensearch/gradle/testclusters/OpenSearchNode.java 0.00% <0.00%> (ø)
.../gradle/testclusters/TestClusterConfiguration.java 0.00% <ø> (ø)
...rch/search/query/ConcurrentQueryPhaseSearcher.java 56.75% <7.69%> (-18.25%) ⬇️
...ensearch/search/internal/ContextIndexSearcher.java 68.04% <28.57%> (-2.95%) ⬇️
.../org/opensearch/search/internal/SearchContext.java 36.17% <33.33%> (-0.20%) ⬇️
...n/java/org/opensearch/search/query/QueryPhase.java 78.14% <50.00%> (-0.67%) ⬇️
...search/index/shard/RemoteStoreRefreshListener.java 82.92% <75.00%> (-0.41%) ⬇️

... and 465 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2023

Gradle Check (Jenkins) Run Completed with:

@ashking94
Copy link
Member Author

ashking94 commented Jul 9, 2023

The unmuted IT has been run successfully for 3000 iterations.

Signed-off-by: Ashish Singh <ssashish@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2023

Gradle Check (Jenkins) Run Completed with:

@sachinpkale
Copy link
Member

codecov/patch failures on files that are not changed as part of this PR.

@sachinpkale sachinpkale merged commit fa34121 into opensearch-project:main Jul 9, 2023
@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label Jul 9, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 9, 2023
---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
(cherry picked from commit fa34121)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
owaiskazi19 pushed a commit that referenced this pull request Jul 9, 2023
---------


(cherry picked from commit fa34121)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vikasvb90 pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
raghuvanshraj pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
dzane17 pushed a commit to dzane17/OpenSearch that referenced this pull request Jul 12, 2023
---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
buddharajusahil pushed a commit to buddharajusahil/OpenSearch that referenced this pull request Jul 18, 2023
---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] org.opensearch.remotestore.RemoteStoreRefreshListenerIT.testRemoteRefreshRetryOnFailure is flaky
2 participants