Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flakyness in RemoteStoreRefreshListenerTests #8550

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

ashking94
Copy link
Member

@ashking94 ashking94 commented Jul 9, 2023

Description

Fix flakyness in RemoteStoreRefreshListenerTests -> testRefreshSuccessOnThirdAttemptAttempt

Related Issues

Resolves #8549

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ashking94
Copy link
Member Author

I will need to rebase after #8547 is merged.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testPrimaryStopped_ReplicaPromoted
      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Merging #8550 (43cc42f) into main (fa34121) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #8550      +/-   ##
============================================
- Coverage     70.97%   70.97%   -0.01%     
+ Complexity    57015    56942      -73     
============================================
  Files          4758     4758              
  Lines        269362   269362              
  Branches      39408    39408              
============================================
- Hits         191173   191172       -1     
+ Misses        62149    62073      -76     
- Partials      16040    16117      +77     

see 466 files with indirect coverage changes

@sachinpkale
Copy link
Member

I will need to rebase after #8547 is merged.

#8547 is merged. Please rebase.

Signed-off-by: Ashish Singh <ssashish@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2023

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Ashish Singh <ssashish@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.SearchTimeoutIT.testSimpleTimeout
      1 org.opensearch.indices.replication.SegmentReplicationRelocationIT.testPrimaryRelocation

@sachinpkale
Copy link
Member

Re-triggering precommit

@sachinpkale sachinpkale merged commit 9fd1ddb into opensearch-project:main Jul 10, 2023
@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label Jul 10, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 10, 2023
---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
(cherry picked from commit 9fd1ddb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale pushed a commit that referenced this pull request Jul 10, 2023
---------


(cherry picked from commit 9fd1ddb)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vikasvb90 pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
…8550)

---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
raghuvanshraj pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
…8550)

---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
dzane17 pushed a commit to dzane17/OpenSearch that referenced this pull request Jul 12, 2023
…8550)

---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
buddharajusahil pushed a commit to buddharajusahil/OpenSearch that referenced this pull request Jul 18, 2023
…8550)

---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
…8550)

---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…8550)

---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
2 participants