-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flakyness in RemoteStoreRefreshListenerTests #8550
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashking94
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah,
dbwiddis and
sachinpkale
as code owners
July 9, 2023 02:38
I will need to rebase after #8547 is merged. |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8550 +/- ##
============================================
- Coverage 70.97% 70.97% -0.01%
+ Complexity 57015 56942 -73
============================================
Files 4758 4758
Lines 269362 269362
Branches 39408 39408
============================================
- Hits 191173 191172 -1
+ Misses 62149 62073 -76
- Partials 16040 16117 +77 |
Signed-off-by: Ashish Singh <ssashish@amazon.com>
sachinpkale
reviewed
Jul 9, 2023
server/src/test/java/org/opensearch/index/shard/RemoteStoreRefreshListenerTests.java
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
sachinpkale
approved these changes
Jul 10, 2023
Re-triggering |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 10, 2023
--------- Signed-off-by: Ashish Singh <ssashish@amazon.com> (cherry picked from commit 9fd1ddb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale
pushed a commit
that referenced
this pull request
Jul 10, 2023
--------- (cherry picked from commit 9fd1ddb) Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vikasvb90
pushed a commit
to raghuvanshraj/OpenSearch
that referenced
this pull request
Jul 12, 2023
…8550) --------- Signed-off-by: Ashish Singh <ssashish@amazon.com>
raghuvanshraj
pushed a commit
to raghuvanshraj/OpenSearch
that referenced
this pull request
Jul 12, 2023
…8550) --------- Signed-off-by: Ashish Singh <ssashish@amazon.com>
dzane17
pushed a commit
to dzane17/OpenSearch
that referenced
this pull request
Jul 12, 2023
…8550) --------- Signed-off-by: Ashish Singh <ssashish@amazon.com>
buddharajusahil
pushed a commit
to buddharajusahil/OpenSearch
that referenced
this pull request
Jul 18, 2023
…8550) --------- Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
baba-devv
pushed a commit
to baba-devv/OpenSearch
that referenced
this pull request
Jul 29, 2023
…8550) --------- Signed-off-by: Ashish Singh <ssashish@amazon.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…8550) --------- Signed-off-by: Ashish Singh <ssashish@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix flakyness in
RemoteStoreRefreshListenerTests
->testRefreshSuccessOnThirdAttemptAttempt
Related Issues
Resolves #8549
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.