Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mute flaky test SearchWeightedRoutingIT.testStrictWeightedRoutingWith… #9175

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

Poojita-Raj
Copy link
Contributor

…CustomString

Description

Mutes flaky test SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString
As mentioned in this comment by @dreamer-89: #8279 (comment)

This test has failed 85 times between build number 20900 to 22120. Muting it till the issue is fixed.


(base) ➜  OpenSearch git:(main) ruby ~/Desktop/flaky-finder.rb --s 20900 --e 22120                         
Will crawl builds from 20900 to 22120
------------------
85 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString (20928,20928,20928,20935,20938,20938,20948,20949,20949,20949,20950,20958,20958,20958,20990,20995,21001,21006,21122,21187,21219,21219,21219,21268,21268,21308,21314,21314,21314,21331,21347,21350,21366,21366,21435,21445,21447,21487,21507,21535,21539,21578,21590,21590,21592,21592,21592,21600,21617,21631,21631,21638,21647,21647,21679,21696,21696,21697,21726,21726,21726,21731,21731,21731,21751,21763,21767,21767,21772,21791,21794,21794,21798,21806,21843,21843,21855,21855,21949,22021,22043,22060,22089,22094,22094)

Related Issues

Related to #8030

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@dreamer-89 dreamer-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Poojita-Raj for quickly jumping on this one.

This is the top hitter in last two flaky test reports. I think muting it till it is fixed is the right thing to do.

  1. [Meta] Segment Replication flaky test failures #8279 (comment)
  2. [Meta] Segment Replication flaky test failures #8279 (comment)

@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/security-analytics.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

BUILD SUCCESSFUL in 27m 46s

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Gradle Check (Jenkins) Run Completed with:

…CustomString

Signed-off-by: Poojita Raj <poojiraj@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #9175 (8566578) into main (6eb87b5) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #9175      +/-   ##
============================================
+ Coverage     71.10%   71.12%   +0.02%     
- Complexity    57326    57329       +3     
============================================
  Files          4768     4768              
  Lines        270540   270540              
  Branches      39559    39559              
============================================
+ Hits         192369   192434      +65     
+ Misses        61966    61902      -64     
+ Partials      16205    16204       -1     

see 466 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Gradle Check (Jenkins) Run Completed with:

@Poojita-Raj
Copy link
Contributor Author

Gradle Check (Jenkins) Run Completed with:

* **RESULT:** FAILURE ❌

* **URL:** https://build.ci.opensearch.org/job/gradle-check/22170/

* **CommitID:** [8566578](https://github.com/opensearch-project/OpenSearch/commit/85665781699427da43c32d2eca81f7ac040791ee)
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure [a flaky test](https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#flaky-tests) unrelated to your change?

#9178

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Gradle Check (Jenkins) Run Completed with:

@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

BUILD SUCCESSFUL in 38m 15s

@Rishikesh1159 Rishikesh1159 merged commit b2af655 into opensearch-project:main Aug 9, 2023
@Rishikesh1159 Rishikesh1159 added the backport 2.x Backport to 2.x branch label Aug 9, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 9, 2023
…CustomString (#9175)

Signed-off-by: Poojita Raj <poojiraj@amazon.com>
(cherry picked from commit b2af655)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Rishikesh1159 pushed a commit that referenced this pull request Aug 9, 2023
…CustomString (#9175) (#9205)

(cherry picked from commit b2af655)

Signed-off-by: Poojita Raj <poojiraj@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
…CustomString (opensearch-project#9175)

Signed-off-by: Poojita Raj <poojiraj@amazon.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
…CustomString (opensearch-project#9175)

Signed-off-by: Poojita Raj <poojiraj@amazon.com>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…CustomString (opensearch-project#9175)

Signed-off-by: Poojita Raj <poojiraj@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants