-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] The spotless should take care of unified imports ordering (test/ subprojects) #9351
[BUG] The spotless should take care of unified imports ordering (test/ subprojects) #9351
Conversation
…rojects) Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #9351 +/- ##
============================================
+ Coverage 71.07% 71.12% +0.04%
- Complexity 57387 57436 +49
============================================
Files 4777 4777
Lines 270705 270705
Branches 39565 39565
============================================
+ Hits 192410 192536 +126
+ Misses 62052 61953 -99
+ Partials 16243 16216 -27 |
Compatibility status:
|
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-9351-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a1faafed3ad88dd8f863e40766b7f035df0ed99b
# Push it to GitHub
git push --set-upstream origin backport/backport-9351-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
Backporting after #9352 |
@owaiskazi19 I'll take care of backport, thanks for help! |
…rojects) (opensearch-project#9351) Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> (cherry picked from commit a1faafe)
…rojects) (opensearch-project#9351) Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: Kiran Reddy <kkreddy@amazon.com>
…rojects) (opensearch-project#9351) Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
…rojects) (opensearch-project#9351) Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
…rojects) (opensearch-project#9351) Signed-off-by: Owais Kazi <owaiskazi19@gmail.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
Came out of #9082 (review), the spotless does not enforce any formatting on order of imports statements, as such those are very chaotic in the codebase.
Related Issues
Part of #9306, since there are ~3k files changed across all subprojects, sending smaller pull requests for each of the subproject.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.