-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] [Refactor] Task foundation classes to core library - pt 1 (#9082) #9352
[Backport 2.x] [Refactor] Task foundation classes to core library - pt 1 (#9082) #9352
Conversation
Gradle Check (Jenkins) Run Completed with:
|
6b3f874
to
47f0ec9
Compare
Compatibility status:
|
Gradle Check (Jenkins) Run Completed with:
|
…-project#9082) This is the first round refactor of the foundation Task classes from the server module to core and common library. This is split into separate commits due to control the surface area impacted by the change. This commit refactors the following classes: * o.o.action.ActionFuture -> :libs:opensearch-common * o.o.action.ActionListener -> :libs:opensearch-core * o.o.action.ActionResponse -> :libs:opensearch-core * o.o.action.NotifyOnceListener -> :libs:opensearch-core * o.o.common.compress.Compressor -> :libs:opensearch-core * o.o.node.ReportingService -> o.o.core.service in :libs:opensearch-core * o.o.tasks.TaskCancelledExceptoin -> :libs:opensearch-core * o.o.tasks.TaskId -> :libs:opensearch-core * o.o.common.xcontent.ObjectParserHelper -> :libs:opensearch-core The following task resource tracking classes are refactored into a new resourcetracker namespace under the o.o.core.tasks packed in :libs:opensearch-core * o.o.tasks.ResourceStats * o.o.tasks.ResourceStatsType * o.o.tasks.ResourceUsageMetric * o.o.tasks.TaskResourceStats * o.o.tasks.TaskResourceUsage * o.o.tasks.TaskThreadUsage * o.o.tasks.ThreadResourceInfo These refactors are part of the effort to split foundation classes into core libraries in support of modularity for serverless and cloud native implementations. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> (cherry picked from commit de2b6b7)
47f0ec9
to
a86635c
Compare
Compatibility status:
|
Gradle Check (Jenkins) Run Completed with:
|
@reta @nknize This source of this change required ~15 PRs [1] to be merged across the OpenSearch product, how are we helping consumers of OpenSearch core handle this?
|
Fair point, we (as maintainers) should be helping out if the downstream projects are out of capacity |
@nknize Are you able to pitch in and help the plugins adapt to these changes? |
### Description Manual backport for #3153 of React to changes in ActionListener in core Also includes a fix for a call to XContentHelper.toXContent in response to opensearch-project/OpenSearch#9156 ### Issues Resolved * Relate opensearch-project/OpenSearch#9352 * Relate #3153 ### Check List - [ ] ~New functionality includes testing~ - [ ] ~New functionality has been documented~ - [X] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). --------- Signed-off-by: Ryan Liang <jiallian@amazon.com> Signed-off-by: Peter Nied <petern@amazon.com> Co-authored-by: Peter Nied <petern@amazon.com>
Sure thing. It looks like a lot of the pain stems from some downstream repos not just having a dependency on core but also a dependency on other repos (e.g., job-scheduler, common-util) thus the change has to land in certain repos first before they can be useable in others. |
Backport de2b6b7 from #9082.