Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Support overriding defaultTitle for Notifications send via Alerting #731

Closed
AWSHurneyt opened this issue Dec 13, 2022 · 5 comments
Closed
Labels
bug Something isn't working

Comments

@AWSHurneyt
Copy link
Collaborator

Is your feature request related to a problem?
When the migration of destinations to the Notifications plugin that happened in OS 2.0, the subject line of migrated Alerting trigger action messages have been replaced with the defaultTitle "Alerting-Notification Action" when using SNS to send the emails. The old subject line then appears in the message body.

What solution would you like?
Ideally, if a subject line is populated, Notifications should use that for the email subject instead of the defaultTitle.

Workarounds

  1. Users can setup an SES Notification Channel which takes in the title as the subject.
@AWSHurneyt AWSHurneyt added enhancement New feature or request untriaged bug Something isn't working and removed enhancement New feature or request labels Dec 13, 2022
@AWSHurneyt AWSHurneyt changed the title [FEATURE] Support overriding defaultTitle for Notifications send via Alerting [Bug] Support overriding defaultTitle for Notifications send via Alerting Dec 14, 2022
@adamdepollo
Copy link

Commenting because this is an urgent fix for my team. We have near 100 alerts that have been impacted by this and switching everything over to SES in the interim will be a big lift.

@uroskarama
Copy link
Contributor

uroskarama commented Dec 20, 2022

@praveensameneni @adamdepollo this change on alerting plugin should produce the desired behavior

@praveensameneni
Copy link
Member

We have a code fix in the works that will be merged today

@qreshi qreshi transferred this issue from opensearch-project/notifications Jan 4, 2023
@qreshi
Copy link
Contributor

qreshi commented Jan 4, 2023

Transferred this issue to the Alerting plugin repo as that's where the defaultTitle override needed to occur.

@qreshi
Copy link
Contributor

qreshi commented Jan 9, 2023

Closing issue as the change has been merged in.

@qreshi qreshi closed this as completed Jan 9, 2023
dankyalo599 added a commit to dankyalo599/alerting that referenced this issue Jan 23, 2023
dankyalo599 added a commit to dankyalo599/alerting that referenced this issue Jan 23, 2023
dankyalo599 added a commit to dankyalo599/alerting that referenced this issue Jan 23, 2023
Signed-off-by: danielkyalo599 <johbiento@gmail.com>
dankyalo599 added a commit to dankyalo599/alerting that referenced this issue Jan 23, 2023
Signed-off-by: danielkyalo599 <johbiento@gmail.com>
dankyalo599 added a commit to dankyalo599/alerting that referenced this issue Jan 24, 2023
Signed-off-by: danielkyalo599 <johbiento@gmail.com>
dankyalo599 added a commit to dankyalo599/alerting that referenced this issue Jan 24, 2023
Signed-off-by: danielkyalo599 <johbiento@gmail.com>
dankyalo599 added a commit to dankyalo599/alerting that referenced this issue Jan 25, 2023
Signed-off-by: danielkyalo599 <johbiento@gmail.com>
dankyalo599 added a commit to dankyalo599/alerting that referenced this issue Jan 25, 2023
Signed-off-by: danielkyalo599 <johbiento@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants