-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Support overriding defaultTitle for Notifications send via Alerting #731
Comments
Commenting because this is an urgent fix for my team. We have near 100 alerts that have been impacted by this and switching everything over to SES in the interim will be a big lift. |
@praveensameneni @adamdepollo this change on alerting plugin should produce the desired behavior |
We have a code fix in the works that will be merged today |
Transferred this issue to the Alerting plugin repo as that's where the defaultTitle override needed to occur. |
Closing issue as the change has been merged in. |
Signed-off-by: danielkyalo599 <johbiento@gmail.com>
Signed-off-by: danielkyalo599 <johbiento@gmail.com>
Signed-off-by: danielkyalo599 <johbiento@gmail.com>
Signed-off-by: danielkyalo599 <johbiento@gmail.com>
Signed-off-by: danielkyalo599 <johbiento@gmail.com>
Signed-off-by: danielkyalo599 <johbiento@gmail.com>
Is your feature request related to a problem?
When the migration of destinations to the Notifications plugin that happened in OS 2.0, the
subject
line of migrated Alerting trigger action messages have been replaced with thedefaultTitle
"Alerting-Notification Action" when using SNS to send the emails. The oldsubject
line then appears in the messagebody
.What solution would you like?
Ideally, if a
subject
line is populated, Notifications should use that for the email subject instead of thedefaultTitle
.Workarounds
SES Notification Channel
which takes in thetitle
as thesubject
.The text was updated successfully, but these errors were encountered: