-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix setting default title only when no subject has been set #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
qreshi
reviewed
Jan 12, 2023
...ng/src/main/kotlin/org/opensearch/alerting/util/destinationmigration/NotificationApiUtils.kt
Show resolved
Hide resolved
eirsep
approved these changes
Feb 9, 2023
rishabhmaurya
approved these changes
Feb 9, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 9, 2023
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> (cherry picked from commit 830dff1)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.5 2.5
# Navigate to the new working tree
cd .worktrees/backport-2.5
# Create a new branch
git switch --create backport/backport-750-to-2.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 830dff1d17c9a002efe417b55b84219b14c0c2fe
# Push it to GitHub
git push --set-upstream origin backport/backport-750-to-2.5
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.5 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.5 2.5
# Navigate to the new working tree
cd .worktrees/backport-2.5
# Create a new branch
git switch --create backport/backport-750-to-2.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 830dff1d17c9a002efe417b55b84219b14c0c2fe
# Push it to GitHub
git push --set-upstream origin backport/backport-750-to-2.5
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.5 Then, create a pull request where the |
lezzago
added a commit
to lezzago/alerting-opensearch
that referenced
this pull request
Feb 9, 2023
…ch-project#750) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 9, 2023
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> (cherry picked from commit 830dff1)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 9, 2023
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> (cherry picked from commit 830dff1)
lezzago
added a commit
that referenced
this pull request
Feb 10, 2023
AWSHurneyt
pushed a commit
that referenced
this pull request
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ashish Agrawal ashisagr@amazon.com
Issue #, if available:
#529, #731
Description of changes:
Set default title only when there is no subject passed.
action message configuration example:
Current message look in chime:
Before Notification plugin introduction in chime:
With the fix look in chime:
With the fix for SNS:
CheckList:
[X] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.