Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting default title only when no subject has been set #750

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

lezzago
Copy link
Member

@lezzago lezzago commented Jan 12, 2023

Signed-off-by: Ashish Agrawal ashisagr@amazon.com

Issue #, if available:
#529, #731
Description of changes:
Set default title only when there is no subject passed.

action message configuration example:
action message configuration

Current message look in chime:
old notification look

Before Notification plugin introduction in chime:
before 2 0 behavior

With the fix look in chime:
updated message look

With the fix for SNS:
Screen Shot 2023-02-09 at 11 14 16 AM

CheckList:
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
@lezzago lezzago requested a review from a team January 12, 2023 04:29
@lezzago lezzago merged commit 830dff1 into opensearch-project:main Feb 9, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 9, 2023
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 830dff1)
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.5 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.5 2.5
# Navigate to the new working tree
cd .worktrees/backport-2.5
# Create a new branch
git switch --create backport/backport-750-to-2.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 830dff1d17c9a002efe417b55b84219b14c0c2fe
# Push it to GitHub
git push --set-upstream origin backport/backport-750-to-2.5
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.5

Then, create a pull request where the base branch is 2.5 and the compare/head branch is backport/backport-750-to-2.5.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.5 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.5 2.5
# Navigate to the new working tree
cd .worktrees/backport-2.5
# Create a new branch
git switch --create backport/backport-750-to-2.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 830dff1d17c9a002efe417b55b84219b14c0c2fe
# Push it to GitHub
git push --set-upstream origin backport/backport-750-to-2.5
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.5

Then, create a pull request where the base branch is 2.5 and the compare/head branch is backport/backport-750-to-2.5.

lezzago added a commit to lezzago/alerting-opensearch that referenced this pull request Feb 9, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 9, 2023
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 830dff1)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 9, 2023
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 830dff1)
lezzago added a commit that referenced this pull request Feb 9, 2023
)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
lezzago added a commit that referenced this pull request Feb 10, 2023
)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 830dff1)

Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
AWSHurneyt pushed a commit that referenced this pull request Jun 2, 2023
)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 830dff1)

Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants