Skip to content

Commit

Permalink
Remove dataSourceFilter that breaks DataSourceView (#837)
Browse files Browse the repository at this point in the history
  • Loading branch information
jackiehanyang authored Aug 12, 2024
1 parent 4c49c8c commit 7940942
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 9 deletions.
2 changes: 0 additions & 2 deletions public/pages/ConfigureModel/containers/ConfigureModel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ import { getErrorMessage } from '../../../utils/utils';
import {
constructHrefWithDataSourceId,
getDataSourceFromURL,
isDataSourceCompatible,
} from '../../../pages/utils/helpers';
import {
getDataSourceManagementPlugin,
Expand Down Expand Up @@ -271,7 +270,6 @@ export function ConfigureModel(props: ConfigureModelProps) {
fullWidth: false,
savedObjects: getSavedObjectsClient(),
notifications: getNotifications(),
dataSourceFilter: isDataSourceCompatible,
}}
/>
);
Expand Down
1 change: 0 additions & 1 deletion public/pages/DefineDetector/containers/DefineDetector.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,6 @@ export const DefineDetector = (props: DefineDetectorProps) => {
fullWidth: false,
savedObjects: getSavedObjectsClient(),
notifications: getNotifications(),
dataSourceFilter: isDataSourceCompatible,
}}
/>
);
Expand Down
3 changes: 1 addition & 2 deletions public/pages/DetectorDetail/containers/DetectorDetail.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ import {
getNotifications,
getSavedObjectsClient,
} from '../../../services';
import { constructHrefWithDataSourceId, getDataSourceFromURL, isDataSourceCompatible } from '../../../pages/utils/helpers';
import { constructHrefWithDataSourceId, getDataSourceFromURL } from '../../../pages/utils/helpers';

export interface DetectorRouterProps {
detectorId?: string;
Expand Down Expand Up @@ -430,7 +430,6 @@ export const DetectorDetail = (props: DetectorDetailProps) => {
fullWidth: false,
savedObjects: getSavedObjectsClient(),
notifications: getNotifications(),
dataSourceFilter: isDataSourceCompatible,
}}
/>
);
Expand Down
2 changes: 0 additions & 2 deletions public/pages/DetectorJobs/containers/DetectorJobs.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ import { RouteComponentProps, useLocation } from 'react-router-dom';
import {
constructHrefWithDataSourceId,
getDataSourceFromURL,
isDataSourceCompatible,
} from '../../../pages/utils/helpers';
import {
getDataSourceManagementPlugin,
Expand Down Expand Up @@ -141,7 +140,6 @@ export function DetectorJobs(props: DetectorJobsProps) {
fullWidth: false,
savedObjects: getSavedObjectsClient(),
notifications: getNotifications(),
dataSourceFilter: isDataSourceCompatible,
}}
/>
);
Expand Down
2 changes: 0 additions & 2 deletions public/pages/ReviewAndCreate/containers/ReviewAndCreate.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ import {
import {
constructHrefWithDataSourceId,
getDataSourceFromURL,
isDataSourceCompatible,
} from '../../../pages/utils/helpers';
import {
getDataSourceManagementPlugin,
Expand Down Expand Up @@ -311,7 +310,6 @@ export function ReviewAndCreate(props: ReviewAndCreateProps) {
fullWidth: false,
savedObjects: getSavedObjectsClient(),
notifications: getNotifications(),
dataSourceFilter: isDataSourceCompatible,
}}
/>
);
Expand Down

0 comments on commit 7940942

Please sign in to comment.