Remove dataSourceFilter that breaks DataSourceView #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
jackiehanyang
requested review from
ohltyler,
kaituo,
amitgalitz,
sean-zheng-amazon,
dbwiddis,
owaiskazi19 and
joshpalis
as code owners
dbwiddis
approved these changes
Aug 12, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 12, 2024
(cherry picked from commit 7940942)
jackiehanyang
pushed a commit
that referenced
this pull request
Aug 12, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 13, 2024
(cherry picked from commit 7940942)
jackiehanyang
added a commit
that referenced
this pull request
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DataSourceView is broken on future playground and TrineoApp, however, no console/network errors shown and can't reproduce it locally.
Pull 2.16 and 2.15 docker image and tested with them. Found that it only breaks under 2.16 docker. The only change between 2.15 and 2.16 is adding this dataSourceFilter for version decoupling work. Suspecting it is because the dataSourceFilter filtered out the version so DataSourceView is giving error says "cannot find data source". Since the scenario where AD uses DataSourceView doesn't require data source filtering, I'm removing the dataSourceFilter check for all DataSourceView usage in AD.
As it cannot be reproduced locally, confirmed the fix with deploying the docker image.
Issues Resolved
[List any issues this PR will resolve]
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.