[Feature/extensions] Get detector stats api #857

vibrantvarun · 2023-04-06T00:11:07Z

Description

Get Detector Stats API
The api's Provides information about how the plugin is performing.

Issues Resolved

opensearch-project/opensearch-sdk-java#382

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Varun Jain <varunudr@amazon.com>

codecov-commenter · 2023-04-06T00:22:07Z

Codecov Report

Merging #857 (b119e16) into feature/extensions (8b31c13) will increase coverage by 0.03%.
The diff coverage is 1.75%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@                   Coverage Diff                    @@
##             feature/extensions     #857      +/-   ##
========================================================
+ Coverage                 35.96%   36.00%   +0.03%     
- Complexity                 1916     1926      +10     
========================================================
  Files                       299      299              
  Lines                     17615    17647      +32     
  Branches                   1862     1862              
========================================================
+ Hits                       6335     6353      +18     
- Misses                    10825    10838      +13     
- Partials                    455      456       +1

Flag	Coverage Δ
plugin	`36.00% <1.75%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...va/org/opensearch/ad/AnomalyDetectorExtension.java	`0.00% <0.00%> (ø)`
...search/ad/rest/RestStatsAnomalyDetectorAction.java	`0.00% <0.00%> (ø)`
...arch/ad/transport/ADStatsNodesTransportAction.java	`0.00% <0.00%> (ø)`
...transport/StatsAnomalyDetectorTransportAction.java	`0.00% <0.00%> (ø)`
...c/main/java/org/opensearch/ad/util/IndexUtils.java	`2.38% <0.00%> (-1.20%)`	⬇️
.../java/org/opensearch/ad/util/RestHandlerUtils.java	`69.69% <ø> (ø)`
...rg/opensearch/ad/constant/CommonErrorMessages.java	`98.36% <100.00%> (+0.02%)`	⬆️

... and 2 files with indirect coverage changes

joshpalis · 2023-04-06T00:52:33Z

src/main/java/org/opensearch/ad/rest/RestStatsAnomalyDetectorAction.java

 */
-public class RestStatsAnomalyDetectorAction extends BaseRestHandler {
+public class RestStatsAnomalyDetectorAction extends AbstractAnomalyDetectorAction {


why extend the AbstractAnomalyDetectorAction instead of BaseExtensionRestHandler

Looks like it gets that base class by inheritance, and adds access to several settings in the process that will get updated via settings update consumers.

However, later on in this class we're just fetching the setting directly and not taking advantage of the inheritance.

So either way is good but we should be consistent!

Okay. I am replacing it with BaseExtensionRestHandler to maintain the consistency

src/main/java/org/opensearch/ad/AnomalyDetectorExtension.java

dbwiddis · 2023-04-06T17:43:37Z

src/main/java/org/opensearch/ad/rest/RestStatsAnomalyDetectorAction.java

 */
-public class RestStatsAnomalyDetectorAction extends BaseRestHandler {
+public class RestStatsAnomalyDetectorAction extends AbstractAnomalyDetectorAction {


Looks like it gets that base class by inheritance, and adds access to several settings in the process that will get updated via settings update consumers.

However, later on in this class we're just fetching the setting directly and not taking advantage of the inheritance.

So either way is good but we should be consistent!

dbwiddis · 2023-04-06T17:49:50Z

src/main/java/org/opensearch/ad/transport/ADStatsNodesTransportAction.java

-public class ADStatsNodesTransportAction extends
-    TransportNodesAction<ADStatsRequest, ADStatsNodesResponse, ADStatsNodeRequest, ADStatsNodeResponse> {
-
+public class ADStatsNodesTransportAction extends TransportAction<ADStatsNodeRequest, ADStatsNodesResponse> {


What are we losing by removing this inheritance vs. replacing it with an SDK equivalent? This approach will require all the classes which inherit from this same superclass to have to make the same changes, while if you update (or replace) the superclass, then that's a one-time change that all the subclasses can use.

I have to dig into this. I will post my findings here.

@dbwiddis

When ADStatsNodesTransportAction is used in

Plugin Architecture: It extends TransportNodesAction. The transportNodesAction Accepts 4 parameters
(BaseNodesRequest, NodesResponse, NodeRequest, NodeResponse). It can perform Async operation on multiple nodes.
P.S.: NodeRequest extends TransportRequest

Extension Architecture: It extends TransportAction. The transport action accepts 2 parameters (NodeRequest and NodesResponse). It can only perform request on only 1 node. Therefore in order to provide the functionality similar to TransportNodesAction I can open up a new issue.

As the TransportNodesAction counterpart for extensions needs more understanding and overall scope is beyond GetDetectorStats API.

What would you suggest? Shall I open a new issue?

Yeah, this is probably worth a new issue. Summing it up:

TransportNodesAction is on OpenSearch meant for plugins, so we can't/shouldn't change it for extensions, but

There are some methods that add some functionality to the inheritance from TransportAction, specifically the newResponse method and the abstract methods.

I'm not sure we need a SDKTransportNodesAction but we should at least look into whether it makes sense.

As discussed, I will be opening a new issue for this.

Let's change the request to ADStatsRequest

src/main/java/org/opensearch/ad/util/IndexUtils.java

Signed-off-by: Varun Jain <varunudr@amazon.com>

owaiskazi19

Let's try to minimize the diff for migration by handling the new methods in SDK. This PR adds a lot of new changes. As part of migration we should focus on the above.

Also, get stats has these 2 APIs.

GET _plugins/_anomaly_detection/stats
GET _plugins/_anomaly_detection/<nodeId>/stats.

Can you add checklist in your PR description that you tested both and add the response of the APIs in the issue on SDK repo like?

owaiskazi19 · 2023-04-10T19:29:47Z

src/main/java/org/opensearch/ad/AnomalyDetectorExtension.java

-import org.opensearch.ad.transport.ADJobRunnerTransportAction;
-import org.opensearch.ad.transport.AnomalyDetectorJobAction;
-import org.opensearch.ad.transport.AnomalyDetectorJobTransportAction;
+import org.opensearch.ad.transport.*;


Eh. Wildcard import

owaiskazi19 · 2023-04-10T19:35:07Z

src/main/java/org/opensearch/ad/util/RestHandlerUtils.java

-import java.util.HashSet;
-import java.util.List;
-import java.util.Set;
+import java.util.*;


Wildcard import

owaiskazi19 · 2023-04-10T19:37:27Z

src/main/java/org/opensearch/ad/util/RestHandlerUtils.java

@@ -230,4 +236,49 @@ public static boolean isProperExceptionToReturn(Throwable e) {
    private static String coalesceToEmpty(@Nullable String s) {
        return s == null ? "" : s;
    }
+
+    public static final String unrecognized(RestRequest request, Set<String> invalids, Set<String> candidates, String detail) {


This method was a part of BaseRestHandler to reduce the diff and maintain the consistency we should add it in BaseExtensionRestHandler if not present already and pull it from there.

owaiskazi19 · 2023-04-10T19:38:49Z

src/test/java/org/opensearch/ad/transport/handler/AbstractIndexHandlerTest.java

@@ -73,6 +74,9 @@ enum IndexCreation {
    @Mock
    protected IndexNameExpressionResolver indexNameResolver;

+    @Mock
+    protected OpenSearchAsyncClient openSearchAsyncClient;


Here and above. I know it doesn't align with the variable naming but the wrapper is actually from java client which we created in SDK and for better understanding.

Suggested change

protected OpenSearchAsyncClient openSearchAsyncClient;

protected OpenSearchAsyncClient javaAsyncClient;

I agree with your suggestion.

src/main/java/org/opensearch/ad/transport/StatsAnomalyDetectorTransportAction.java

owaiskazi19 · 2023-04-10T19:45:27Z

src/main/java/org/opensearch/ad/transport/ADStatsNodesTransportAction.java

-        List<FailedNodeException> failures
-    ) {
-        return new ADStatsNodesResponse(clusterService.getClusterName(), responses, failures);
+    public ADStatsNodesResponse newResponse(List<ADStatsNodeResponse> responses, List<FailedNodeException> failures) {


Let's not change the method arguments here because the tests would be affected. Old method had ADStatsRequest as one of the param

owaiskazi19 · 2023-04-10T19:46:11Z

src/main/java/org/opensearch/ad/transport/ADStatsNodesTransportAction.java

-import java.util.List;
-import java.util.Map;
-import java.util.Set;
+import java.util.*;


owaiskazi19 · 2023-04-10T19:47:51Z

src/main/java/org/opensearch/ad/rest/RestStatsAnomalyDetectorAction.java

+            .orTimeout(AnomalyDetectorSettings.REQUEST_TIMEOUT.get(settings).getMillis(), TimeUnit.MILLISECONDS)
+            .join();
+
+        logger.info("Stats Response is  **********************  " + statsAnomalyDetectorResponse.toString());


We don't have to log the response here. Leftover?

yes. Sorry it was left by mistake. Will remove it in the new iteration.

owaiskazi19 · 2023-04-10T19:51:28Z

src/main/java/org/opensearch/ad/transport/ADStatsNodesTransportAction.java

+        if (adStatsNodeResponse != null) {
+            responses.add(adStatsNodeResponse);
+        }
+        listener.onResponse(newResponse(responses, failures));


Based on this we might won't need doExecute here.

As of now, we need doExecute method as We have to cater all the aspects needed to implement the above referenced work.

Let's add a TODO and link the issue here.

opensearch-project/opensearch-sdk-java#683

Done added in PR as well

owaiskazi19 · 2023-04-10T19:52:25Z

src/main/java/org/opensearch/ad/transport/ADStatsNodeRequest.java


 /**
 *  ADStatsNodeRequest to get a nodes stat
 */
-public class ADStatsNodeRequest extends TransportRequest {
+public class ADStatsNodeRequest extends ActionRequest {


Why are we changing the request here?

Because as per the changes made by dan in TransportRequest, it now accepts the request which extends the ActionRequest and response which extends ActionResponse

ActionRequest extends TransportRequest so this doesn't break anything but does add some functionality relying on ActionRequest signature. Is this being triggered remotely from JS, etc. and that's why we need the ActionRequest?

No this request is not being triggered from JS

Same question as Owais, if its not necessary to change then lets revert this change

As suggested by @dbwiddis I will open a new issue where we will cater the blast radius of TransportNodesAction and will do the required work there.

Did you get any error if you keep the request as TransportRequest?

yes I got an error, TransportAction only accepts the requests which extends ActionRequest.

Signed-off-by: Varun Jain <varunudr@amazon.com>

dbwiddis

LGTM generally. Will review again after @owaiskazi19's comments are addressed.

dbwiddis · 2023-04-10T23:19:38Z

src/main/java/org/opensearch/ad/rest/RestStatsAnomalyDetectorAction.java

    public String getName() {
        return STATS_ANOMALY_DETECTOR_ACTION;
    }

    @Override
-    protected RestChannelConsumer prepareRequest(RestRequest request, NodeClient client) {
+    public List<RouteHandler> routeHandlers() {


This implementation works for now and no need to hold up this PR. But heads up that with SDK #665 we'll be able to go back to the replaced routs format of existing rest handler classes. So stay tuned!

src/main/java/org/opensearch/ad/util/IndexUtils.java

dbwiddis · 2023-04-10T23:30:54Z

src/main/java/org/opensearch/ad/transport/ADStatsNodeRequest.java


 /**
 *  ADStatsNodeRequest to get a nodes stat
 */
-public class ADStatsNodeRequest extends TransportRequest {
+public class ADStatsNodeRequest extends ActionRequest {


ActionRequest extends TransportRequest so this doesn't break anything but does add some functionality relying on ActionRequest signature. Is this being triggered remotely from JS, etc. and that's why we need the ActionRequest?

dbwiddis · 2023-04-10T23:38:41Z

src/main/java/org/opensearch/ad/rest/RestStatsAnomalyDetectorAction.java

+            .toXContent(JsonXContent.contentBuilder(), ToXContent.EMPTY_PARAMS);
+        ExtensionRestResponse response = new ExtensionRestResponse(request, RestStatus.OK, statsAnomalyDetectorResponseBuilder);
+
+        return response;


(Style) Why not just return new ExtensionRestResponse(...) here instead of creating a new object and returning it on the next line? Yeah, the compiler optimizes this out, just reads better to me. :)

dbwiddis · 2023-04-10T23:43:20Z

src/main/java/org/opensearch/ad/constant/CommonErrorMessages.java

@@ -94,6 +94,8 @@ public static String getTooManyCategoricalFieldErr(int limit) {
    public static String FAIL_TO_GET_STATS = "Fail to get stats";
    public static String FAIL_TO_SEARCH = "Fail to search";

+    public static String FAIL_TO_GET_NODE_STATS = "Fail to get node stats";


Nit 1. I know you're coping from the previous error messages on lines 85-93, but this should be "failed" rather than "fail". (As should all the rest.)

Nit 2. All the others are together without whitespace in between them, this one isn't special. Save that CR byte from the file size!

dbwiddis · 2023-04-10T23:51:24Z

src/main/java/org/opensearch/ad/transport/ADStatsNodesTransportAction.java

-public class ADStatsNodesTransportAction extends
-    TransportNodesAction<ADStatsRequest, ADStatsNodesResponse, ADStatsNodeRequest, ADStatsNodeResponse> {
-
+public class ADStatsNodesTransportAction extends TransportAction<ADStatsNodeRequest, ADStatsNodesResponse> {


Yeah, this is probably worth a new issue. Summing it up:

TransportNodesAction is on OpenSearch meant for plugins, so we can't/shouldn't change it for extensions, but

There are some methods that add some functionality to the inheritance from TransportAction, specifically the newResponse method and the abstract methods.

I'm not sure we need a SDKTransportNodesAction but we should at least look into whether it makes sense.

Signed-off-by: Varun Jain <varunudr@amazon.com>

vibrantvarun · 2023-04-14T17:03:31Z

curl -X GET "localhost:9200/_extensions/_ad-extension-1/stats/"

{
  "anomaly_detectors_index_status": "non-existent",
  "anomaly_detection_state_status": "non-existent",
  "single_entity_detector_count": 0,
  "detector_count": 0,
  "multi_entity_detector_count": 0,
  "anomaly_detection_job_index_status": "non-existent",
  "models_checkpoint_index_status": "non-existent",
  "anomaly_results_index_status": "non-existent",
  "nodes": {
    "ad-extension-1": {
      "ad_execute_request_count": 0,
      "models": [
        
      ],
      "ad_canceled_batch_task_count": 0,
      "ad_hc_execute_request_count": 0,
      "ad_hc_execute_failure_count": 0,
      "model_count": 0,
      "ad_execute_failure_count": 0,
      "ad_batch_task_failure_count": 0,
      "ad_total_batch_task_execution_count": 0,
      "ad_executing_batch_task_count": 0
    }
  }
}

vibrantvarun · 2023-04-14T17:05:49Z

curl -X GET "localhost:9200/_extensions/_ad-extension-1/stats/ad_hc_execute_failure_count"

{
 "nodes": {
   "ad-extension-1": {
     "ad_hc_execute_failure_count": 0
   }
 }
}

vibrantvarun · 2023-04-14T17:07:40Z

curl -X GET "localhost:9200/_extensions/_ad-extension-1/_ad-extension-1/stats/ad_hc_execute_failure_count"

{
  "nodes": {
    "ad-extension-1": {
      "ad_hc_execute_failure_count": 0
    }
  }
}

vibrantvarun · 2023-04-14T17:08:55Z

curl -X GET "localhost:9200/_extensions/_ad-extension-1/_ad-extension-1/stats"

{
  "anomaly_detectors_index_status": "non-existent",
  "anomaly_detection_state_status": "non-existent",
  "single_entity_detector_count": 0,
  "detector_count": 0,
  "multi_entity_detector_count": 0,
  "anomaly_detection_job_index_status": "non-existent",
  "models_checkpoint_index_status": "non-existent",
  "anomaly_results_index_status": "non-existent",
  "nodes": {
    "ad-extension-1": {
      "ad_execute_request_count": 0,
      "models": [
        
      ],
      "ad_canceled_batch_task_count": 0,
      "ad_hc_execute_request_count": 0,
      "ad_hc_execute_failure_count": 0,
      "model_count": 0,
      "ad_execute_failure_count": 0,
      "ad_batch_task_failure_count": 0,
      "ad_total_batch_task_execution_count": 0,
      "ad_executing_batch_task_count": 0
    }
  }
}

Signed-off-by: Varun Jain <varunudr@amazon.com>

joshpalis · 2023-04-14T17:42:37Z

@vibrantvarun I am curious to see the behavior once a detector is created and started. You can refer to this guide on how to generate test data and how to create/run a detector.

Edit : I realized you wont be able to test out start detector until this PR is merged in. Let's just test out the behavior after creating single and multi-entity detectors for now

dbwiddis

LGTM. I see some comments from @owaiskazi19 that should be answered.

vibrantvarun · 2023-04-14T21:48:00Z

Response of detector stats after triggering create detector api

{
  "anomaly_detectors_index_status": "yellow",
  "anomaly_detection_state_status": "non-existent",
  "single_entity_detector_count": 1,
  "detector_count": 1,
  "multi_entity_detector_count": 0,
  "anomaly_detection_job_index_status": "non-existent",
  "models_checkpoint_index_status": "non-existent",
  "anomaly_results_index_status": "non-existent",
  "nodes": {
    "ad-extension-1": {
      "ad_execute_request_count": 0,
      "models": [
        
      ],
      "ad_canceled_batch_task_count": 0,
      "ad_hc_execute_request_count": 0,
      "ad_hc_execute_failure_count": 0,
      "model_count": 0,
      "ad_execute_failure_count": 0,
      "ad_batch_task_failure_count": 0,
      "ad_total_batch_task_execution_count": 0,
      "ad_executing_batch_task_count": 0
    }
  }
}

owaiskazi19 · 2023-04-14T23:22:37Z

@vibrantvarun can you add the response and API in the issue like I mentioned above?

owaiskazi19

Almost there. Plus the comments above and this. Thanks

owaiskazi19 · 2023-04-14T23:28:52Z

src/main/java/org/opensearch/ad/transport/ADStatsNodeRequest.java


 /**
 *  ADStatsNodeRequest to get a nodes stat
 */
-public class ADStatsNodeRequest extends TransportRequest {
+public class ADStatsNodeRequest extends ActionRequest {


Did you get any error if you keep the request as TransportRequest?

owaiskazi19 · 2023-04-14T23:29:58Z

src/main/java/org/opensearch/ad/transport/ADStatsNodesTransportAction.java

+        if (adStatsNodeResponse != null) {
+            responses.add(adStatsNodeResponse);
+        }
+        listener.onResponse(newResponse(responses, failures));


Let's add a TODO and link the issue here.

owaiskazi19 · 2023-04-14T23:35:12Z

src/main/java/org/opensearch/ad/util/RestHandlerUtils.java

+
+    public static final String NODE_ID = "nodeId";
+
+    public static final String STAT = "stat";


We generally add the constant for rest handler URI but it's fine to add for request param as well. Can you remove the extra lines here?

owaiskazi19 · 2023-04-14T23:35:38Z

src/test/java/org/opensearch/ad/stats/ADStatsTests.java

+        // SDKClusterService.SDKClusterSettings clusterSettings = sdkClusterService.new SDKClusterSettings(
+        // Settings.EMPTY, Collections.unmodifiableSet(new HashSet<>(Arrays.asList(MAX_MODEL_SIZE_PER_NODE)))
+        // );
+        // when(sdkClusterService.getClusterSettings()).thenReturn(clusterSettings);


Do we need this commented code here anymore?

owaiskazi19 · 2023-04-14T23:36:48Z

src/test/java/org/opensearch/ad/transport/handler/AbstractIndexHandlerTest.java

@@ -73,6 +74,9 @@ enum IndexCreation {
    @Mock
    protected IndexNameExpressionResolver indexNameResolver;

+    @Mock
+    protected OpenSearchAsyncClient javaAsyncClient;


Can you mock the client in setUp like:

sdkJavaAsyncClient = mock(OpenSearchAsyncClient.class);

Signed-off-by: Varun Jain <varunudr@amazon.com>

owaiskazi19

Looks much cleaner now. Few small suggestions

owaiskazi19 · 2023-04-18T17:07:23Z

src/main/java/org/opensearch/ad/rest/RestStatsAnomalyDetectorAction.java

        Set<String> validStats = adStats.getStats().keySet();

-        ADStatsRequest adStatsRequest = null;
+        ADStatsRequest adStatsRequest;


You can initialize with null

owaiskazi19 · 2023-04-18T17:08:05Z

src/main/java/org/opensearch/ad/transport/ADStatsNodesTransportAction.java


+import com.google.inject.Inject;
+
+// TODO: https://github.com/opensearch-project/opensearch-sdk-java/issues/683 (multi node support for extensions)


Can you add more details on why multi node support is needed here?

owaiskazi19 · 2023-04-18T17:12:34Z

src/test/java/org/opensearch/ad/transport/handler/AbstractIndexHandlerTest.java

@@ -12,8 +12,7 @@
 package org.opensearch.ad.transport.handler;

 import static org.mockito.ArgumentMatchers.any;
-import static org.mockito.Mockito.doAnswer;
-import static org.mockito.Mockito.when;
+import static org.mockito.Mockito.*;


Wildcard import :(

owaiskazi19 · 2023-04-18T17:14:02Z

src/test/java/org/opensearch/ad/transport/handler/AbstractIndexHandlerTest.java

@@ -73,6 +73,9 @@ enum IndexCreation {
    @Mock
    protected IndexNameExpressionResolver indexNameResolver;

+    @Mock
+    protected static OpenSearchAsyncClient sdkJavaAsyncClient;


You are mocking it already below. No need to mock here. Just move this after line 60 and say:

protected OpenSearchAsyncClient sdkJavaAsyncClient;

Signed-off-by: Varun Jain <varunudr@amazon.com>

owaiskazi19

LGTM! Thanks for addressing the feedback

vibrantvarun added 3 commits April 4, 2023 00:02

Modifying RestStatsAnomalyDetectorAction

907029f

Signed-off-by: Varun Jain <varunudr@amazon.com>

Uncommenting test cases

96518b8

Signed-off-by: Varun Jain <varunudr@amazon.com>

Get Detector Stats

f8545cd

Signed-off-by: Varun Jain <varunudr@amazon.com>

opensearch-trigger-bot bot added backport 2.x infra Changes to infrastructure, testing, CI/CD, pipelines, etc. labels Apr 6, 2023

vibrantvarun changed the base branch from main to feature/extensions April 6, 2023 00:13

Merge branch 'feature/extensions' into getDetectorStatsAPI

b4e0f24

joshpalis reviewed Apr 6, 2023

View reviewed changes

dbwiddis changed the title ~~Get detector stats api~~ [Feature/extensions] Get detector stats api Apr 6, 2023

dbwiddis reviewed Apr 6, 2023

View reviewed changes

owaiskazi19 removed infra Changes to infrastructure, testing, CI/CD, pipelines, etc. backport 2.x labels Apr 6, 2023

vibrantvarun marked this pull request as ready for review April 10, 2023 18:52

vibrantvarun requested a review from a team April 10, 2023 18:52

Removing unwanted log statements

47a580b

Signed-off-by: Varun Jain <varunudr@amazon.com>

owaiskazi19 requested changes Apr 10, 2023

View reviewed changes

vibrantvarun added 3 commits April 10, 2023 14:03

Updating with latest Pull changes and addressing comments

42cf0bd

Signed-off-by: Varun Jain <varunudr@amazon.com>

Addressing comments

51f91db

Signed-off-by: Varun Jain <varunudr@amazon.com>

Addressing comments

770e269

Signed-off-by: Varun Jain <varunudr@amazon.com>

dbwiddis reviewed Apr 10, 2023

View reviewed changes

owaiskazi19 mentioned this pull request Apr 12, 2023

Updates PLUGIN_MIGRATION.md for aggregation return type opensearch-project/opensearch-sdk-java#673

Merged

vibrantvarun added 2 commits April 13, 2023 14:21

Addressing Dan's comments

b5cef75

Signed-off-by: Varun Jain <varunudr@amazon.com>

Merge branch 'feature/extensions' into getDetectorStatsAPI

34e9a4f

Addressing comments

53a9a63

Signed-off-by: Varun Jain <varunudr@amazon.com>

joshpalis self-requested a review April 14, 2023 18:09

dbwiddis approved these changes Apr 14, 2023

View reviewed changes

vibrantvarun requested a review from owaiskazi19 April 14, 2023 20:25

joshpalis approved these changes Apr 14, 2023

View reviewed changes

owaiskazi19 requested changes Apr 14, 2023

View reviewed changes

vibrantvarun added 2 commits April 17, 2023 10:19

Addressed Owais Comments

e5e7ad1

Signed-off-by: Varun Jain <varunudr@amazon.com>

Addressing owais comments

b119e16

Signed-off-by: Varun Jain <varunudr@amazon.com>

owaiskazi19 reviewed Apr 18, 2023

View reviewed changes

Addressing Owais Comments

bde7343

Signed-off-by: Varun Jain <varunudr@amazon.com>

owaiskazi19 approved these changes Apr 18, 2023

View reviewed changes

owaiskazi19 merged commit 45251ac into opensearch-project:feature/extensions Apr 18, 2023

vibrantvarun deleted the getDetectorStatsAPI branch April 18, 2023 17:39

owaiskazi19 mentioned this pull request May 1, 2023

[Feature/Extensions] Profile detector #882

Merged

	protected OpenSearchAsyncClient openSearchAsyncClient;
	protected OpenSearchAsyncClient javaAsyncClient;


		public static final String NODE_ID = "nodeId";

		public static final String STAT = "stat";


		import com.google.inject.Inject;

		// TODO: https://github.com/opensearch-project/opensearch-sdk-java/issues/683 (multi node support for extensions)

[Feature/extensions] Get detector stats api #857

[Feature/extensions] Get detector stats api #857

Conversation

vibrantvarun commented Apr 6, 2023 • edited Loading

Description

Issues Resolved

codecov-commenter commented Apr 6, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

owaiskazi19 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dbwiddis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vibrantvarun commented Apr 14, 2023

vibrantvarun commented Apr 14, 2023

vibrantvarun commented Apr 14, 2023

vibrantvarun commented Apr 14, 2023

joshpalis commented Apr 14, 2023 • edited Loading

dbwiddis left a comment

Choose a reason for hiding this comment

vibrantvarun commented Apr 14, 2023

owaiskazi19 commented Apr 14, 2023

owaiskazi19 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

owaiskazi19 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vibrantvarun commented Apr 6, 2023 •

edited

Loading

codecov-commenter commented Apr 6, 2023 •

edited

Loading

owaiskazi19 left a comment •

edited

Loading

joshpalis commented Apr 14, 2023 •

edited

Loading

owaiskazi19 left a comment •

edited

Loading

owaiskazi19 left a comment •

edited

Loading