Add indexPatterns to map embeddable output for dashboard filters #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #272 +/- ##
=======================================
Coverage 91.79% 91.79%
=======================================
Files 10 10
Lines 268 268
Branches 34 34
=======================================
Hits 246 246
Misses 16 16
Partials 6 6 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
naveentatikonda
approved these changes
Feb 21, 2023
VijayanB
approved these changes
Feb 22, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 22, 2023
Signed-off-by: Junqiu Lei <junqiu@amazon.com> (cherry picked from commit 8697636)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 22, 2023
Signed-off-by: Junqiu Lei <junqiu@amazon.com> (cherry picked from commit 8697636)
junqiu-lei
added a commit
that referenced
this pull request
Feb 22, 2023
junqiu-lei
added a commit
that referenced
this pull request
Feb 22, 2023
VijayanB
pushed a commit
to VijayanB/dashboards-maps
that referenced
this pull request
Mar 20, 2023
…nsearch-project#272) (opensearch-project#278) Signed-off-by: Junqiu Lei <junqiu@amazon.com> (cherry picked from commit 8697636) Co-authored-by: Junqiu Lei <junqiu@amazon.com> (cherry picked from commit 11cf90e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In dashboard global filter bar component, it need read indexPatterns information from maps embeddable output to correctly show the maps data layers indexPattern.
Consuming ref: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/dashboard/public/application/dashboard_app_controller.tsx#L292
Issues Resolved
#214
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.