Refactor integration validation logic with a cleaner interface #943

Swiddis · 2023-08-21T18:57:09Z

Description

While working on the unrelated remote catalog feature, I separately refactored our Ajv usage to provide better error messages and help break tight coupling. This change on its own is small and generally applicable, so I've moved it to its own PR.

Issues Resolved

N/A

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

This test is unneeded after 12c4bcf Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

codecov · 2023-08-21T19:17:01Z

Codecov Report

Merging #943 (85041c0) into main (c8587fd) will increase coverage by 0.02%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #943      +/-   ##
==========================================
+ Coverage   43.68%   43.71%   +0.02%     
==========================================
  Files         313      313              
  Lines       18698    18706       +8     
  Branches     4554     4557       +3     
==========================================
+ Hits         8169     8177       +8     
- Misses       9973    10487     +514     
+ Partials      556       42     -514

Flag	Coverage Δ
dashboards-observability	`43.71% <ø> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 81 files with indirect coverage changes

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

server/adaptors/integrations/validators.ts

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

* Refactor validation logic with a deeper interface Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove redundant test. This test is unneeded after 12c4bcf Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for new validators Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Make better failure mode for invalid objects Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Convert validator methods to use result types Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit 09e5d52) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Bugfix filter not appearing, and loading on click Signed-off-by: TackAdam <navytackett@hotmail.com> * Fixed applications not working with change Signed-off-by: TackAdam <navytackett@hotmail.com> * Fixed refresh keeping the old pattern stored in the query Signed-off-by: TackAdam <navytackett@hotmail.com> * Add integration content Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Copy updated types Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Patterns working in Applications and Logs Signed-off-by: TackAdam <navytackett@hotmail.com> * Update mapping files to match current catalog versions Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Removed tempQuery from log patterns Signed-off-by: TackAdam <navytackett@hotmail.com> * Copy aws_elb integration from @danieldong51 Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove nginx logo from gallery Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove extra logo from nginx Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Cypress test for panels working, bugfix on toast message Signed-off-by: TackAdam <navytackett@hotmail.com> * Removed unused function Signed-off-by: TackAdam <navytackett@hotmail.com> * Copy path sanitization from osints/dev Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * add docker-compose support (#575) * add capability to build the plugin and add it into the docker of the Opensearch-Dashboard update the developer-guid to reflect the correct bootstraping process add docker-compose support and tutorial Signed-off-by: YANGDB <yang.db.dev@gmail.com> * Update Dockerfile * Update Dockerfile and adding .env * Update Using-Docker.md Co-authored-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: YANGDB <yang.db.dev@gmail.com> --------- Signed-off-by: YANGDB <yang.db.dev@gmail.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> * Merge Kibana backend from osints/dev into main (#565) * Merge in kibana backend from osints/dev Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add integration type to .kibana from osints/dev Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Re-add license header Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix integrations type Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fixing bug with saved visualization querys from logs Signed-off-by: TackAdam <navytackett@hotmail.com> * code clean up Signed-off-by: Eric Wei <menwe@amazon.com> * update snapshots Signed-off-by: Eric Wei <menwe@amazon.com> * remove unused utils, color theme, and editor components Signed-off-by: Eric Wei <menwe@amazon.com> * add to index file Signed-off-by: Eric Wei <menwe@amazon.com> * Feature/prerelease code cleanup (#589) * refactor naming Signed-off-by: Eric Wei <menwe@amazon.com> * refactor vis workspace Signed-off-by: Eric Wei <menwe@amazon.com> * config panel refactoring Signed-off-by: Eric Wei <menwe@amazon.com> * refactor workspace Signed-off-by: Eric Wei <menwe@amazon.com> --------- Signed-off-by: Eric Wei <menwe@amazon.com> * Replace metrics slider with ResizableContainer (#602) Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> * Fixing cypress testing for apps Signed-off-by: TackAdam <navytackett@hotmail.com> * Fix availability not being displayed in panel Signed-off-by: TackAdam <navytackett@hotmail.com> * Fixed config data and layout Signed-off-by: TackAdam <navytackett@hotmail.com> * changed fix implementation to not break unit test Signed-off-by: TackAdam <navytackett@hotmail.com> * uncommented lines after bugfix Signed-off-by: TackAdam <navytackett@hotmail.com> * Delete missed comments Signed-off-by: TackAdam <navytackett@hotmail.com> * Prevent empty string being parsed Signed-off-by: TackAdam <navytackett@hotmail.com> * Pull changes from osints/dev Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Copy frontend from osints/dev Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Hotfix: Update nginx dashboard to remove errors Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * address pr comments Signed-off-by: Derek Ho <dxho@amazon.com> * address pr comments Signed-off-by: Derek Ho <dxho@amazon.com> * Upgrade tough-cookie and semver (#619) (#627) * Upgrade tough-cookie to fix CVE-2023-26136 * Add semver resolution to patch CVE-2022-25883 --------- Signed-off-by: Rupal Mahajan <maharup@amazon.com> Co-authored-by: Rupal Mahajan <maharup@amazon.com> * Merge frontend from osints/dev (#636) * Remove unused NDJson parsing code Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove unused instance store Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Move repository logic to own class Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for IntegrationsRepository Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for kibana backend Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Hotfix: Clear repository between runs in testing Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * fix tests and import Signed-off-by: Derek Ho <dxho@amazon.com> * add sanity test cypress test Signed-off-by: Derek Ho <dxho@amazon.com> * clean up code Signed-off-by: Derek Ho <dxho@amazon.com> * Add tests for integration builder Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Hotfix: Swap jest test to it Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * { "attributes": { "description": "Nginx dashboard with basic Observability on access / error logs", "hits": 0, "kibanaSavedObjectMeta": { "searchSourceJSON": "{\"query\":{\"language\":\"kuery\",\"query\":\"\"},\"filter\":[]}" }, "optionsJSON": "{\"hidePanelTitles\":false,\"useMargins\":true}", "panelsJSON": "[{\"version\":\"2.5.0\",\"gridData\":{\"h\":8,\"i\":\"1f31e50b-06e3-41e6-972e-e4e5fe1a9872\",\"w\":48,\"x\":0,\"y\":0},\"panelIndex\":\"1f31e50b-06e3-41e6-972e-e4e5fe1a9872\",\"embeddableConfig\":{},\"panelRefName\":\"panel_0\"},{\"version\":\"2.5.0\",\"gridData\":{\"h\":9,\"i\":\"d91a8da4-b34b-470a-aca6-9c76b47cd6fb\",\"w\":24,\"x\":0,\"y\":8},\"panelIndex\":\"d91a8da4-b34b-470a-aca6-9c76b47cd6fb\",\"embeddableConfig\":{},\"panelRefName\":\"panel_1\"},{\"version\":\"2.5.0\",\"gridData\":{\"h\":15,\"i\":\"27149e5a-3a77-4f3c-800e-8a160c3765f4\",\"w\":24,\"x\":24,\"y\":8},\"panelIndex\":\"27149e5a-3a77-4f3c-800e-8a160c3765f4\",\"embeddableConfig\":{},\"panelRefName\":\"panel_2\"},{\"version\":\"2.5.0\",\"gridData\":{\"x\":0,\"y\":17,\"w\":24,\"h\":15,\"i\":\"4d8c2aa7-159c-4a1a-80ff-00a9299056ce\"},\"panelIndex\":\"4d8c2aa7-159c-4a1a-80ff-00a9299056ce\",\"embeddableConfig\":{},\"panelRefName\":\"panel_3\"},{\"version\":\"2.5.0\",\"gridData\":{\"x\":24,\"y\":23,\"w\":24,\"h\":15,\"i\":\"800b7f19-f50c-417f-8987-21b930531cbe\"},\"panelIndex\":\"800b7f19-f50c-417f-8987-21b930531cbe\",\"embeddableConfig\":{},\"panelRefName\":\"panel_4\"}]", "timeRestore": false, "title": "[NGINX Core Logs 1.0] Overview", "version": 1 }, "id": "96847220-5261-44d0-89b4-65f3a659f13a", "migrationVersion": { "dashboard": "7.9.3" }, "references": [ { "id": "3b49a65d-54d8-483d-a8f0-3d7c855e1ecf", "name": "panel_0", "type": "visualization" }, { "id": "865e577b-634b-4a65-b9d6-7e324c395d18", "name": "panel_1", "type": "visualization" }, { "id": "dc1803f0-b478-11ed-9063-ebe46f9ac203", "name": "panel_2", "type": "visualization" }, { "id": "99acc580-b47a-11ed-9063-ebe46f9ac203", "name": "panel_3", "type": "visualization" }, { "id": "01ea64d0-b62f-11ed-a677-43d7aa86763b", "name": "panel_4", "type": "visualization" } ], "type": "dashboard", "updated_at": "2023-02-26T23:44:09.855Z", "version": "WzczLDdd" } Signed-off-by: Derek Ho <dxho@amazon.com> * Stub out sample integration data for front-end Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Use more realistic integration sample Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add full traversal to fields list Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add license to integration template Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * add some unit testing framework Signed-off-by: Derek Ho <dxho@amazon.com> * fix up the testing name Signed-off-by: Derek Ho <dxho@amazon.com> * fix up table view and add a test Signed-off-by: Derek Ho <dxho@amazon.com> * add an added integration table test using dummy data Signed-off-by: Derek Ho <dxho@amazon.com> * add integration specific types and clean up code Signed-off-by: Derek Ho <dxho@amazon.com> * clean up code and use integration specific types Signed-off-by: Derek Ho <dxho@amazon.com> * Route integrations page to actual repository Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Hotfix: Remove unused import Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Hotfix: Use loading spinner Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * add some changes to UI according to figma Signed-off-by: Derek Ho <dxho@amazon.com> * add license headers and hook up get to specific instance for added page Signed-off-by: Derek Ho <dxho@amazon.com> * add screenshots and fix up mappings and breadcrumbs Signed-off-by: Derek Ho <dxho@amazon.com> * Add failing test case for empty object Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Make template test pass Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * use flyout according to figma and connect flyout input to backend creation Signed-off-by: Derek Ho <dxho@amazon.com> * implement delete Signed-off-by: Derek Ho <dxho@amazon.com> * fix up tests for changes Signed-off-by: Derek Ho <dxho@amazon.com> * get added page to working order Signed-off-by: Derek Ho <dxho@amazon.com> * Add template validator via Ajv Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix builder tests for new validation Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * add unit test coverage Signed-off-by: Derek Ho <dxho@amazon.com> * update page and tests to remove added by for integration instances Signed-off-by: Derek Ho <dxho@amazon.com> * deleting an instance also deletes its children saved objects Signed-off-by: Derek Ho <dxho@amazon.com> * Add integration instance validation Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * update components and snapshots with data-test-subj for cypress tests and add more comprehensive cypress test suite Signed-off-by: Derek Ho <dxho@amazon.com> * remove unecessary console logging Signed-off-by: Derek Ho <dxho@amazon.com> * Hotfix: Minor code cleanup Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * dynamically handle id generation to allow for multiple instances of the same template to be created Signed-off-by: Derek Ho <dxho@amazon.com> * Update integration with fixed panels Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Apply minor behavior tweaks Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Refactor repository for new format Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * fix empty assets bug Signed-off-by: Derek Ho <dxho@amazon.com> * Write basic FS latest integration queries Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Update integration template type and validator Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add template retrieval to repository fs Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add copyright notice to repository_fs Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * fix escape Signed-off-by: Derek Ho <dxho@amazon.com> * revert file Signed-off-by: Derek Ho <dxho@amazon.com> * fix test Signed-off-by: Derek Ho <dxho@amazon.com> * Stub composite repository class Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Apply minor condition refactor Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fill in basic implementation for integration class Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for integration class Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix type errors on repository tests Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Patch: Handle files with invalid version formats Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Refactor displayAssets to assets Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add basic getAssets implementation Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add handling for invalid config error case Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add handling for failed saved object loading Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add basic getStatic method Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix handling for missing statics Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove outdated repository classes Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add docs for the integration class Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Hook up router to new static loading Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Clarify content-type docs Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix details page crashes due to outdated schema Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Infer mime type for statics Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix screenshot loading on integrations details page Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Hotfix: Remove mimetypes from nginx 1.0.0 Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add getSchemas method with tests Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Make minor modifications to integration typing Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add integration deep check Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Refactor integration builder Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix remap ID method Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix loading process Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Refactor tests for new integrations backend Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix type errors in test suite Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * hook up datasource creation from flyout to backend Signed-off-by: Derek Ho <dxho@amazon.com> * remove nullable Signed-off-by: Derek Ho <dxho@amazon.com> * Add schema route to router Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix frontend request routing for new API Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Hotfix: Fix added integration errors Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Hotfix: Add an actual screenshot Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Hotfix: Remove unused assets folder Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Hotfix: Use Oui images Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Make integration instance deletion more robust Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove asset map (again Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix remap data source Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Correct deletion for actual 404 behavior Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add display name field to integrations Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Apply display name through frontend Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Hotfix: Use display name on table view Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove unused code in flyout Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Stub mapping validation on frontend Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add error message for failed validation result Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix request to proxy Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add more detailed handling for missing schemas Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Apply integration type in validation Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add full schema validation Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add unit tests for mapping validation Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix type checking in unit tests Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * create dataSource UI option Signed-off-by: Derek Ho <dxho@amazon.com> * Hotfix: Update route for listing added integrations Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Hotfix: Fix component tests Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add basic status querying Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add unit tests for availability queries Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * create ss4o index from ui Signed-off-by: Derek Ho <dxho@amazon.com> * code cleanup Signed-off-by: Derek Ho <dxho@amazon.com> * use user input Signed-off-by: Derek Ho <dxho@amazon.com> * Hotfix: Sync package versions with osd Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix path-dependent tests on windows Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Hotfix: Repair template naming on index autocreation Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Hotfix: Allow wildcards in index pattern specification Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Hotfix: Remove redundant integrationType field Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Hotfix: Remove unused schema files Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Hotfix: Add sample data Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * move integrations under core (pending ux) Signed-off-by: Derek Ho <dxho@amazon.com> * Fix handling for templates on create Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Merge in kibana backend from osints/dev Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add integration type to .kibana from osints/dev Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Re-add license header Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * hook up toast Signed-off-by: Derek Ho <dxho@amazon.com> * Update integration-instance type Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Hotfix: Fix types again Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Hotfix: Fix cypress Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add sample data endpoint Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add license checking to eslint Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Created elb integration Signed-off-by: Daniel Dong <danieldong51@amazon.com> * successfully hook up toast and block until done with for loop Signed-off-by: Derek Ho <dxho@amazon.com> * fix and fix test Signed-off-by: Derek Ho <dxho@amazon.com> * Added screenshot of elb integration` Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Updated aws_elb descriptions and logos Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Deleted .DS_Store Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Added container in components Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Merged markers Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Hotfix: Rename installed integrations to added integrations Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Hotfix: Revert Nginx sample prettifying Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * remove console.log Signed-off-by: Derek Ho <dxho@amazon.com> * updates cypress test to test create data source flow with toast Signed-off-by: Derek Ho <dxho@amazon.com> * update snapshot based on cypress changes Signed-off-by: Derek Ho <dxho@amazon.com> * get rid of extra line Signed-off-by: Derek Ho <dxho@amazon.com> * update according to figma Signed-off-by: Derek Ho <dxho@amazon.com> * Fix integrations type Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Sanitize file path for getting integration statics Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Update tests for merge Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * make some UX improvements Signed-off-by: Derek Ho <dxho@amazon.com> * Add basic sample data loading Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * moves integration on left nav, removes unused create flow Signed-off-by: Derek Ho <dxho@amazon.com> * hook up sample data to a standalone button Signed-off-by: Derek Ho <dxho@amazon.com> * fix tests Signed-off-by: Derek Ho <dxho@amazon.com> * implement length validation and update tests accordingly Signed-off-by: Derek Ho <dxho@amazon.com> * disable buttons while adding Signed-off-by: Derek Ho <dxho@amazon.com> * fix breadcrumbs and tests Signed-off-by: Derek Ho <dxho@amazon.com> * update according to figma Signed-off-by: Derek Ho <dxho@amazon.com> * maek some changes according to figma Signed-off-by: Derek Ho <dxho@amazon.com> * implement tabbing for both added/available and fields/assets Signed-off-by: Derek Ho <dxho@amazon.com> * remove status on template, change status to badge on instance and hook up type filtering for added Signed-off-by: Derek Ho <dxho@amazon.com> * remove actions Signed-off-by: Derek Ho <dxho@amazon.com> * convert to badges Signed-off-by: Derek Ho <dxho@amazon.com> * fix tests Signed-off-by: Derek Ho <dxho@amazon.com> * remove columns from table Signed-off-by: Derek Ho <dxho@amazon.com> * add linking to all assets Signed-off-by: Derek Ho <dxho@amazon.com> * fix unit and integration tests Signed-off-by: Derek Ho <dxho@amazon.com> * final fix up Signed-off-by: Derek Ho <dxho@amazon.com> * fix filtering Signed-off-by: Derek Ho <dxho@amazon.com> * final fix up Signed-off-by: Derek Ho <dxho@amazon.com> * fix tests Signed-off-by: Derek Ho <dxho@amazon.com> * add cateogry filter and fix tests Signed-off-by: Derek Ho <dxho@amazon.com> * fix cypress and unit tests Signed-off-by: Derek Ho <dxho@amazon.com> * Fix broken index template naming in sample creation Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add priority to logs mapping and fix index pattern Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * fix various UI and add validation Signed-off-by: Derek Ho <dxho@amazon.com> * add request metrics Signed-off-by: Derek Ho <dxho@amazon.com> * fix tests, remove console log Signed-off-by: Derek Ho <dxho@amazon.com> * add metrics to links and final UX fix up, test fixes Signed-off-by: Derek Ho <dxho@amazon.com> * add back installed Signed-off-by: Derek Ho <dxho@amazon.com> * Fix broken nginx panels Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * address pr comments Signed-off-by: Derek Ho <dxho@amazon.com> * address pr comments Signed-off-by: Derek Ho <dxho@amazon.com> * Hotfix: Fix constants Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add learn more link to index field Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove unused AWS ELB integration Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove unused ELB constants Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove redundant EUI spacing Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix snapshots Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * fix relative path Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Derek Ho <derek01778@gmail.com> Signed-off-by: Daniel Dong <danieldong51@amazon.com> Co-authored-by: Derek Ho <dxho@amazon.com> Co-authored-by: Derek Ho <derek01778@gmail.com> Co-authored-by: Daniel Dong <danieldong51@amazon.com> * Release Notes 2.9.0 * Release Notes 2.9.0 --------- Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> * Update Release Notes 2.9 w/ Documentation section (#652) Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> * Remove unused files (#662) * remove unused files Signed-off-by: Eric Wei <menwe@amazon.com> * missing snapshots Signed-off-by: Eric Wei <menwe@amazon.com> --------- Signed-off-by: Eric Wei <menwe@amazon.com> * Cypress ci integration (#443) * add cypress parallel Signed-off-by: Eric Wei <menwe@amazon.com> * cypress workflow Signed-off-by: Eric Wei <menwe@amazon.com> * fix plugin crash issue Signed-off-by: Eric Wei <menwe@amazon.com> --------- Signed-off-by: Eric Wei <menwe@amazon.com> * Increment version to 3.0.0.0 (#659) Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> * Remade all cypress test for visualizations charts Signed-off-by: TackAdam <navytackett@hotmail.com> * Remove job scheduler from cypress CI (#681) * remove unused files Signed-off-by: Eric Wei <menwe@amazon.com> * missing snapshots Signed-off-by: Eric Wei <menwe@amazon.com> * remove job scheduler from CI artifact downloading Signed-off-by: Eric Wei <menwe@amazon.com> --------- Signed-off-by: Eric Wei <menwe@amazon.com> * update readme to reflect recent changes (#691) Signed-off-by: YANGDB <yang.db.dev@gmail.com> * Add Integration request github issue template (#688) Signed-off-by: YANGDB <yang.db.dev@gmail.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> * adds back cypress watch and reload (#693) Signed-off-by: Derek Ho <dxho@amazon.com> * Fixes for Derek's comments Signed-off-by: TackAdam <navytackett@hotmail.com> * Added sample data load, moved shared constm removed waits Signed-off-by: TackAdam <navytackett@hotmail.com> * Code hygiene moved helpers out of constants Signed-off-by: TackAdam <navytackett@hotmail.com> * fix name change bug and modify test to test behavior (#724) Signed-off-by: Derek Ho <dxho@amazon.com> * Search bar fixes (#727) * fix name change bug and modify test to test behavior Signed-off-by: Derek Ho <dxho@amazon.com> * search bar fixes Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Add AWS VPC Flow Log integration (#698) * Add AWS VPC Flow Log integration Signed-off-by: Haidong <whaidong@amazon.com> * init assets Signed-off-by: Haidong <whaidong@amazon.com> * add more visualizations Signed-off-by: Haidong <whaidong@amazon.com> * add readme for assets and aws vpc flow logs Signed-off-by: Haidong <whaidong@amazon.com> --------- Signed-off-by: Haidong <whaidong@amazon.com> Co-authored-by: Haidong <whaidong@amazon.com> * Update snapshots (#734) * fix name change bug and modify test to test behavior Signed-off-by: Derek Ho <dxho@amazon.com> * update snapshot from previous PR Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Fix vpc (#742) * fix name change bug and modify test to test behavior Signed-off-by: Derek Ho <dxho@amazon.com> * fix vpc flow logs with Simeon Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Bump word-wrap from 1.2.3 to 1.2.4 (#723) Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](https://github.com/jonschlinkert/word-wrap/compare/1.2.3...1.2.4) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update vpc readme & references (#740) * update the vpc flow log readme with a dashboard screenshot and update the sourceUrl to point to the correct place Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update the vpc flow log readme with a dashboard screenshot and update the sourceUrl to point to the correct place Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update author Signed-off-by: Derek Ho <dxho@amazon.com> * { "attributes": { "description": "Nginx dashboard with basic Observability on access / error logs", "hits": 0, "kibanaSavedObjectMeta": { "searchSourceJSON": "{\"query\":{\"language\":\"kuery\",\"query\":\"\"},\"filter\":[]}" }, "optionsJSON": "{\"hidePanelTitles\":false,\"useMargins\":true}", "panelsJSON": "[{\"version\":\"2.5.0\",\"gridData\":{\"h\":8,\"i\":\"1f31e50b-06e3-41e6-972e-e4e5fe1a9872\",\"w\":48,\"x\":0,\"y\":0},\"panelIndex\":\"1f31e50b-06e3-41e6-972e-e4e5fe1a9872\",\"embeddableConfig\":{},\"panelRefName\":\"panel_0\"},{\"version\":\"2.5.0\",\"gridData\":{\"h\":9,\"i\":\"d91a8da4-b34b-470a-aca6-9c76b47cd6fb\",\"w\":24,\"x\":0,\"y\":8},\"panelIndex\":\"d91a8da4-b34b-470a-aca6-9c76b47cd6fb\",\"embeddableConfig\":{},\"panelRefName\":\"panel_1\"},{\"version\":\"2.5.0\",\"gridData\":{\"h\":15,\"i\":\"27149e5a-3a77-4f3c-800e-8a160c3765f4\",\"w\":24,\"x\":24,\"y\":8},\"panelIndex\":\"27149e5a-3a77-4f3c-800e-8a160c3765f4\",\"embeddableConfig\":{},\"panelRefName\":\"panel_2\"},{\"version\":\"2.5.0\",\"gridData\":{\"x\":0,\"y\":17,\"w\":24,\"h\":15,\"i\":\"4d8c2aa7-159c-4a1a-80ff-00a9299056ce\"},\"panelIndex\":\"4d8c2aa7-159c-4a1a-80ff-00a9299056ce\",\"embeddableConfig\":{},\"panelRefName\":\"panel_3\"},{\"version\":\"2.5.0\",\"gridData\":{\"x\":24,\"y\":23,\"w\":24,\"h\":15,\"i\":\"800b7f19-f50c-417f-8987-21b930531cbe\"},\"panelIndex\":\"800b7f19-f50c-417f-8987-21b930531cbe\",\"embeddableConfig\":{},\"panelRefName\":\"panel_4\"}]", "timeRestore": false, "title": "[NGINX Core Logs 1.0] Overview", "version": 1 }, "id": "96847220-5261-44d0-89b4-65f3a659f13a", "migrationVersion": { "dashboard": "7.9.3" }, "references": [ { "id": "3b49a65d-54d8-483d-a8f0-3d7c855e1ecf", "name": "panel_0", "type": "visualization" }, { "id": "865e577b-634b-4a65-b9d6-7e324c395d18", "name": "panel_1", "type": "visualization" }, { "id": "dc1803f0-b478-11ed-9063-ebe46f9ac203", "name": "panel_2", "type": "visualization" }, { "id": "99acc580-b47a-11ed-9063-ebe46f9ac203", "name": "panel_3", "type": "visualization" }, { "id": "01ea64d0-b62f-11ed-a677-43d7aa86763b", "name": "panel_4", "type": "visualization" } ], "type": "dashboard", "updated_at": "2023-02-26T23:44:09.855Z", "version": "WzczLDdd" } Signed-off-by: Derek Ho <dxho@amazon.com> * fix nginx references Signed-off-by: Derek Ho <dxho@amazon.com> * append minor changes Signed-off-by: YANGDB <yang.db.dev@gmail.com> * change to info directory Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: YANGDB <yang.db.dev@gmail.com> Signed-off-by: Derek Ho <dxho@amazon.com> Co-authored-by: Derek Ho <dxho@amazon.com> * Fix snapshots from upstream OSD/OUI changes (#755) * fix name change bug and modify test to test behavior Signed-off-by: Derek Ho <dxho@amazon.com> * udpate snapshots from upstream Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Remove link field from Nginx (#761) * Remove redundant link Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add local repository testing Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * simplify docker-compose.yml (#763) * simplify docker-compose.yml Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update docs regarding security Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update docs security doc and restrictions Signed-off-by: YANGDB <yang.db.dev@gmail.com> --------- Signed-off-by: YANGDB <yang.db.dev@gmail.com> * fix integration json loading parser so that it will trim unneeded empty spaces from the ndjson file and match the existing behavior of the savedObject import dashboard that works even when empty spaces appear in the ndjson file (#758) Signed-off-by: YANGDB <yang.db.dev@gmail.com> * fix docker-compose.yml dashboard issue with OPENSEARCH_HOSTS (#783) Signed-off-by: YANGDB <yang.db.dev@gmail.com> * Fail backport (#778) * fix name change bug and modify test to test behavior Signed-off-by: Derek Ho <dxho@amazon.com> * update fail backport Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Add AWS ELB Integration (#772) * Created aws_elb integration Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Modified schemas Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Modified user_agent to be an object in http Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Added logo and dashboard Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Updated static Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Added more sample data Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Added more sample data Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Updated sourceUrl to be correct page Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Updated dashboard image Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Added image to README.md Signed-off-by: Dan Dong <58446449+danieldong51@users.noreply.github.com> * Updated matched_rule_priority to be int Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Updated README.md with ingestion pipeline info Signed-off-by: Dan Dong <58446449+danieldong51@users.noreply.github.com> * Moved ingestion pipeline to new .md Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Moved Ingestion material out of README.md Signed-off-by: Daniel Dong <danieldong51@amazon.com> --------- Signed-off-by: Daniel Dong <danieldong51@amazon.com> Signed-off-by: Dan Dong <58446449+danieldong51@users.noreply.github.com> Co-authored-by: Daniel Dong <danieldong51@amazon.com> * Feature/metrics sidepanel update (#749) * Metric Sidebar Refactor - Move SearchBar into Sidebar - show icons per-datasource - compress metric-names (prometheus == "p..") --------- Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> * Add Apache Integration (#754) * Modified map visualization to be region map instead of tiles Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Added user agent mapping file Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Added event.dataset field Signed-off-by: Daniel Dong <danieldong51@amazon.com> * removed event.dataset Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Updated author Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Added README.md Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Added dashboard.png and logo.png Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Updated search queries object in assets and another sample log Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Updated geo fields in communication mappings Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Fixed datetime format Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Added geo to destination Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Updated error search query object Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Created Geo object in communications schema Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Changed user_agent to be a subfield of http Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Changed structure of logo and gallery Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Removed user agent from logs component Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Changed user_agent and os fields to be subobjects Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Fixed geo object Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Remoted user_agent from components Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Added geo data to error log Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Updated name Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Added ingestion pipeline info Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Updated README.md to remove ingestion pipeline Signed-off-by: Dan Dong <58446449+danieldong51@users.noreply.github.com> * Created INGESTION.md Signed-off-by: Dan Dong <58446449+danieldong51@users.noreply.github.com> * Updated INGESTION.md Signed-off-by: Dan Dong <58446449+danieldong51@users.noreply.github.com> --------- Signed-off-by: Daniel Dong <danieldong51@amazon.com> Signed-off-by: Dan Dong <58446449+danieldong51@users.noreply.github.com> Co-authored-by: Daniel Dong <danieldong51@amazon.com> * Fix broken Nginx Integration data volume panel (#787) * Fix broken nginx data volume panel Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Re-add sample data Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Updated link in sourceURL (#811) Signed-off-by: Daniel Dong <danieldong51@amazon.com> Co-authored-by: Daniel Dong <danieldong51@amazon.com> * Make integration category and template lists dynamic (#782) * Make category list dynamic Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove unused category constant Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove hardcoded integration template list Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Re-apply fix for VPC type (#809) * Fix VPC type Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add a test case Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Re-apply link fix and update test Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Revert "Re-apply link fix and update test" This reverts commit f2ec20ddee7b4bc24deb570673a031e91ceb63aa. Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Integrations base path fix (#713) * Fix behavior when base path is added Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix handling of base paths for the proxy Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix add integration flyout Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove fetch usages from proxy call Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix request query building Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Switch from props.http to coreRefs.http Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Revert "Switch from props.http to coreRefs.http" This reverts commit f66db8328c7b7e831109cdd80ae486669aaf028a. Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix integration removal timing (#781) * Fix integration removal timing Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove unused commented code Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Nginx Integration Panel Fix: Re-apply link removal (#807) * Fix broken nginx data volume panel Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Re-add sample data Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Re-apply link fix and update test Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Re-apply formatting to local_repository.test.ts Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove dependence on integrations variable (#826) Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix index name collisions on integration sample creation. (#818) * Add integration name to created index mapping Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Switch template naming to loosely reflect SS4O convention Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Split mapping creation by type for code clarity Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Re-introduce confusing result block Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Modify naming template to better match SS4O convention Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Changed log mappings to be apache-specific (#822) Signed-off-by: Daniel Dong <danieldong51@amazon.com> Co-authored-by: Daniel Dong <danieldong51@amazon.com> * Changed logs mappings to be logs-elb (#821) Signed-off-by: Daniel Dong <danieldong51@amazon.com> Co-authored-by: Daniel Dong <danieldong51@amazon.com> * update index template to avoid name collisions (#825) * update index template to avoid name collisions align s3 component template with all the other integrations Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update k8s integration Signed-off-by: YANGDB <yang.db.dev@gmail.com> --------- Signed-off-by: YANGDB <yang.db.dev@gmail.com> * Aws cloudfront integration (#779) * new aws s3 integration Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update s3 dashboard Signed-off-by: YANGDB <yang.db.dev@gmail.com> * remove `link` failing integration config field Signed-off-by: YANGDB <yang.db.dev@gmail.com> * add alias for each specific integration related log mapping template Signed-off-by: YANGDB <yang.db.dev@gmail.com> * fix aws prefix error Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update cloud mapping Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update cloud mapping Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update cloud mapping and sample.json Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update integration.config.type field to match the index mapping schema container Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update dashboard.png Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update sample.json Signed-off-by: YANGDB <yang.db.dev@gmail.com> * aws cloud front integration update Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update only relevant files Signed-off-by: YANGDB <yang.db.dev@gmail.com> * remove nginx's only relevant files Signed-off-by: YANGDB <yang.db.dev@gmail.com> * remove nginx's only relevant files Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update index template to avoid name collisions Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update index template to avoid name collisions Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update according to name collision component strategy Signed-off-by: YANGDB <yang.db.dev@gmail.com> --------- Signed-off-by: YANGDB <yang.db.dev@gmail.com> * aws WAF integration (#788) * aws cloud trail integration Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update dashboard Signed-off-by: YANGDB <yang.db.dev@gmail.com> * aws cloud trail integration Signed-off-by: YANGDB <yang.db.dev@gmail.com> * aws cloud trail integration update Signed-off-by: YANGDB <yang.db.dev@gmail.com> * aws cloud trail integration update Signed-off-by: YANGDB <yang.db.dev@gmail.com> * add support for aws WAF (Web Application Firewall) logs integration Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update dashboard.png Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update index template to avoid name collisions Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update according to name collision component strategy Signed-off-by: YANGDB <yang.db.dev@gmail.com> --------- Signed-off-by: YANGDB <yang.db.dev@gmail.com> * Aws rds Integration support (#741) * update the vpc flow log readme with a dashboard screenshot and update the sourceUrl to point to the correct place Signed-off-by: YANGDB <yang.db.dev@gmail.com> * add support for observability on aws rds logs - using the pre-canned dashboards Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update rds integration Signed-off-by: YANGDB <yang.db.dev@gmail.com> Signed-off-by: YANGDB <yang.db.dev@gmail.com> * add dashboard.jpeg screenshot Signed-off-by: YANGDB <yang.db.dev@gmail.com> * append minor changes Signed-off-by: YANGDB <yang.db.dev@gmail.com> * append minor changes Signed-off-by: YANGDB <yang.db.dev@gmail.com> * fix sq-ip field Signed-off-by: YANGDB <yang.db.dev@gmail.com> * fix sq-ip field Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update dashboard image Signed-off-by: YANGDB <yang.db.dev@gmail.com> * rearrange dashboard Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update according pr comments Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update schema mapping files including cloud mapping Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update vpc flow log containers log name Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update index template to avoid name collisions Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update according to name collision component strategy Signed-off-by: YANGDB <yang.db.dev@gmail.com> * remove none relevant fixes Signed-off-by: YANGDB <yang.db.dev@gmail.com> --------- Signed-off-by: YANGDB <yang.db.dev@gmail.com> * Aws cloudtrail Integration (#773) * aws cloud trail integration Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update dashboard Signed-off-by: YANGDB <yang.db.dev@gmail.com> * aws cloud trail integration Signed-off-by: YANGDB <yang.db.dev@gmail.com> * aws cloud trail integration update Signed-off-by: YANGDB <yang.db.dev@gmail.com> * aws cloud trail integration update Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update index template to avoid name collisions Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update index template to avoid name collisions Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update according to name collision component strategy Signed-off-by: YANGDB <yang.db.dev@gmail.com> --------- Signed-off-by: YANGDB <yang.db.dev@gmail.com> * aws s3 integration (#756) * new aws s3 integration Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update s3 dashboard Signed-off-by: YANGDB <yang.db.dev@gmail.com> * remove `link` failing integration config field Signed-off-by: YANGDB <yang.db.dev@gmail.com> * add alias for each specific integration related log mapping template Signed-off-by: YANGDB <yang.db.dev@gmail.com> * fix aws prefix error Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update cloud mapping Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update cloud mapping Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update cloud mapping and sample.json Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update integration.config.type field to match the index mapping schema container Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update dashboard.png Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update sample.json Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update index template to avoid name collisions Signed-off-by: YANGDB <yang.db.dev@gmail.com> * remove none relevant fixes Signed-off-by: YANGDB <yang.db.dev@gmail.com> --------- Signed-off-by: YANGDB <yang.db.dev@gmail.com> * Modified Integrations Description (#853) * Modified integration description Signed-off-by: Daniel Dong <danieldong51@amazon.com> * Modified integrations description in snapshot Signed-off-by: Daniel Dong <danieldong51@amazon.com> --------- Signed-off-by: Daniel Dong <danieldong51@amazon.com> Co-authored-by: Daniel Dong <danieldong51@amazon.com> * update readme with the integration related docs and screen shorts (#852) Signed-off-by: YANGDB <yang.db.dev@gmail.com> * change unapplied cateogry filter to empty instead of x (#858) Signed-off-by: Derek Ho <dxho@amazon.com> * Fix failing CI (#863) * Update outdated sidebar and searchbar snapshots Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Make backport only run on merged PRs Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * consolidate aws_s3-1.0.0.mapping.json schema to match all across (#851) Signed-off-by: YANGDB <yang.db.dev@gmail.com> * consolidate http-1.0.0.mapping.json schema to match all across (#850) Signed-off-by: YANGDB <yang.db.dev@gmail.com> * consolidate communication-1.0.0.mapping.json schema to match all across (#849) Signed-off-by: YANGDB <yang.db.dev@gmail.com> * Speed up unit testing CI by updating maxWorkers setting (#884) * Set max CI workers to 2 Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Try setting to 100% of workers Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Switch try it button to be secondary (#887) Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add _refresh call to sync component creation before index creation (#857) * Add _refresh call to sync component creation before index creation Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Switch to using error message Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove redundant catch-rethrow Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove unused imports Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Also wait for refresh on bulk data creation Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Update outdated sidebar and searchbar snapshots Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Make backport only run on merged PRs Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * update backport labels (#898) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update raw data (#891) Signed-off-by: YANGDB <yang.db.dev@gmail.com> * K8s integration (#829) * create new k8s integration Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update k8s integration Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update k8s samples Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update k8s samples Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update k8s metadata schema components Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update k8s metadata schema components Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update k8s dashboard Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update k8s dashboard image Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update k8s dashboard image Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update husky Signed-off-by: YANGDB <yang.db.dev@gmail.com> * revise readme docs Signed-off-by: YANGDB <yang.db.dev@gmail.com> * add OTEL semantic convention support for k8s using mapping aliases Signed-off-by: YANGDB <yang.db.dev@gmail.com> * update according to PR comments Signed-off-by: YANGDB <yang.db.dev@gmail.com> --------- Signed-off-by: YANGDB <yang.db.dev@gmail.com> * consolidate cloud schema to match all across (#846) Signed-off-by: YANGDB <yang.db.dev@gmail.com> * Make OSD Bootstrap more sturdy in CI (#901) * Apply updates from OSD Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Revert accidental flyout change Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add bootstrap cache to CI Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Avoid nested directory traversal on cache hashing Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Tweak path traversal again Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix order of operations for cd Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix CDs again Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Debugging: Add ls Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix CDs (again) Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix directories for caching Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Update cache behavior based on actual bootstrap function Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Re-add plugin linking Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Make hash target smaller Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add a restore key to the cache Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Changes Panel Titles to H2 and rearranges the details content to details panel (#918) * fix name change bug and modify test to test behavior Signed-off-by: Derek Ho <dxho@amazon.com> * update fail backport Signed-off-by: Derek Ho <dxho@amazon.com> * change panel titles to h2 and rearrange Signed-off-by: Derek Ho <dxho@amazon.com> * remove unecessary imports Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * update the README.md with Screenshots section Signed-off-by: YANGDB <yang.db.dev@gmail.com> * align all schema mapping components to contain the following metadata… (#927) * align all schema mapping components to contain the following metadata info: labels: list of the relevant labels that are associated with this mapping component or index template Signed-off-by: YANGDB <yang.db.dev@gmail.com> * align all schema mapping components to contain the following metadata info: labels: list of the relevant labels that are associated with this mapping component or index template Signed-off-by: YANGDB <yang.db.dev@gmail.com> * align all schema mapping components to contain the following metadata info: labels: list of the relevant labels that are associated with this mapping component or index template Signed-off-by: YANGDB <yang.db.dev@gmail.com> --------- Signed-off-by: YANGDB <yang.db.dev@gmail.com> * Update label handling on frontend + Refactors (#931) * Update label display on frontend Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Clear type errors in added_integration.tsx Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove unused imports Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add missing labels Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Autoformat the whole repository Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Revert large sample data changes Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Undo _import autoescape Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix one more missing label change (#934) * Update label display on frontend Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Clear type errors in added_integration.tsx Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove unused imports Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add missing labels Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Autoformat the whole repository Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Revert large sample data changes Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Undo _import autoescape Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Modify snapshots Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Update label handling in table Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Feature/metrics multiline display (#899) * Working multi line viz with new sql Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> * Cleanup conflicts and fn. arguments Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> * Correct metric check fn. Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> * Clean Code Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> * Clean Code Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> * merge dateTime convert function Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> * Update snapshots Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> * Fix cypress test 8_metrics_analytics.spec.js to match removal of "Recently Created" sidebar section. Fix Metric search to be case-insensitive. Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> * Fix several test snapshots. Fix metrics_grid.test coreRefs mock Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> --------- Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Co-authored-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> * Increment version to 3.0.0.0 (#854) Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> * Refactor integration validation logic with a cleaner interface (#943) * Refactor validation logic with a deeper interface Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove redundant test. This test is unneeded after 12c4bcf Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for new validators Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Make better failure mode for invalid objects Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Convert validator methods to use result types Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * update logo related snapshots due to upstream changes (#950) Signed-off-by: Derek Ho <dxho@amazon.com> * Fix all yarn lints for server directory (#953) * Apply yarn auto-lints Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix equalities Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix naming conventions Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix non-export issues Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix default exports Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove unused dependency Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Update mocha (#960) * Update mocha Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Update mocha to 10.2.0 Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Revert mocha to 10.1.0 for OSD compat. Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove random added yaml dep Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * trace analytics collapse dashboard queries, align naming to industry conventions (#514) * trace analytics v2 first remove expensive dashboard page Signed-off-by: Derek Ho <dxho@amazon.com> * get trace groups request working and mapping correctly Signed-off-by: Derek Ho <dxho@amazon.com> * get trace group filter fully working Signed-off-by: Derek Ho <dxho@amazon.com> * try some service map adjustments Signed-off-by: Derek Ho <dxho@amazon.com> * change to up down to fully show labels Signed-off-by: Derek Ho <dxho@amazon.com> * put dashboard in accordian at bottom of services and only make calls if it is open Signed-off-by: Derek Ho <dxho@amazon.com> * some changes to support dashboard content in accordian Signed-off-by: Derek Ho <dxho@amazon.com> * demo code Signed-off-by: Derek Ho <dxho@amazon.com> * fix tests Signed-off-by: Derek Ho <dxho@amazon.com> * remove dashboard from app analytics Signed-off-by: Derek Ho <dxho@amazon.com> * fix up with tests Signed-off-by: Derek Ho <dxho@amazon.com> * fix test Signed-off-by: Derek Ho <dxho@amazon.com> * revert only and extract to constant Signed-off-by: Derek Ho <dxho@amazon.com> * add auth const Signed-off-by: Derek Ho <dxho@amazon.com> * address self-PR review Signed-off-by: Derek Ho <dxho@amazon.com> * remove unecessary code Signed-off-by: Derek Ho <dxho@amazon.com> * change timeout to 25 seconds Signed-off-by: Derek Ho <dxho@amazon.com> * change to row in accordian Signed-off-by: Derek Ho <dxho@amazon.com> * update labels and tests Signed-off-by: Derek Ho <dxho@amazon.com> * update cypress test Signed-off-by: Derek Ho <dxho@amazon.com> * verify cypress tests work with changes Signed-off-by: Derek Ho <dxho@amazon.com> * remove accidental only Signed-off-by: Derek Ho <dxho@amazon.com> * address PR review comments Signed-off-by: Derek Ho <dxho@amazon.com> * make missing configuration more clear Signed-off-by: Derek Ho <dxho@amazon.com> * update snapshots Signed-off-by: Derek Ho <dxho@amazon.com> * update snapshot Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * added code for the change of design of the sidebar, fixed overriding … (#928) * added code for the change of design of the sidebar, fixed overriding spinner bug, changed font size Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * addressed PR comments Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * code for overriding pattern Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * updated snapshots Signed-off-by: sumukhswamy <sumukhhs@amazon.com> --------- Signed-off-by: sumukhswamy <sumukhhs@amazon.com> * update search bar snapshots according to upstream changes (#964) Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: TackAdam <navytackett@hotmail.com> Signed-off-by: Simeon Widdis <sawiddis@amazon.com> Signed-off-by: YANGDB <yang.db.dev@gmail.com> Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Derek Ho <derek01778@gmail.com> Signed-off-by: Daniel Dong <danieldong51@amazon.com> Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Signed-off-by: Haidong <whaidong@amazon.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Dan Dong <58446449+danieldong51@users.noreply.github.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Co-authored-by: TackAdam <navytackett@hotmail.com> Co-authored-by: Simeon Widdis <sawiddis@amazon.com> Co-authored-by: Adam Tackett <105462877+TackAdam@users.noreply.github.com> Co-authored-by: Simeon Widdis <sawiddis@gmail.com> Co-authored-by: YANGDB <yang.db.dev@gmail.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: Anirudha (Ani) Jadhav <anirudha@nyu.edu> Co-authored-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Rupal Mahajan <maharup@amazon.com> Co-authored-by: Daniel Dong <danieldong51@amazon.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: wanghd89 <wanghd89@gmail.com> Co-authored-by: Haidong <whaidong@amazon.com> Co-authored-by: dependabot[bot] <49699333…

* Refactor validation logic with a deeper interface Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove redundant test. This test is unneeded after 12c4bcf Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for new validators Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Make better failure mode for invalid objects Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Convert validator methods to use result types Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

…#946) * Refactor validation logic with a deeper interface * Remove redundant test. This test is unneeded after 12c4bcf * Add tests for new validators * Make better failure mode for invalid objects * Convert validator methods to use result types --------- (cherry picked from commit 09e5d52) Signed-off-by: Simeon Widdis <sawiddis@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…earch-project#943) * Refactor validation logic with a deeper interface Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove redundant test. This test is unneeded after 12c4bcf Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for new validators Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Make better failure mode for invalid objects Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Convert validator methods to use result types Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

* Refactor validation logic with a deeper interface Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove redundant test. This test is unneeded after 12c4bcf Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for new validators Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Make better failure mode for invalid objects Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Convert validator methods to use result types Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

…earch-project#943) (opensearch-project#946) * Refactor validation logic with a deeper interface * Remove redundant test. This test is unneeded after 12c4bcf * Add tests for new validators * Make better failure mode for invalid objects * Convert validator methods to use result types --------- (cherry picked from commit 09e5d52) Signed-off-by: Simeon Widdis <sawiddis@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 0df9072)

Refactor validation logic with a deeper interface

12c4bcf

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

Swiddis requested review from pjfitzgibbons, ps48, kavithacm, derek-ho, joshuali925, dai-chen, YANG-DB, rupal-bq, mengweieric, vamsi-amazon, penghuo, seankao-az and anirudha as code owners August 21, 2023 18:57

Swiddis added integrations Used to denote items related to the Integrations project maintenance labels Aug 21, 2023

Swiddis changed the title ~~Refactor integration validation logic with a deeper interface~~ Refactor integration validation logic with a cleaner interface Aug 21, 2023

Remove redundant test.

412480e

This test is unneeded after 12c4bcf Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

YANG-DB approved these changes Aug 21, 2023

View reviewed changes

Swiddis added 2 commits August 21, 2023 14:12

Add tests for new validators

6d2bad1

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

Make better failure mode for invalid objects

9749d25

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

YANG-DB approved these changes Aug 22, 2023

View reviewed changes

pjfitzgibbons reviewed Aug 22, 2023

View reviewed changes

server/adaptors/integrations/validators.ts Outdated Show resolved Hide resolved

Convert validator methods to use result types

85041c0

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>

pjfitzgibbons approved these changes Aug 22, 2023

View reviewed changes

Swiddis merged commit 09e5d52 into opensearch-project:main Aug 22, 2023
9 checks passed

Swiddis added the backport 2.x label Aug 22, 2023

opensearch-trigger-bot bot mentioned this pull request Aug 22, 2023

[Backport 2.x] Refactor integration validation logic with a cleaner interface #946

Merged

Swiddis mentioned this pull request Aug 22, 2023

Refactor Integrations Backend to abstract IO #947

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor integration validation logic with a cleaner interface #943

Refactor integration validation logic with a cleaner interface #943

Swiddis commented Aug 21, 2023

codecov bot commented Aug 21, 2023 •

edited

Loading

Refactor integration validation logic with a cleaner interface #943

Refactor integration validation logic with a cleaner interface #943

Conversation

Swiddis commented Aug 21, 2023

Description

Issues Resolved

Check List

codecov bot commented Aug 21, 2023 • edited Loading

Codecov Report

codecov bot commented Aug 21, 2023 •

edited

Loading