[Backport 2.x] Refactor integration validation logic with a cleaner interface #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Refactor validation logic with a deeper interface Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove redundant test. This test is unneeded after 12c4bcf Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Add tests for new validators Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Make better failure mode for invalid objects Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Convert validator methods to use result types Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit 09e5d52) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Swiddis
approved these changes
Aug 22, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #946 +/- ##
==========================================
+ Coverage 43.54% 43.57% +0.02%
==========================================
Files 313 313
Lines 18621 18629 +8
Branches 4540 4543 +3
==========================================
+ Hits 8109 8117 +8
- Misses 9959 10470 +511
+ Partials 553 42 -511
Flags with carried forward coverage won't be shown. Click here to find out more. |
mengweieric
approved these changes
Sep 7, 2023
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…earch-project#943) (opensearch-project#946) * Refactor validation logic with a deeper interface * Remove redundant test. This test is unneeded after 12c4bcf * Add tests for new validators * Make better failure mode for invalid objects * Convert validator methods to use result types --------- (cherry picked from commit 09e5d52) Signed-off-by: Simeon Widdis <sawiddis@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 0df9072)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 09e5d52 from #943.