[Backport 2.x] fixed create table async query bug #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* avoid displaying results if no scheme is returned on success for async query Signed-off-by: Paul Sebastian <paulstn@amazon.com> * if there is no schema, will handle case by displaying success/failure regardless Signed-off-by: Paul Sebastian <paulstn@amazon.com> * success callout when no schema returned Signed-off-by: Paul Sebastian <paulstn@amazon.com> * added failure page to async Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fixed some test errors and added snapshots Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update to failure portion Signed-off-by: Paul Sebastian <paulstn@amazon.com> * included tests of loading and failure states Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> (cherry picked from commit 55d6352) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand and
anirudha
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #162 +/- ##
==========================================
- Coverage 54.79% 54.65% -0.14%
==========================================
Files 33 33
Lines 1356 1396 +40
Branches 210 224 +14
==========================================
+ Hits 743 763 +20
- Misses 535 548 +13
- Partials 78 85 +7
Flags with carried forward coverage won't be shown. Click here to find out more. |
ps48
approved these changes
Oct 18, 2023
Swiddis
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 55d6352 from #158.