Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed create table async query bug #158

Merged
merged 7 commits into from
Oct 18, 2023
Merged

fixed create table async query bug #158

merged 7 commits into from
Oct 18, 2023

Conversation

paulstn
Copy link
Collaborator

@paulstn paulstn commented Oct 17, 2023 •
edited
Loading

Description

fixed create table async query bug, also added content to show a success without schema and also failure

Screen.Recording.2023-10-18.at.11.15.25.AM.mov

Update to failure portion:

Screen.Recording.2023-10-18.at.2.30.57.PM.mov

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited
Loading

Codecov Report

Merging #158 (b1cda6e) into main (43b085b) will increase coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
+ Coverage   54.51%   54.65%   +0.14%     
==========================================
  Files          33       33              
  Lines        1385     1396      +11     
  Branches      220      224       +4     
==========================================
+ Hits          755      763       +8     
- Misses        546      548       +2     
- Partials       84       85       +1
Flag Coverage Δ
dashboards-query-workbench 54.65% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@paulstn paulstn closed this Oct 18, 2023
@paulstn paulstn reopened this Oct 18, 2023
Swiddis
Swiddis approved these changes Oct 18, 2023
View reviewed changes
public/components/QueryResults/AsyncQueryBody.tsx Outdated Show resolved Hide resolved
public/components/Main/main.tsx Show resolved Hide resolved
@paulstn
avoid displaying results if no scheme is returned on success for asyn…
1b23cf6 
…c query

Signed-off-by: Paul Sebastian <paulstn@amazon.com>
@paulstn
if there is no schema, will handle case by displaying success/failure…
ea1cdc8 
… regardless

Signed-off-by: Paul Sebastian <paulstn@amazon.com>
@paulstn
success callout when no schema returned
4094af2 
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
@paulstn
added failure page to async
eaf261a 
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
@paulstn
fixed some test errors and added snapshots
c34d7f0 
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
@paulstn
update to failure portion
102e158 
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
@paulstn paulstn force-pushed the async_create_table_bug_fix branch from cb7ba40 to 102e158 Compare October 18, 2023 21:37
@paulstn
included tests of loading and failure states
b1cda6e 
Signed-off-by: Paul Sebastian <paulstn@amazon.com>
@paulstn paulstn requested a review from ps48 October 18, 2023 22:15
@Swiddis Swiddis merged commit 55d6352 into opensearch-project:main Oct 18, 2023
11 checks passed
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 18, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 18, 2023
@github-actions
fixed create table async query bug (#158)
3703628 
* avoid displaying results if no scheme is returned on success for async query

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* if there is no schema, will handle case by displaying success/failure regardless

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* success callout when no schema returned

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* added failure page to async

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fixed some test errors and added snapshots

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update to failure portion

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* included tests of loading and failure states

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>
(cherry picked from commit 55d6352)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 18, 2023
@github-actions
fixed create table async query bug (#158)
50a2458 
* avoid displaying results if no scheme is returned on success for async query

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* if there is no schema, will handle case by displaying success/failure regardless

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* success callout when no schema returned

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* added failure page to async

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* fixed some test errors and added snapshots

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* update to failure portion

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* included tests of loading and failure states

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

---------

Signed-off-by: Paul Sebastian <paulstn@amazon.com>
(cherry picked from commit 55d6352)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 18, 2023
Merged
ps48 pushed a commit that referenced this pull request Oct 18, 2023
@opensearch-trigger-bot @github-actions
fixed create table async query bug (#158) (#163)
1964008 
* avoid displaying results if no scheme is returned on success for async query



* if there is no schema, will handle case by displaying success/failure regardless



* success callout when no schema returned



* added failure page to async



* fixed some test errors and added snapshots



* update to failure portion



* included tests of loading and failure states



---------


(cherry picked from commit 55d6352)

Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Oct 19, 2023
@opensearch-trigger-bot @github-actions
fixed create table async query bug (#158) (#162)
b8cfed5 
* avoid displaying results if no scheme is returned on success for async query



* if there is no schema, will handle case by displaying success/failure regardless



* success callout when no schema returned



* added failure page to async



* fixed some test errors and added snapshots



* update to failure portion



* included tests of loading and failure states



---------


(cherry picked from commit 55d6352)

Signed-off-by: Paul Sebastian <paulstn@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric added a commit to mengweieric/dashboards-query-workbench that referenced this pull request Nov 8, 2023
@mengweieric
Revert "fixed create table async query bug (opensearch-project#158) (o…
d924dea 
…pensearch-project#163)"

This reverts commit 1964008.
mengweieric added a commit to mengweieric/dashboards-query-workbench that referenced this pull request Nov 8, 2023
@mengweieric
Revert "fixed create table async query bug (opensearch-project#158) (o…
c017ead 
…pensearch-project#163)"

This reverts commit 1964008.

Signed-off-by: Eric <menwe@amazon.com>
mengweieric added a commit that referenced this pull request Nov 13, 2023
@mengweieric
Revert commits back to after 2.11 release (#211)
32a7495 
* Revert "Fix error handling for user w/o proper permissions (#195) (#197)"

This reverts commit 26ed0dc.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Increment version to 2.11.1.0 (#186)"

This reverts commit b18f5f4.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "added fix for loading spinner issue for other database (#189) (#192)"

This reverts commit 94805c5.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "UI-bug fixes, added create query for MV (#182) (#188)"

This reverts commit 4187b6d.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Add backticks and remove ckpt for manual refresh in acceleration flyout (#183) (#185)"

This reverts commit f96c5d9.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Session update, minor fixes for acceleration flyout (#179) (#181)"

This reverts commit 257fb53.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "UI fixes for loading state, empty tree, added toast for error, fixed no indicies error (#176) (#178)"

This reverts commit 3c47d47.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Make checkpoint mandatory, add watermark delay, minor UI fixes (#173) (#175)"

This reverts commit 0198fa7.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "design changes for loading, changed the banner, updated tests (#170) (#172)"

This reverts commit 786c7c7.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Support dark mode and session for sql, minor bug fixes (#165) (#169)"

This reverts commit 0f5673a.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Added changes for making tree view persistent, made changes for bugs for loading screen (#153) (#167)"

This reverts commit 2269d1d.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "fixed create table async query bug (#158) (#163)"

This reverts commit 1964008.

Signed-off-by: Eric <menwe@amazon.com>

---------

Signed-off-by: Eric <menwe@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swiddis Swiddis Swiddis approved these changes

@ps48 ps48 ps48 approved these changes

@pjfitzgibbons pjfitzgibbons Awaiting requested review from pjfitzgibbons

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@vmmusings vmmusings Awaiting requested review from vmmusings

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulstn @ps48 @Swiddis