Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session update, minor fixes for acceleration flyout #179

Merged
merged 7 commits into from
Oct 25, 2023
Merged

Session update, minor fixes for acceleration flyout #179

merged 7 commits into from
Oct 25, 2023

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Oct 25, 2023 •
edited
Loading

Description

  1. Remove clearing session from storage
  2. Update acceleration flytout primary shard count to 5
  3. Fix MV index preview name in acceleration flyout
  4. Clear query and result window on datasource change
  5. Fix MV tumble validation issue, increase form width
  6. Update S3 regex to allow buckets
  7. Add toasts for failure response in acceleration flyout
  8. Update tests

Issues Resolved

#127

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ps48
update session if not null
aa3712a 
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
@codecov
Copy link

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

Merging #179 (abcada9) into main (015cab8) will decrease coverage by 4.31%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
- Coverage   58.21%   53.91%   -4.31%     
==========================================
  Files          33       33              
  Lines        1546     1560      +14     
  Branches      270      274       +4     
==========================================
- Hits          900      841      -59     
- Misses        622      628       +6     
- Partials       24       91      +67
Flag Coverage Δ
dashboards-query-workbench 53.91% <ø> (-4.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 17 files with indirect coverage changes

ps48 added 2 commits October 25, 2023 10:02
@ps48
clear query and window on datasource selection
6711e9d 
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
@ps48
update primary shard to 5 and MV index preview name
3c2deaf 
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
@ps48 ps48 changed the title Remove clearing session from storage Session update, minor fixes for acceleration flyout Oct 25, 2023
ps48 added 4 commits October 25, 2023 11:17
@ps48
update tumble input width and MV validation
a6fac65 
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
@ps48
update s3 regex
984defc 
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
@ps48
Add toast for load failure in acc flyout
9504505 
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
@ps48
add error toasts for invalid job id
abcada9 
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
@ps48 ps48 merged commit 16e2e1c into opensearch-project:main Oct 25, 2023
10 of 11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 25, 2023
@github-actions
Session update, minor fixes for acceleration flyout (#179)
c16e21b 
* update session if not null

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* clear query and window on datasource selection

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update primary shard to 5 and MV index preview name

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update tumble input width and MV validation

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update s3 regex

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* Add toast for load failure in acc flyout

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* add error toasts for invalid job id

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

---------

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
(cherry picked from commit 16e2e1c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Oct 25, 2023
Merged
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 25, 2023
@github-actions
Session update, minor fixes for acceleration flyout (#179)
cfeeaab 
* update session if not null

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* clear query and window on datasource selection

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update primary shard to 5 and MV index preview name

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update tumble input width and MV validation

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update s3 regex

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* Add toast for load failure in acc flyout

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* add error toasts for invalid job id

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

---------

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
(cherry picked from commit 16e2e1c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Oct 25, 2023
@opensearch-trigger-bot @github-actions
Session update, minor fixes for acceleration flyout (#179) (#181)
257fb53 
* update session if not null



* clear query and window on datasource selection



* update primary shard to 5 and MV index preview name



* update tumble input width and MV validation



* update s3 regex



* Add toast for load failure in acc flyout



* add error toasts for invalid job id



---------


(cherry picked from commit 16e2e1c)

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Oct 25, 2023
@opensearch-trigger-bot @github-actions
Session update, minor fixes for acceleration flyout (#179) (#180)
17d230d 
* update session if not null



* clear query and window on datasource selection



* update primary shard to 5 and MV index preview name



* update tumble input width and MV validation



* update s3 regex



* Add toast for load failure in acc flyout



* add error toasts for invalid job id



---------


(cherry picked from commit 16e2e1c)

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric added a commit to mengweieric/dashboards-query-workbench that referenced this pull request Nov 8, 2023
@mengweieric
Revert "Session update, minor fixes for acceleration flyout (opensear…
9dc81b9 
…ch-project#179) (opensearch-project#181)"

This reverts commit 257fb53.
mengweieric added a commit to mengweieric/dashboards-query-workbench that referenced this pull request Nov 8, 2023
@mengweieric
Revert "Session update, minor fixes for acceleration flyout (opensear…
2b7fba3 
…ch-project#179) (opensearch-project#181)"

This reverts commit 257fb53.

Signed-off-by: Eric <menwe@amazon.com>
mengweieric added a commit that referenced this pull request Nov 13, 2023
@mengweieric
Revert commits back to after 2.11 release (#211)
32a7495 
* Revert "Fix error handling for user w/o proper permissions (#195) (#197)"

This reverts commit 26ed0dc.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Increment version to 2.11.1.0 (#186)"

This reverts commit b18f5f4.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "added fix for loading spinner issue for other database (#189) (#192)"

This reverts commit 94805c5.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "UI-bug fixes, added create query for MV (#182) (#188)"

This reverts commit 4187b6d.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Add backticks and remove ckpt for manual refresh in acceleration flyout (#183) (#185)"

This reverts commit f96c5d9.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Session update, minor fixes for acceleration flyout (#179) (#181)"

This reverts commit 257fb53.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "UI fixes for loading state, empty tree, added toast for error, fixed no indicies error (#176) (#178)"

This reverts commit 3c47d47.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Make checkpoint mandatory, add watermark delay, minor UI fixes (#173) (#175)"

This reverts commit 0198fa7.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "design changes for loading, changed the banner, updated tests (#170) (#172)"

This reverts commit 786c7c7.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Support dark mode and session for sql, minor bug fixes (#165) (#169)"

This reverts commit 0f5673a.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Added changes for making tree view persistent, made changes for bugs for loading screen (#153) (#167)"

This reverts commit 2269d1d.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "fixed create table async query bug (#158) (#163)"

This reverts commit 1964008.

Signed-off-by: Eric <menwe@amazon.com>

---------

Signed-off-by: Eric <menwe@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mengweieric mengweieric mengweieric approved these changes

@YANG-DB YANG-DB YANG-DB approved these changes

@pjfitzgibbons pjfitzgibbons Awaiting requested review from pjfitzgibbons

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@vmmusings vmmusings Awaiting requested review from vmmusings

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ps48 @YANG-DB @mengweieric