[Backport 2.x] Session update, minor fixes for acceleration flyout #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* update session if not null Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * clear query and window on datasource selection Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update primary shard to 5 and MV index preview name Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update tumble input width and MV validation Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update s3 regex Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Add toast for load failure in acc flyout Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add error toasts for invalid job id Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit 16e2e1c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand and
anirudha
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #180 +/- ##
==========================================
- Coverage 54.79% 53.91% -0.89%
==========================================
Files 33 33
Lines 1356 1560 +204
Branches 210 274 +64
==========================================
+ Hits 743 841 +98
- Misses 535 628 +93
- Partials 78 91 +13
Flags with carried forward coverage won't be shown. Click here to find out more. |
ps48
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 16e2e1c from #179.