Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Create Maps section and move pages #2424

Closed
wants to merge 40 commits into from
Closed

[DOC] Create Maps section and move pages #2424

wants to merge 40 commits into from

Conversation

vagimeli
Copy link
Collaborator

@vagimeli vagimeli commented Jan 18, 2023 •
edited
Loading

Signed-off-by: vagimeli vagimeli@amazon.com

Description

Create Maps section and move pages; related to TOC restructure

Issues Resolved

#2402
#2317

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vagimeli
Create Maps section and move pages
9a618a5 
Signed-off-by: vagimeli <vagimeli@amazon.com>
@vagimeli vagimeli requested a review from a team as a code owner January 18, 2023 18:43
@vagimeli vagimeli self-assigned this Jan 18, 2023
@vagimeli vagimeli added backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x 4 - Doc review PR: Doc review in progress backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 backport 2.4 PR: Backport label for 2.4 labels Jan 18, 2023
@vagimeli
Copy link
Collaborator Author

vagimeli commented Jan 18, 2023 •
edited
Loading

@Naarcha-AWS Will you review the front matter to confirm it's accurate, particularly the redirect links? This is related to the TOC restructure.

cwillum
cwillum suggested changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@cwillum cwillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Naarcha-AWS
Naarcha-AWS requested changes Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@Naarcha-AWS Naarcha-AWS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add redirects for the two other pages, but it looks good locally.

_dashboards/maps/selfhost-maps-server.md Show resolved Hide resolved
_dashboards/maps/maps.md Show resolved Hide resolved
@vagimeli
Edit front matter
2765900 
Signed-off-by: vagimeli <vagimeli@amazon.com>
@vagimeli vagimeli added 6 - Done but waiting to merge PR: The work is done and ready to merge v2.5.0 'Issues and PRs related to version v2.5.0' and removed 4 - Doc review PR: Doc review in progress backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 backport 2.4 PR: Backport label for 2.4 labels Jan 18, 2023
hdhalter
hdhalter reviewed Jan 18, 2023
View reviewed changes
Copy link
Contributor

@hdhalter hdhalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Melissa, just some feedback on the titles. Thx.

_dashboards/maps/selfhost-maps-server.md Outdated Show resolved Hide resolved
_dashboards/maps/maptiles.md Outdated Show resolved Hide resolved
@Naarcha-AWS Naarcha-AWS added 6 - Done but waiting to merge PR: The work is done and ready to merge and removed 6 - Done but waiting to merge PR: The work is done and ready to merge v2.5.0 'Issues and PRs related to version v2.5.0' labels Jan 19, 2023
kolchfa-aws and others added 25 commits January 27, 2023 12:47
@kolchfa-aws @vagimeli
Adds second image style with no border (#2445)
e660bd6 
Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
@vagimeli
Adds installation guide for OpenSearch Dashboards debian distribution (…
ef02ba3 
…#2440)

* Fixed typo in OS install and added page for debian osd install

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>

* Replaced sample responses now that the 2.5 artifact is available

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>

* Doing more things

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>

* Prune overview narrative section and add steps for manual package install

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>

* Fixing some formatting issues and adding fingerprint verification steps

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>

* Working on APT repository steps

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>

* Fix typo in os core install guide

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>

* Modification after verifying steps and removed reference to fingerprint since it isnt in the console output

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>

* Wrapping up

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>

* Fix to repo entry

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>

* Updating links

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>

* Applying doc review feedback

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>
@cwillum @vagimeli
Update field mapping documentation for Security Analytics (#2422)
3955777 
* fix#2400-field-mappings

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#2400-field-mappings

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#2400-field-mappings

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#2400-field-mappings

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#2400-field-mappings

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#2400-field-mappings

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#2400-field-mappings

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#2400-field-mappings

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#2400-field-mappings

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#2400-field-mappings

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#2400-field-mappings

Signed-off-by: cwillum <cwmmoore@amazon.com>

* fix#2400-field-mappings

Signed-off-by: cwillum <cwmmoore@amazon.com>

Signed-off-by: cwillum <cwmmoore@amazon.com>
@carolxob @vagimeli
Minor changes to Data Prepper index.md. (#2426)
787fc76 
* Minor changes to index.md.

Signed-off-by: carolxob <carolxob@amazon.com>

* Minor typo/formatting fixes.

Signed-off-by: carolxob <carolxob@amazon.com>

* Minor change.

Signed-off-by: carolxob <carolxob@amazon.com>

* Adjusted ToC order so that Getting started appears before Core APIs.

Signed-off-by: carolxob <carolxob@amazon.com>

* Minor edits to titles.

Signed-off-by: carolxob <carolxob@amazon.com>

* Minor adjustments to ToC.

Signed-off-by: carolxob <carolxob@amazon.com>

* Changed filename.

Signed-off-by: carolxob <carolxob@amazon.com>

* Minor ToC edit

Signed-off-by: carolxob <carolxob@amazon.com>

* Minor edits.

Signed-off-by: carolxob <carolxob@amazon.com>

* Minor edit.

Signed-off-by: carolxob <carolxob@amazon.com>

* Edits made based on editorial feedback.

Signed-off-by: carolxob <carolxob@amazon.com>

Signed-off-by: carolxob <carolxob@amazon.com>
@vagimeli
Editorial changes (#2454)
52659f7 
Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>

Signed-off-by: JeffH-AWS <jeffhuss@amazon.com>
@amitgalitz @Naarcha-AWS
@kolchfa-aws @vagimeli
add two new settings for Anomaly Detection 2.5 (#2450)
d53c9c6 
* add two new settings for Anomaly Detection

Signed-off-by: Amit Galitzky <amgalitz@amazon.com>

* fixed setting mistake

Signed-off-by: Amit Galitzky <amgalitz@amazon.com>

* Update _monitoring-plugins/ad/settings.md

* Update _monitoring-plugins/ad/settings.md

* Update _monitoring-plugins/ad/settings.md

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>

Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
@Naarcha-AWS @ylwu-amzn
@kolchfa-aws @vagimeli
Add new ML cluster settings for 2.5 (#2442)
02d7c7d 
* Add new ML cluster settings for 2.5

Signed-off-by: Naarcha-AWS <naarcha@amazon.com>

* Update _ml-commons-plugin/cluster-settings.md

* Update model-serving-framework.md

* Update _ml-commons-plugin/cluster-settings.md

Co-authored-by: Yaliang Wu <ylwu@amazon.com>

* Update _ml-commons-plugin/cluster-settings.md

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>

* Update _ml-commons-plugin/cluster-settings.md

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>

* Update _ml-commons-plugin/cluster-settings.md

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>

* Update _ml-commons-plugin/cluster-settings.md

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>

* Update _ml-commons-plugin/model-serving-framework.md

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>

* Update cluster-settings.md

* Update cluster-settings.md

Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
Co-authored-by: Yaliang Wu <ylwu@amazon.com>
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
@Naarcha-AWS @vagimeli
Remove Install and Configure home page (#2449)
2eba0f2 
* Remove install and configure home page

Signed-off-by: Naarcha-AWS <naarcha@amazon.com>

* Add gerunds to plugin and configuration titles

Signed-off-by: Naarcha-AWS <naarcha@amazon.com>

* Make titles gerunds

Signed-off-by: Naarcha-AWS <naarcha@amazon.com>

* Small tweaks

Signed-off-by: Naarcha-AWS <naarcha@amazon.com>

* Update plugins.md

* Remove index page

Signed-off-by: Naarcha-AWS <naarcha@amazon.com>

Signed-off-by: Naarcha-AWS <naarcha@amazon.com>
@vagimeli
Revert "Admin UI further editorial updates (#2444)"
6138632 
This reverts commit 5f7e570.
@vagimeli
Revert "Adds second image style with no border (#2445)"
22503d7 
This reverts commit e660bd6.
@vagimeli
Revert "Update field mapping documentation for Security Analytics (#2422
54011dc 
)"

This reverts commit 3955777.
@vagimeli
Revert "Minor changes to Data Prepper index.md. (#2426)"
4c33af8 
This reverts commit 787fc76.
@vagimeli
Revert "Editorial changes (#2454)"
f7b26f5 
This reverts commit 52659f7.
@vagimeli
Revert "add two new settings for Anomaly Detection 2.5 (#2450)"
2478ae2 
This reverts commit d53c9c6.
@vagimeli
Revert "Remove Install and Configure home page (#2449)"
00aaeba 
This reverts commit 2eba0f2.
@vagimeli
Revert "Updates to Security Analytics documentation (#2408)"
ccbd807 
This reverts commit d71887c.
@vagimeli
Revert "Add GPU acceleration documentation (#2384)"
e47a6ab 
This reverts commit 753b45e.
@vagimeli
Revert "Adds cluster health by awareness attribute documentation (#2398…
9a5356d 
…)"

This reverts commit bd93752.
@vagimeli
Revert "Updates remote-backed storage documentation (#2363)"
dfbf529 
This reverts commit c441bef.
@vagimeli
Revert "Add Query String for rollups (#2428)"
27fc393 
This reverts commit 8026b6d.
@vagimeli
Revert "Adds query string query documentation (#2427)"
643a5d9 
This reverts commit 6fb83d8.
@vagimeli
Revert "Editorial for Admin UI index operations (#2421)"
fa2808b 
This reverts commit 87859f8.
@vagimeli
Revert "Move pages (#2425)"
38402b7 
This reverts commit 7f6096d.
@vagimeli
Revert "Adds installation guide for OpenSearch Dashboards debian dist…
b869d85 
…ribution (#2440)"

This reverts commit ef02ba3.
@vagimeli
Revert "Add new ML cluster settings for 2.5 (#2442)"
f6ef40e 
This reverts commit 02d7c7d.
@vagimeli vagimeli added Closed - Duplicate or Cancelled Issue: Nothing to be done and removed 6 - Done but waiting to merge PR: The work is done and ready to merge labels Feb 3, 2023
@vagimeli
Copy link
Collaborator Author

vagimeli commented Feb 3, 2023

Duplicate PR. See #2621

@vagimeli vagimeli closed this Feb 3, 2023
@Naarcha-AWS Naarcha-AWS deleted the maps-TOC-restructure branch March 28, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junqiu-lei junqiu-lei junqiu-lei left review comments

@cwillum cwillum Awaiting requested review from cwillum

@Naarcha-AWS Naarcha-AWS Awaiting requested review from Naarcha-AWS Naarcha-AWS is a code owner

@hdhalter hdhalter Awaiting requested review from hdhalter

Assignees

@vagimeli vagimeli

Labels
Closed - Duplicate or Cancelled Issue: Nothing to be done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@vagimeli @junqiu-lei @Naarcha-AWS @hdhalter @cwillum @kolchfa-aws @ariamarble @carolxob @amitgalitz