Add sections for removing OpenSearch Dashboards Security plugin #5830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation types Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com>
john-eliatra
requested review from
hdhalter,
kolchfa-aws,
Naarcha-AWS,
vagimeli,
ananzh,
AMoo-Miki and
natebower
as code owners
Co-authored-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com> Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com>
Co-authored-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com> Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com>
Making the changes suggested by reviewer to move the paragraph relating to Dashboards removal down to the Remove OpenSearch Dashboards plugin section. Also, changing the headings within that section from 'Binary' to 'Tarball', and from 'Service' to 'RPM and Debian' to reflect the wording used for those types in the OpenSearch Installation sections. Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com>
Naarcha-AWS
added
4 - Doc review
Naarcha-AWS
requested changes
Dec 14, 2023
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com>
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com>
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com>
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com>
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com>
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com>
Clarify the location of the running OpenSearch Dashboards instance before stopping it with the Ctrl + C command. Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com>
Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com>
natebower
requested changes
Dec 18, 2023
There was a problem hiding this comment.
@john-eliatra @Naarcha-AWS Please see my comments and changes and let me know if you have any questions. I'd like to read lines 46, 83, and 110 again before approving, so please tag me when complete. Thanks!
_security/configuration/disable.md
Outdated
| 1. In `docker-compose.yml`, change `opensearchproject/opensearch-dashboards:{{site.opensearch_dashboards_version}}` to `opensearch-dashboards-no-security`. | ||
| 1. Change `OPENSEARCH_HOSTS` or `opensearch.hosts` to `http://` rather than `https://`. | ||
| 1. Enter `docker-compose up`. | ||
| 1. Remove all Security plugin related configuration from the opensearch_dashbaords.yml file, or use the example file and place the file in the `/etc/opensearch_dashboards` folder. |
There was a problem hiding this comment.
"Remove all Security plugin related configuration" needs a little revision for clarity.
Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com>
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Quick fix on couple of typos of opensearch_dashboards.yml Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com>
natebower
reviewed
Dec 19, 2023
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Naarcha-AWS
approved these changes
Dec 20, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 20, 2023
* Add sections for removing Dashboards Security plugin in other installation types Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com> * Update _security/configuration/disable.md Co-authored-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com> Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com> * Update _security/configuration/disable.md Co-authored-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com> Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com> * Update disable.md Making the changes suggested by reviewer to move the paragraph relating to Dashboards removal down to the Remove OpenSearch Dashboards plugin section. Also, changing the headings within that section from 'Binary' to 'Tarball', and from 'Service' to 'RPM and Debian' to reflect the wording used for those types in the OpenSearch Installation sections. Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com> * Update _security/configuration/disable.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com> * Update _security/configuration/disable.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com> * Update _security/configuration/disable.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com> * Update _security/configuration/disable.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com> * Update _security/configuration/disable.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com> * Update _security/configuration/disable.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com> * Update disable.md Clarify the location of the running OpenSearch Dashboards instance before stopping it with the Ctrl + C command. Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com> * Update disable.md Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com> * Update the HMAC authentication requirements of exchange_key Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Update disable.md Quick fix on couple of typos of opensearch_dashboards.yml Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> --------- Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com> (cherry picked from commit ef7cace) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Naarcha-AWS
added a commit
that referenced
this pull request
Dec 20, 2023
… (#5926) * Add sections for removing Dashboards Security plugin in other installation types * Update _security/configuration/disable.md * Update _security/configuration/disable.md * Update disable.md Making the changes suggested by reviewer to move the paragraph relating to Dashboards removal down to the Remove OpenSearch Dashboards plugin section. Also, changing the headings within that section from 'Binary' to 'Tarball', and from 'Service' to 'RPM and Debian' to reflect the wording used for those types in the OpenSearch Installation sections. * Update _security/configuration/disable.md * Update _security/configuration/disable.md * Update _security/configuration/disable.md * Update _security/configuration/disable.md * Update _security/configuration/disable.md * Update _security/configuration/disable.md * Update disable.md Clarify the location of the running OpenSearch Dashboards instance before stopping it with the Ctrl + C command. * Update disable.md * Update the HMAC authentication requirements of exchange_key * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review * Update disable.md Quick fix on couple of typos of opensearch_dashboards.yml * Apply suggestions from code review --------- (cherry picked from commit ef7cace) Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com>
20 tasks
hdhalter
added
the
Feedback
vagimeli
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Add sections for removing Dashboards Security plugin in other installation types Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com> * Update _security/configuration/disable.md Co-authored-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com> Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com> * Update _security/configuration/disable.md Co-authored-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com> Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com> * Update disable.md Making the changes suggested by reviewer to move the paragraph relating to Dashboards removal down to the Remove OpenSearch Dashboards plugin section. Also, changing the headings within that section from 'Binary' to 'Tarball', and from 'Service' to 'RPM and Debian' to reflect the wording used for those types in the OpenSearch Installation sections. Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com> * Update _security/configuration/disable.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com> * Update _security/configuration/disable.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com> * Update _security/configuration/disable.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com> * Update _security/configuration/disable.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com> * Update _security/configuration/disable.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com> * Update _security/configuration/disable.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com> * Update disable.md Clarify the location of the running OpenSearch Dashboards instance before stopping it with the Ctrl + C command. Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com> * Update disable.md Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com> * Update the HMAC authentication requirements of exchange_key Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Update disable.md Quick fix on couple of typos of opensearch_dashboards.yml Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> --------- Signed-off-by: John Heraghty <148883955+john-eliatra@users.noreply.github.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The steps for disabling security needed more info relating to removing the securityDashboards plugin
Issues Resolved
Fixes #5812
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.