[backport 1.x] Added option for httpHostPort and transportHostPort
#400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sbnmanthey Can you resolve the conflicts here and also address the lint failure? Most likely you need to address the chart version here? |
Signed-off-by: Sebastian Manthey <sbnmanthey@gmail.com>
sbnmanthey
force-pushed
the
add-hostPort-1.x
branch
from
25b746b to
00f2fcf
Compare
Signed-off-by: Sebastian Manthey <sbnmanthey@gmail.com>
sbnmanthey
force-pushed
the
add-hostPort-1.x
branch
from
00f2fcf to
a563f8d
Compare
|
@TheAlgo @DandyDeveloper I've bumped the chartVersion as requested, can you approve my PR? |
|
@sbnmanthey Please resolve conflicts. Thank you! |
|
Backport was already applied in #411. I close this PR unmerged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds options for
httpHostPortandtransportHostPortin 1.x (Backport)Issues Resolved
Resolves #335 in 1.x
Check List
For any changes to files within Helm chart directories:
CHANGELOG.mdupdated to reflect changeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.