Adding L2 norm technique #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
martin-gaievski
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
sean-zheng-amazon,
model-collapse,
wujunshen,
zane-neo,
ylwu-amzn and
jngz-es
as code owners
Codecov Report
@@ Coverage Diff @@
## feature/normalization #236 +/- ##
===========================================================
- Coverage 85.95% 82.43% -3.53%
- Complexity 310 323 +13
===========================================================
Files 24 26 +2
Lines 904 979 +75
Branches 137 153 +16
===========================================================
+ Hits 777 807 +30
- Misses 67 108 +41
- Partials 60 64 +4
|
heemin32
reviewed
Jul 28, 2023
.../java/org/opensearch/neuralsearch/processor/normalization/L2ScoreNormalizationTechnique.java
Outdated
Show resolved
Hide resolved
.../java/org/opensearch/neuralsearch/processor/normalization/L2ScoreNormalizationTechnique.java
Outdated
Show resolved
Hide resolved
.../java/org/opensearch/neuralsearch/processor/normalization/L2ScoreNormalizationTechnique.java
Outdated
Show resolved
Hide resolved
.../java/org/opensearch/neuralsearch/processor/normalization/L2ScoreNormalizationTechnique.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
heemin32
approved these changes
Jul 28, 2023
navneet1v
approved these changes
Jul 31, 2023
HenryL27
reviewed
Jul 31, 2023
Comment on lines
+49
to
+65
| public float combine(final float[] scores) { | ||
| float combinedScore = 0.0f; | ||
| float weights = 0; | ||
| for (int indexOfSubQuery = 0; indexOfSubQuery < scores.length; indexOfSubQuery++) { | ||
| float score = scores[indexOfSubQuery]; | ||
| if (score >= 0.0) { | ||
| float weight = getWeightForSubQuery(indexOfSubQuery); | ||
| score = score * weight; | ||
| combinedScore += score; | ||
| weights += weight; | ||
| } | ||
| } | ||
| if (weights == 0.0f) { | ||
| return ZERO_SCORE; | ||
| } | ||
| return combinedScore / weights; | ||
| } |
There was a problem hiding this comment.
weighted harmonic mean = sum(wi) / sum(1/(wi*si))
https://en.wikipedia.org/wiki/Harmonic_mean
There was a problem hiding this comment.
Thanks @HenryL27 , that's what I'm working now and it will be a new PR for harmonic mean and weighted geometric combination. Probably checked in this class incidentally in a half-ready form.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding L2 normalization technique for normalization processor. Essentially L2 norm is "score" divided by square root of sum of score squares (more details here). Example of pipeline with processor config:
Issues Resolved
#228, part of solution for #126
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.